Patch Set 1: Code-Review+1
I would +2 this, but we need to be careful to synchronize this with the changes
for the OE nightly builds to avoid breakage
--
To view, visit https://gerrit.osmocom.org/2224
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2179
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0e2164d84b8cbcc6fe6a090fc7f40a1251421d7
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2183/5/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:
Line 57: struct msgb *gsm0808_create_paging(char *imsi, uint32_t *tmsi,
const for all pointers?
--
To view, visit https://gerrit.osmocom.org/2183
To
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2227/1/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:
Line 698: DEBUGP(DNM, "Opstart acked\n");
opstart of whom? you should make an effort to print the BTS number [from oml
header] as well as
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2184/5/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:
Line 44: struct msgb *gsm0808_create_assignment(struct gsm0808_channel_type *ct,
again const?
--
To view, visit https://gerrit.osmocom.org/2184
To
Patch Set 1: Code-Review+1
sames as for the other change, we must make sure that the nightly builds won't
break, or if they break manually fix up and build them again.
--
To view, visit https://gerrit.osmocom.org/2225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2176
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57933b0a06a3f54ec2a41e6ecb6ced9fbbc89332
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
for some reason this doens't work on FreeBSD 11.x with ortp-0.27. The
configure script never any line regarding ortp domain and sets
HAVE_ORTP_LOG_DOMAIN to 0, despite it being required.
--
To view, visit https://gerrit.osmocom.org/2164
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2214
to look at the new patch set (#2).
Add tests for xUA code + SCCP/SUA transcoding
Change-Id: I7ce038d72dca18fb83d5a12519c9a48267e52ab8
---
M configure.ac
M tests/Makefile.am
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2219
to look at the new patch set (#2).
Add example program how to use M3UA+SCCP client and server
This is an example tool that can be run either as server (SG) or as
client (ASP) with a
Review at https://gerrit.osmocom.org/
Fix HAVE_ORTP_LOG_DOMAIN detection on FreeBSD
We need to use the include path[s] resolved by pkg-config for
ortp before trying to compile our test program. Without this
patch, compilation will fail e.g. on FreeBSD 11.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2215
to look at the new patch set (#3).
Add new SCCP implementation
This is an implementation of SCCP as specified in ITO-T Q.71x,
particularly the SCRC (routing), SCLC (Connectionless) and
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2218
to look at the new patch set (#2).
SUA: Port to new osmo_ss7 and SCCP code
If we use the infrastructure provided by osmo_ss7 on the lower layer and
the SCCP SCRC, SCLC and SCOC code on
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2220
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea0d3db34a3674a9c6422b174a879bfdaa25786f
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2212
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7067a85dcc5dda66f4b17b0fe08da8cb3efe79ef
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2213
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8151a9b08a0b0ca97b9c73105ad4548512ce3be8
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2211
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I186df77cbdbedfe1a60b855be3626b6766f4681c
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2196
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I083634db9c3606bcff87700f253054a38a20816d
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2217
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I442634ca74d9c4cd386726a9d6b933a12f45afc5
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2218
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193b74f58aa70c443ae17e78b5604246d6bc3f71
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2216
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie471a197856c875eb4987bf9858d757312de24fb
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review-2
--
To view, visit https://gerrit.osmocom.org/2210
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I966103f30b9be247ba6905ba8e06b87654d9981a
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review-2
--
To view, visit https://gerrit.osmocom.org/2211
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I186df77cbdbedfe1a60b855be3626b6766f4681c
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c95e37cc449297389bf31dd9d5dcaa922d75d0c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Harald Welte has abandoned this change.
Change subject: vty/vty.c: Check return value of tc{get,set}attr() calls
..
Abandoned
not the right solution
--
To view, visit https://gerrit.osmocom.org/1298
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2179
to look at the new patch set (#3).
gsm0808: Add utils for Channel Type
The planned support for true A over IP requires the encoding of
the a Channel Type element (see also ASSIGNMENT
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2176
to look at the new patch set (#3).
gsm0808: Add utils for AoIP Transport Layer Address
The planned support for true A over IP requires the encoding and
decoding of a so called "AoIP
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2178
to look at the new patch set (#3).
gsm0808: Add AoIP specific elements to gsm0808_create_... functions
the classic A implementation in libosmocore lacks support for AoIP
message
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2184
to look at the new patch set (#3).
gsm0808: Add create functions for BSS_MAP_MSG_ASSIGMENT_RQST
gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_ASSIGMENT_RQST messages.
These
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2183
to look at the new patch set (#3).
gsm0808: Add create functions for BSS_MAP_MSG_PAGING
gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_PAGING messages. These
messages are
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2180
to look at the new patch set (#3).
gsm0808: Add utils for Encryption Information
The planned support for true A over IP requires the encoding of
the an Encryption Information element
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2182
to look at the new patch set (#3).
gsm0808: Add create functions for CIPHER MODE COMMAND
gsm0808.h/c lacks functionality to generate CIPHER MODE COMMAND messages. These
messages are
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2181
to look at the new patch set (#3).
gsm0808: Add utils for Cell Identifier List
The planned support for true A over IP requires the encoding of
the a Cell Identifier List element (see
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c95e37cc449297389bf31dd9d5dcaa922d75d0c
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2183
to look at the new patch set (#4).
gsm0808: Add create functions for BSS_MAP_MSG_PAGING
gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_PAGING messages. These
messages are
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2184
to look at the new patch set (#4).
gsm0808: Add create functions for BSS_MAP_MSG_ASSIGMENT_RQST
gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_ASSIGMENT_RQST messages.
These
Patch Set 3: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/2178/3/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:
Line 55: (uint8_t *) & lai_ci);
we normally don't mix cosmetic and non-cosmetic changes in a single patch.
This one has already three cosmetic changes.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2219
to look at the new patch set (#4).
Add example program how to use M3UA+SCCP client and server
This is an example tool that can be run either as server (SG) or as
client (ASP) with a
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2220
to look at the new patch set (#4).
xua: Remove library-internal DXUA log subsystem
We don't really need those thre log messages, and we can thus do away
with the library-internal
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2211
to look at the new patch set (#3).
sua: Extend address parsing with GT, RI and IPv4 support
Change-Id: I186df77cbdbedfe1a60b855be3626b6766f4681c
---
M src/sua.c
1 file changed, 104
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2218
to look at the new patch set (#4).
SUA: Port to new osmo_ss7 and SCCP code
If we use the infrastructure provided by osmo_ss7 on the lower layer and
the SCCP SCRC, SCLC and SCOC code on
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2210
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I966103f30b9be247ba6905ba8e06b87654d9981a
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2211
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I186df77cbdbedfe1a60b855be3626b6766f4681c
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2223
gb.adoc: Add info to NS-over-UDP example
Change-Id: I5b6d2fb284336614da28e0d1b01c7e8c26725f81
---
M common/chapters/gb.adoc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2165
to look at the new patch set (#9).
Add SW Description (de)marshalling
* data structure representing 3GPP TS 52.021 §9.4.62 SW Description
* function to serialize it into
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2177
to look at the new patch set (#4).
gsm0808: Add utils for Speech Codec List and Speech Codec
The planned support for true A over IP requires the encoding and
decoding of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2179
to look at the new patch set (#4).
gsm0808: Add utils for Channel Type
The planned support for true A over IP requires the encoding of
the a Channel Type element (see also ASSIGNMENT
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2166
to look at the new patch set (#4).
Use libosmocore for SW Description parsing
Requires libosmocore with Ib63b6b5e83b8914864fc7edd789f8958cdc993cd.
Change-Id:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2165
to look at the new patch set (#10).
Add SW Description (de)marshalling
* data structure representing 3GPP TS 52.021 §9.4.62 SW Description
* function to serialize it
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2223/1/common/chapters/gb.adoc
File common/chapters/gb.adoc:
Line 24: incoming connections from PCUs on the specified address and port.
I doubt that we really support multiple PCUs ATM so I think it's better to use
singular in here.
--
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2165
to look at the new patch set (#12).
Add SW Description (de)marshalling
* data structure representing 3GPP TS 52.021 §9.4.62 SW Description
* function to serialize it
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2166
to look at the new patch set (#5).
Use libosmocore for SW Description parsing
Requires libosmocore with Ib63b6b5e83b8914864fc7edd789f8958cdc993cd.
Change-Id:
Review at https://gerrit.osmocom.org/2225
Name systemd service after the software
Binary name was changed from sysmopcu to osmo-pcu but the service file
remained with the old name, which is confusing for newcomers.
Added an alias to the service file for users used to the old naming.
Review at https://gerrit.osmocom.org/2226
python: fix Null logger
Change-Id: Ie120273eabbc670e9f19ba365508688a810a2773
Related: SYS#3028
---
M openbsc/contrib/twisted_ipa.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc
python: fix Null logger
Change-Id: Ie120273eabbc670e9f19ba365508688a810a2773
Related: SYS#3028
---
M openbsc/contrib/twisted_ipa.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/26/2226/2
diff --git
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2161
to look at the new patch set (#6).
gsm_bts: add version and variant details
* add version string to gsm_bts
* add PCU version string to gsm_bts
* rename
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2224
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7fa4a1868ee04ee043efd61aa55ee0c4001f12b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2227
abis: log known ACKs and unknown messages
Log expected ACK messages and unhandled messages to aid in
troubleshooting.
Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45
Related: OS#1614
---
M openbsc/src/libbsc/abis_nm.c
1 file changed, 13
58 matches
Mail list logo
