Neels Hofmeyr has submitted this change and it was merged.
Change subject: Fix stow-enabled jenkins build failure
..
Fix stow-enabled jenkins build failure
The error is:
CC gtp-kernel.o
gtp-kernel.c:19:26: fatal error:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5828
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a24076778ea3ce263ac27211a6f45f935155b33
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 9: Code-Review-1
looks good, except I still insist on sane configure option semantics as
described in earlier comment.
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/5833
Remove 11-bit RACH support from 'Known Limitations'
Support for 11-bit RACH support was added to libosmocore with
https://gerrit.osmocom.org/#/c/5062
Change-Id: I091f4fbd52c29c7d56ca392b8a1b872609829d81
---
M README.md
1 file changed, 0 insertions(+),
Patch Set 1:
Curious, have you tested that it actually works?
--
To view, visit https://gerrit.osmocom.org/5833
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I091f4fbd52c29c7d56ca392b8a1b872609829d81
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 1:
> Curious, have you tested that it actually works?
The reason why the build is failing at the moment is that
https://gerrit.osmocom.org/#/c/5818/ is not yet merged.
--
To view, visit https://gerrit.osmocom.org/5833
To unsubscribe, visit https://gerrit.osmocom.org/settings
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests
with ARM instruction set
..
contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: jobs: osmo-trx: Set slave_axis to use only debian9
..
jobs: osmo-trx: Set slave_axis to use only debian9
Debian 8 contains quite old qemu and proot
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5798
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24665880fff5a5b918bb6ffaf1e7bb51ae860b0b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5817
tests: convolve: Disable due to difference in output in different archs
Let's disable this test in order to have passing jenkins jobs until we
find a better way to properly test this for different architectures.
Change-Id:
Review at https://gerrit.osmocom.org/5818
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from ../../include/osmo-bts/gsm_data.h:136:0,
from ../../include/osmo-bts/bts.h:4,
from misc_test.c:23:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5816
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cb06de160830d2f8ee5718246c0fe311f68d49
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5815/1//COMMIT_MSG
Commit Message:
Line 17: log_set_print_extended_timestamp(). Passing 1 still produces the
unseparated
please introduce some meaningful enum in addition to the magic numbers
--
To view, visit
Patch Set 1: Code-Review-1
I don't think to disable it is a good idea. Why not improve it? I think Thomas
Tsou and/or Vadim had suggestions how to do that.
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review-1
I think the feature is useful. By the way, the "Weird" format with <> comes
from syslog, AFAIR. However, what I don't like is hiding it in a seemingly
unrelated API that is about logging the file name.
--
To view, visit https://gerrit.osmocom.org/5812
To
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5813/1//COMMIT_MSG
Commit Message:
Line 7: logging: vty: add 'logging print file (0|1|with-cat)' cmd
why does the category related to the file name?
--
To view, visit https://gerrit.osmocom.org/5813
To unsubscribe, visit
Review at https://gerrit.osmocom.org/5819
Remove unneeded libdl dependency
Closes: OS#1929
Change-Id: I0caea2a2a8e6bd07432fd73bae72b42b1ce022cd
---
M CommonLibs/Makefile.am
M Makefile.am
M Transceiver52M/Makefile.am
3 files changed, 5 insertions(+), 5 deletions(-)
git pull
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5819
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0caea2a2a8e6bd07432fd73bae72b42b1ce022cd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5820
Allow specifying sysmocom headers explicitly
The headers for other models are specified explicitly. Add corresponding
option to specify sysmoBTS headers location and use it in jenkins
build. This fixes the issue after moving to stow for jenkins tests.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5806
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59295388564e5d270da32db6e7488755231f8a11
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5807
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: hnbgw_cn: rx ranap: set rc in all cases
..
hnbgw_cn: rx ranap: set rc in all cases
There don't seem to be any evaluations of the rc, nevertheless return
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5811
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84f886ac880e9056a666bbb231ae06cbaaf65f44
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5805
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f508b719b61a389e10cbad1bafad1650634abe
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: hnbgw_hnbap: fix missing return in rx [un]successful outcome
..
hnbgw_hnbap: fix missing return in rx [un]successful outcome
Fixes: CID#57732 CID#57733
Harald Welte has submitted this change and it was merged.
Change subject: hnbgw_rua.c: log: fix integer format for cN_DomainIndicator
..
hnbgw_rua.c: log: fix integer format for cN_DomainIndicator
Fixes: CID#135219
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5808
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f309dc2d3436798e9e76bcc2ebd82403ea538a1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: hnbgw: hnbap: log rx of unsuccessful outcome
..
cosmetic: hnbgw: hnbap: log rx of unsuccessful outcome
HNBAP isn't really that important to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5804
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32c11100c87a59f34d7c1fefd2f0037e5d63f0e0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: hnbgw_rua: fix dereference of unset pointer
..
hnbgw_rua: fix dereference of unset pointer
In the UNITDATA case, there is no map, so a) initialize map
Max has abandoned this change.
Change subject: Allow specifying sysmocom headers explicitly
..
Abandoned
Merged into previous commit.
--
To view, visit https://gerrit.osmocom.org/5820
To unsubscribe, visit
Review at https://gerrit.osmocom.org/5830
Enable optional static builds
The default (for both manual and .deb builds) is to use shared build (as
before) - the static build is entirely optional.
Change-Id: Iabdebefef5c07dd1cd4b94b29ca40c6be0f8adda
---
M configure.ac
1 file changed, 1
Patch Set 1:
I think you should send an e-mail to the mailing list, as not everyone is
reading Gerrit. I've stumbled upon this patch completely accidentally and I
haven't seen any discussions.
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit
Patch Set 1:
I would gladly separate the hex category out to its own logging config api, the
only reason why I'm continuing to tie it with the filename is backwards compat.
If you agree that we completely untie it from the filename (and that changing
the logging API behavior is acceptable)
Review at https://gerrit.osmocom.org/5824
fix build: missing LIBGTP_CFLAGS in sgsn_test
Change-Id: I250cadecaf90238df1afa6997e5d165fb9eee8b6
---
M tests/sgsn/Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/24/5824/1
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5796
to look at the new patch set (#7).
Allow specifying sysmocom headers explicitly
The headers for LC1.5 are specified explicitly. Add corresponding option
to specify
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#5).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Stefan Sperling has submitted this change and it was merged.
Change subject: Move BTS selection for paging from osmo_bsc_grace.c into
osmo_bsc_bssap.c.
..
Move BTS selection for paging from osmo_bsc_grace.c into
Stefan Sperling has submitted this change and it was merged.
Change subject: Show the BTS number for outgoing paging commands in debug log.
..
Show the BTS number for outgoing paging commands in debug log.
Change-Id:
Review at https://gerrit.osmocom.org/5825
fix jenkins build: add contrib/jenkins.sh expected by jobs
Change-Id: I1ef4b9ce3080ce9cad9ed92ead01619b0d6f91f4
---
A contrib/jenkins.sh
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/asn1c
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5802
to look at the new patch set (#3).
handover_decision: log HO causes more accurately
Tweaked-by: nhofm...@sysmocom.de
Change-Id: Ib0a0787ac8b877ac63455d72886389b546e7a337
Patch Set 1:
@alexander: On top of sending the mail to the ml, I already assigned a task to
Tsou a few days ago too (https://osmocom.org/issues/2826). I think that counts
as pinging specifically.
@max: I can prefix it with FIXME but anyway it's quite visible since everytime
you run the tests
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#9).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Patch Set 1: Code-Review+1 Verified+1
--
To view, visit https://gerrit.osmocom.org/5827
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b54bfa5ef1d89092f6cf13dc27de10874b31b18
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch:
Patch Set 1:
Note: we have to set V+1 manually because this is incomplete fix split off from
5818 as requested.
--
To view, visit https://gerrit.osmocom.org/5827
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 7: Code-Review+1 Verified+1
Even more peculiar - sometimes it fails in one, sometimes in another fw
version. Seems like this has nothing to do with the code, but some kind of race
condition. I think we can safely merge this and figure out fix for unrelated
issue in a separate patch.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix build: missing LIBOSMORANAP flags in libmsc
..
fix build: missing LIBOSMORANAP flags in libmsc
Change-Id: I2f498a2d008571d3eb8753bede0847fa7ab704ed
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix build: missing LIBGTP_CFLAGS in sgsn_test
..
fix build: missing LIBGTP_CFLAGS in sgsn_test
Change-Id: I250cadecaf90238df1afa6997e5d165fb9eee8b6
---
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5823
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f498a2d008571d3eb8753bede0847fa7ab704ed
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5824
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I250cadecaf90238df1afa6997e5d165fb9eee8b6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Stefan Sperling has submitted this change and it was merged.
Change subject: Improve an error message in db_init().
..
Improve an error message in db_init().
If we cannot open a connection to the sqlite3 database, show the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#6).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#7).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Patch Set 7:
The remaining issue with vty check puzzles me: unable to reproduce it locally
and it somehow only happens with single fw version although vty commands are
generic ones.
--
To view, visit https://gerrit.osmocom.org/5796
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 7:
> agree but how do you plan to merge it? - all the parts are
> necessary to unbreak jenkins tests.
we can always remove the "V-1" and give it a V+1 manually.
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/5826
Split paging cases in bssmap_handle_paging() off into helper functions.
This is mostly no-op code refactoring which makes it easier to maintain the
code for each paging case and reduces the scope of several local variables.
Also, ensure that paging
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#8).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Patch Set 7:
Ok, than I'll first make it work with jenkins as a single patch and than
resubmit splitted version.
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/5827
Move sysmobts-calib into osmo-bts-sysmo
It's prerequisite for jenkins tests fix after migration to stow. The
sysmobts-calib uses hand-coded Makefile instead of automake which makes
it hard to properly propagate build flags. Also, make it optional to
Review at https://gerrit.osmocom.org/5831
fsm: fix double llist_del in osmo_fsm_inst_term()
llist_del(>proc.child) is executed always, regardless whether
a parent is configured or not. This may lead into a double llist_del
when the child has been previously unlinked.
- check if
Review at https://gerrit.osmocom.org/5832
fsm: add function osmo_fsm_inst_set_parent()
At the moment it is not possible to unlink a child from from
its parent, nor is it possible to assign a new parent to a
child FSM.
- Make it possible to unlink childs from a parent.
- Make it possible to
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5758
to look at the new patch set (#2).
Add GTP message names
Change-Id: I65eb80db4bcdc6da4d267bef3b907d3f98942a2e
---
M gtp/gtp.c
M gtp/gtp.h
2 files changed, 51
Review at https://gerrit.osmocom.org/5829
Log lapd_datalink state on errors
It's not very useful to get just the raw pointer address in case of
lapd_datalink receive error. Log it's state in addition.
Change-Id: Ie8c5df262312f886f509113f2707e36811df3bd5
---
M src/gsm/lapd_core.c
1 file
Patch Set 1:
Resubmission of https://gerrit.osmocom.org/#/c/5749/ due to following error:
remote: Processing changes: refs: 1, done
To ssh://gerrit.osmocom.org:29418/libosmocore
! [remote rejected] HEAD -> refs/publish/master/log (commit already exists
(in the change))
error:
Review at https://gerrit.osmocom.org/5828
Fix stow-enabled jenkins build failure
The error is:
CC gtp-kernel.o
gtp-kernel.c:19:26: fatal error: libgtpnl/gtp.h: No such file or directory
#include
^
compilation terminated.
Fix it by using proper CFLAGS/LIBS for
Max has abandoned this change.
Change subject: Log lapd_datalink state on errors
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/5749
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1: Code-Review+1
Thanks for splitting this off into another patch.
I'm not sure we should move the code around though. I was about to argue how
src/ should be for the osmo-bts variants, with common/ and the various hardware
platforms; but I see that there already is the sysmobts_mgr
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Review at https://gerrit.osmocom.org/5839
gsm0480: parse all SS info elements in a message
Change-Id: I20cc59c25fdbda176bcf76437174cda829518d60
---
M src/gsm/gsm0480.c
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/5839/1
Review at https://gerrit.osmocom.org/5835
gsm0480: pass exact GSM 04.80 payload length to parse_ss()
Change-Id: I9608d4ad16d7581320615c140beaac36628c31a4
---
M src/gsm/gsm0480.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/5834
gsm0480: add specification reference to SS message type
Change-Id: Iff0210e995053e270939a774db33f55b22545204
---
M src/gsm/gsm0480.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/5837
gsm0480: refactor gsm0480_decode_ss_request
Change-Id: Iba734db97ab516f8fce816c4e4225b97b93619f1
---
M src/gsm/gsm0480.c
1 file changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/5837/1
Review at https://gerrit.osmocom.org/5838
gsm0480: correct parse_ss_info_elements() declaration
Change-Id: I64df293188908c7eb10a61941db76656340d3a8e
---
M src/gsm/gsm0480.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/5840
gsm0480: parse optional IEs for RELEASE COMPLETE message
According to GSM 04.80 section 2.5 "Release complete", a message
of the mentioned type may contain optional IEs, such as Cause
and Facility. Let's parse them.
Change-Id:
Review at https://gerrit.osmocom.org/5836
gsm0480: move SS request length check to parse_ss()
Change-Id: I8e7ce5bd97f3a8731924264c92afb9a7183937dc
---
M src/gsm/gsm0480.c
1 file changed, 11 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#3).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5821
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2539f5dc7a512a57ad36c460a11195ccbd84d7d6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#4).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5796
to look at the new patch set (#6).
Allow specifying sysmocom headers explicitly
The headers for LC1.5 are specified explicitly. Add corresponding option
to specify
Review at https://gerrit.osmocom.org/5823
fix build: missing LIBOSMORANAP flags in libmsc
Change-Id: I2f498a2d008571d3eb8753bede0847fa7ab704ed
---
M src/libmsc/Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/23/5823/1
Patch Set 1:
> it is even inside the commit in testsuite.at
Might make sense to prefix it with FIXME so it'll jump out when grepping the
sources.
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5822
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37bc517a30d00c744eddc8565a0a8181cb3b2cdb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/5802/2/src/libbsc/handover_decision.c
File src/libbsc/handover_decision.c:
Line 282: LOGPC(DHO, LOGL_INFO, "HO cause: Interference HO
av_rxlev=%d dbm\n",
"dBm" with uppercase B. Please fix, thanks!
--
To
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5825
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef4b9ce3080ce9cad9ed92ead01619b0d6f91f4
Gerrit-PatchSet: 1
Gerrit-Project: asn1c
Gerrit-Branch: master
Patch Set 7:
> would be nice to split this patch
agree but how do you plan to merge it? - all the parts are necessary to unbreak
jenkins tests.
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5801
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7f54a4cb179eaa9e5eb147b9477633ac618e69e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5825
to look at the new patch set (#2).
fix jenkins build: add contrib/jenkins.sh expected by jobs
Change-Id: I1ef4b9ce3080ce9cad9ed92ead01619b0d6f91f4
---
A
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix jenkins build: add contrib/jenkins.sh expected by jobs
..
fix jenkins build: add contrib/jenkins.sh expected by jobs
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5825
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef4b9ce3080ce9cad9ed92ead01619b0d6f91f4
Gerrit-PatchSet: 2
Gerrit-Project: asn1c
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix build: db_test: missing LIBOSMOABIS_CFLAGS and _LIBS
..
fix build: db_test: missing LIBOSMOABIS_CFLAGS and _LIBS
Change-Id:
Review at https://gerrit.osmocom.org/5822
jenkins_common.sh: fix build_bts distcheck for more than one conf_flag
Passing configure flags in DISTCHECK_CONFIGURE_FLAGS requires enclosing all
flags in quotes. Currently we seem to have no callers with more than one
configure flag, so we were lucky
Stefan Sperling has submitted this change and it was merged.
Change subject: Implement support for paging based on a Cell Global Identifier.
..
Implement support for paging based on a Cell Global Identifier.
This is
Stefan Sperling has submitted this change and it was merged.
Change subject: Implement support for paging based on LAC and CI.
..
Implement support for paging based on LAC and CI.
This is a simple combination of the LAC and CI
Patch Set 7: Code-Review-1
(2 comments)
would be nice to split this patch
https://gerrit.osmocom.org/#/c/5818/5/configure.ac
File configure.ac:
Line 62: AC_MSG_RESULT([$enable_sysmobts_calib])
With this patch it seems that this alone does not work:
./configure --with-sysmobts=foo
and that
94 matches
Mail list logo
