Patch Set 9:
Because of
https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html
In short CPPFLAGS are flags for preprocessor and is the right place to add
things like include directories. See also implementation for other BTS models.
The CFLAGS (and corresponding
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ea8bad8b410550f72ee6a0408f42f6bd8b6cac
Gerrit-PatchSet: 11
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5870
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0416a9f4c428189cd9c3909c8bd016ca2908128a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5868
Add note on vty logging
Change-Id: I2bb52feb37622d0ef35f6be172759adc3813f008
---
M common/chapters/logging.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/68/5868/1
diff
Review at https://gerrit.osmocom.org/5869
mobile: Print an error message if the VTY cannot be initialized
If we fail to initialize the VTY, print an error mesage instead of
failing silently. For example:
"Cannot init VTY on 127.0.0.1 port 4247: Address already in use"
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5870
to look at the new patch set (#2).
Allow specifying sysmocom headers explicitly
The headers for LC1.5 are specified explicitly. Add corresponding option
to specify sysmoBTS headers
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5869
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24161f53fa621ae1c8b1916bd0c8055c494b531e
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5865
Document workaround for gsmtap logging
Document a way to minimize logging to stderr when gsmtap is used as a
log target.
Change-Id: I8e64a0075b5a4bad3f83660e0668e6de45b21008
---
M common/chapters/logging.adoc
1 file changed, 8 insertions(+), 1
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5870/2/configure.ac
File configure.ac:
Line 77:CPPFLAGS="$CPPFLAGS -I$SYSMOBTS_INCDIR -I$srcdir/include"
Is there a need to set CPPFLAGS here if you are passing SYSMOBTS_INCIDR to
AM_CPPFLAGS in Makefile.am later?
--
To view,
Patch Set 2: -Code-Review
(1 comment)
https://gerrit.osmocom.org/#/c/5424/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:
Line 328: msg->l3h = msgb_put(msg, TLVP_LEN(,
GSM0808_IE_LAYER_3_INFORMATION));
> The point here is that the MSC side is the "trusted core network" and
Patch Set 9: Code-Review-1
(6 comments)
I think it's good having 2 separate options (enable-sysmobts, with-sysmobts),
but it may be a good idea having a more explicit name like
--with-sysmobts-headers or alike.
Please fix the CPPFLAGS->CFLAGS stuff or explain why is it done like this.
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1538
to look at the new patch set (#3).
Extend Kc buffer
Double the Kc buffer to match the requirements of A5/4 and GEA4.
Related: OS#1910
Change-Id:
Review at https://gerrit.osmocom.org/5871
Embedded: disable stats test
As of 67bdd80a96bdfc49d1aadbd32cca2b53f123d180 the stats.c is
effectively disable so we should disable the corresponding tests as
well.
Change-Id: I42ff7a6619c0a5926fdc2ec779cf04689c567e15
---
M configure.ac
M
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5818
to look at the new patch set (#10).
Fix test dependencies
The stow-enabled jenkins builds are currently failing like below:
In file included from
Patch Set 1:
Split to simplify the review. It's expected to fail because the fix is
incomplete without the follow-up patch.
--
To view, visit https://gerrit.osmocom.org/5870
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 11:
(1 comment)
https://gerrit.osmocom.org/#/c/5818/11/tests/sysmobts/Makefile.am
File tests/sysmobts/Makefile.am:
Line 1: AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-I$(top_srcdir)/src/osmo-bts-sysmo -I$(SYSMOBTS_INCDIR)
Relaed to previous patch: Why do we set CPPFLAGS
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/5870/2/configure.ac
File configure.ac:
Line 77:CPPFLAGS="$CPPFLAGS -I$SYSMOBTS_INCDIR -I$srcdir/include"
> Is there a need to set CPPFLAGS here if you are passing SYSMOBTS_INCIDR to
Those are only effective for the duration of
Review at https://gerrit.osmocom.org/5873
Embedded: add sercomm stubs
The sercomm functions are unavailable in case of embedded build. Add
stub and link the tests against it.
Change-Id: I9bc5cb2f822b1a3ffdc6ec29f46b6bac8288314e
---
M .gitignore
M configure.ac
M tests/Makefile.am
A
Review at https://gerrit.osmocom.org/5881
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add an FSM that permits comfortable handling of an MGCP
connection.
Change-Id:
Review at https://gerrit.osmocom.org/5878
mgcp: make domain name configurable
At the moment the MGW has a fixed domain name string that is not even
checked properly.
- Make domain name configurable, use the current "mgw" string as
defualt to maintain compatibility
- Check the domain name
Review at https://gerrit.osmocom.org/5880
mgcp: add prefix to virtual trunk
the virtual trunk is addressed without a prefix (just *@domain).
- reorganize find_endpoint() so that it accepts a prefix when
addressing the virtual trunk.
- do no longer accept wildcarded CRCX requests without
Patch Set 1: Code-Review+1
(1 comment)
I think there are still some issues in the code, but this does fix the issue
I'm seeing. Thanks
https://gerrit.osmocom.org/#/c/5867/1/src/libosmo-mgcp-client/mgcp_client.c
File src/libosmo-mgcp-client/mgcp_client.c:
PS1, Line 317:
Review at https://gerrit.osmocom.org/5874
jenkins: move make invocation into shared function
Change-Id: Ied8c1085b8bee2cc4fa65592e805838b8cdae287
---
M contrib/jenkins-arm.sh
M contrib/jenkins.sh
M contrib/jenkins_common.sh
3 files changed, 8 insertions(+), 5 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5879
mgcp: permit wildcarded endpoint assignment (CRCX)
The mgcp protocol in general allows wildcarded endpoints on CRCX.
osmo-mgw does not support this feature yet.
- when the endpoint name contains a wildcard character, search
a free endpoint
- return
Review at https://gerrit.osmocom.org/5877
client/common: move constant MGCP_ENDPOINT_MAXLEN
MGCP_ENDPOINT_MAXLEN is currently only defined for the mgcp client,
since this is in general a common parameter it should be moved to
mgcp_common.h so that both sides can use it.
Change-Id:
Review at https://gerrit.osmocom.org/5876
mgcp: allow endpoints beginning from zero
there is a now obsolete constraint that endpoint numbers must
start at 1.
- remove the check to allow also endpoints starting at 0
Change-Id: Iec2f4e36e1ab01ff23875d99e4b0e04af7c1ad98
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5873
to look at the new patch set (#2).
Embedded: add sercomm stubs
The sercomm functions are unavailable in case of embedded build. Add
stub and link the tests against it.
Change-Id:
Patch Set 1:
(1 comment)
> (1 comment)
>
> I think there are still some issues in the code, but this does fix
> the issue I'm seeing. Thanks
https://gerrit.osmocom.org/#/c/5867/1/src/libosmo-mgcp-client/mgcp_client.c
File src/libosmo-mgcp-client/mgcp_client.c:
PS1, Line 317:
Review at https://gerrit.osmocom.org/5875
Store/retrieve SMS validity time in the SMS datebase
Compute a validity timestamp based on SMS validity time.
Store the computed value in the database and recompute the validity
time when an SMS is read from the database.
Change-Id:
Review at https://gerrit.osmocom.org/5884
jenkins: add dispatcher script
Similar to the way we test osmo-bts, add simple dispatcher script which
calls appropriate test depending on a given parameter. This will allow
to simplify the job description. While at it, also rename jenkins-arm.sh
->
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5884
to look at the new patch set (#2).
jenkins: add dispatcher script
Similar to the way we test osmo-bts, add simple dispatcher script which
calls appropriate test depending on a given
Patch Set 2:
A common way to handle this type of situation is to add -I$(PATH) to CPPFLAGS
if PATH is set, else don't add anything.
--
To view, visit https://gerrit.osmocom.org/5870
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2:
> Otherwise yoy may end up with "-I" only in Makefile.am
No, we may not. The SYSMOBTS_INCDIR is only used in targets which are enabled
iff sysmobts support is enabled.
--
To view, visit https://gerrit.osmocom.org/5870
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 2:
> '--with-sysmobts-includes=' or '--with-sysmobts-headers=' would be a better
> name for this option
Perhaps, but I'd rather keep it similar to the other such options for different
BTS models. If we'd like to rename it, we should do it for all models at once
and in a separate
Patch Set 1: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/5878/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:
Line 1217: len = snprintf(buf, sizeof(buf),
snprintf() could return -1 here if the expanded string does not fit into buf.
Line 1220:
Review at https://gerrit.osmocom.org/5886
jenkins: remove obsolete scripts
* jenkins.sh is superseded by jenkins_amd64.sh
* jenkins-arm.sh is superseded by jenkins_arm.sh
N. B: this requires I76dfc11a05007ae5c6e0554fe8132695b67cccaa in
osmo-ci.
Change-Id:
Review at https://gerrit.osmocom.org/5882
Delete SMS from the database once they were sent successfully
Currently the SMS database keeps accumulating entries for each SMS.
These entries are never deleted automatically. With this change, we
start deleting SMS which have successfully been sent
Review at https://gerrit.osmocom.org/5883
hnbap: log errors on decoding/encoding HNB-REGISTER msgs
Change-Id: I3c039267fa2cc047c5678bcfe4a603f70c21cdd1
---
M src/hnbgw_hnbap.c
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh
Patch Set 2:
> > Otherwise yoy may end up with "-I" only in Makefile.am
>
> No, we may not. The SYSMOBTS_INCDIR is only used in targets which
> are enabled iff sysmobts support is enabled.
even if sysmobts support is enavbled, I may want to build with
--enable-sysmobts and without
Patch Set 2: Code-Review-1
Makes sense to leave it empty to get them from standard include directories.
However, that makes me think we should move the -I inside the SYSMOBTS_INCDIR
variable. Otherwise yoy may end up with "-I" only in Makefile.am
--
To view, visit
Review at https://gerrit.osmocom.org/5887
libosmocoding: use frame length definitions from codec.h
Since commit e094157e125a70b9a384ba3cec01261624f4eb59, TCH frame
length definitions were added to libosmocodec.
No need to define them again.
Change-Id: Id8c6132534e36ea1e368432bb259fd4f3a531f90
Review at https://gerrit.osmocom.org/5888
libosmocoding: fix typo in library documentation
Change-Id: I535d4eba5bad9094a1e9e662f32cd2bfac5b0cef
---
M src/coding/gsm0503_coding.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Patch Set 9:
I can split it further into 2 separate patches: one fixing cflags and another
adding cppflags if it helps to clarify this confusion. What do you think?
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Review at https://gerrit.osmocom.org/5866
Clarify app-specific log filters
Change-Id: I53e8aed658774781a70fea0b46cafc55496925eb
---
M common/chapters/logging.adoc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/66/5866/1
Review at https://gerrit.osmocom.org/5867
client: do not insist on \n\n when parsing MGCP messages
The current implementation of mgcp_client.c requires MGCP
paragraphs to be separated wit a \n\n sequence. However,
when the client is used with servers other than osmo-mgcp,
the parapgraph may be
Review at https://gerrit.osmocom.org/5870
Allow specifying sysmocom headers explicitly
The headers for LC1.5 are specified explicitly. Add corresponding option
to specify sysmoBTS headers location and use it in jenkins build.
This is prerequisite for fixing the build issue revealed by
Vadim Yanitskiy has abandoned this change.
Change subject: gsm0480: expose the gsm0480_parse_ss_facility_ie()
..
Abandoned
Change is not required anymore.
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe,
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5860
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I113645bd6df1ec9ae5137977028df38560fc4789
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5921
to look at the new patch set (#3).
HO: Implement load based handover, as handover_decision_2.c
Change-Id: Ice2d3ef5668564a9d3bc4d5118d59dfaa9af6978
---
M configure.ac
M
Review at https://gerrit.osmocom.org/5924
jobs: master: also trigger once per day
Recently we had changes to osmo-ci, and I noticed that although some master
builds were broken by that, the builds were still showing success -- of twenty
days ago.
Run each master build at least once a day to
Review at https://gerrit.osmocom.org/5892
HO prep: introduce per-BTS handover config, with defaults on net node
It is desirable to allow configuring handover for each individual network cell.
At the same time, it is desirable to set global defaults.
Treat the 'network' node handover
Review at https://gerrit.osmocom.org/5891
HO: fix recovery from failed handover
Do not instruct the MGW to move the RTP to the new lchan before we have
received a HANDOVER DETECT.
Before:
Chan Activ
Chan Activ Ack
IPACC-CRCX
-ACK
IPACC-MDCX
-ACK
MGCP MDCX --> MGW
...
Review at https://gerrit.osmocom.org/5894
HO: add indicators for inter-cell and async ho, use for chan act type
Change-Id: I2d91765c1f9719c64fd99426a872cecc724215db
---
M src/libbsc/handover_logic.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5889
vty: add various manual handover and assignment trigger commands
Change-Id: I9745609f2620baa09a693b713d76e355e798abc7
---
M src/libbsc/bsc_vty.c
1 file changed, 192 insertions(+), 25 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/5899
Fix of checking TCH rate at chan_compat_with_mode
In case of current channel equals TCH/F and we request half rate, we
must return 0, so the calling function will trigger assignment.
Change-Id: Ibb4cb9aef1a1146f984d7c969bfba53c647cae07
---
M
Review at https://gerrit.osmocom.org/5904
HO: Changed availablilty of ts_is_usable() from static to extern
Change-Id: I3471e38327c4b98490faed9b604fb76438ba9954
---
M include/osmocom/bsc/chan_alloc.h
M src/libbsc/chan_alloc.c
2 files changed, 2 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5890
osmo_bsc_mgcp: cosmetic: introduce mgcp_init(), soak up fsm init
A subsequent patch will add registration of a signal; cosmetically prepare by
creating a common mgcp_init() function. It makes sense for the FSM registration
to move to it.
Change-Id:
Review at https://gerrit.osmocom.org/5893
HO: Send Channel Mode and Multirate IE along with handover command
This is needed, if the channel mode should change when doing handover.
A change in channel mode makes sense, if available resources at the new
BTS are different.
Change-Id:
Review at https://gerrit.osmocom.org/5897
Fix: If paging for half rate was requested, use hr, if supported by MS
Change-Id: I6d1c9701808ee542771fee145250927019a2f5f6
---
M src/libbsc/gsm_04_08_utils.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5896
cosmetic: explicitly init ho_ref start value
The static ho_ref seems to be implicitly initialized to zero, but let's make it
explicit for code readability.
Change-Id: I00493bcb7ef3e38fb8e0077c60c5bac7199f1073
---
M src/libbsc/handover_logic.c
1 file
Review at https://gerrit.osmocom.org/5902
fixup: neigh_meas_avg: detect invalid window size as <=0, log if invalid
Change-Id: I8c5d0642aeb4fbee73a035b9f73cf3a09b1bcf90
---
M src/libbsc/handover_decision.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5895
HO: Add function to count currently ongoing handovers to a given BTS
In order to keep processing power at BTS at a defined level, the handover
decision might want to limit maximum number of slots that require RACH
detection.
Change-Id:
Review at https://gerrit.osmocom.org/5906
HO: If handover logic is used to do assignment, signal assignment result
Change-Id: I465caef03626e67d9b3a21bdf730589b9852c211
---
M include/osmocom/bsc/signal.h
M src/libbsc/bsc_api.c
2 files changed, 31 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5921
HO: Implement load based handover, as handover_decision_2.c
Change-Id: Ice2d3ef5668564a9d3bc4d5118d59dfaa9af6978
---
M configure.ac
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/gsm_data_shared.h
M
Review at https://gerrit.osmocom.org/5920
HO: Add a penalty timer list to the subscriber connection entity
This penalty timer is used to temporarily block cells where handover
or assignment failed or where handover is not allowed. This is usefull
to prevent repeated handover attempts to broken
Review at https://gerrit.osmocom.org/5919
HO: add queue to cache DTAP messages during handover/assignment
Add ho_dtap_cache to gsm_subscriber_connection, a stock msgb queue to be used
with msgb_enqueue() and msgb_dequeue().
Keep a counter of queue length, to enforce a sane maximum counter for
Review at https://gerrit.osmocom.org/5917
HO: rename gsm_bts_neighbor() to bts_by_arfcn_bsic()
The name sounds like it is looking up neighbors, instead it simply traverses
the global list of BTSes. Rename to reflect what it does.
Move FIXME comment to its logical place: at the invocation of
Review at https://gerrit.osmocom.org/5922
HO: always use Handover Command, not Assignment
Change-Id: I5c1ec8c228a557ac59a31ea47e21fb856467742e
---
M src/libbsc/handover_logic.c
1 file changed, 4 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/5923
Fix: meas_rep.c will only use valid DL measurement reports
When averaging measurements, only the valid reports are used. If there is
no valid report in the averaging window at all, an error is returned.
Change-Id:
Review at https://gerrit.osmocom.org/5914
HO: add handover algo 2 configuration parameters
Change-Id: I8811ee8a75be09048042b511ee4bd9bc1de63976
---
M include/osmocom/bsc/handover_cfg.h
M tests/handover_cfg.vty
2 files changed, 361 insertions(+), 13 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5908
Do not perform assignment, if the new channel equals the current one
This can happen, if a TCH/H was requested, but because it is not available,
a TCH/F is allocated. If the old channel was TCH/F already, it makes no
sense to assign it.
Change-Id:
Review at https://gerrit.osmocom.org/5913
HO: add algorithm cfg; skip HO 1 if HO 2 is configured
Change-Id: If07c0a7b84937ab92948e9b71b2496a765946020
---
M include/osmocom/bsc/handover_cfg.h
M src/libbsc/handover_decision.c
2 files changed, 13 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5909
Allow assignment to TCH channel with signalling only mode
This makes sense, if silent call is used. Assignment allows to change from
SDCCH (or whatever was available) to given TCH rate.
Change-Id: I2efe9d7ab429e902581ebb9e0e006f2aec6d8972
---
M
Review at https://gerrit.osmocom.org/5907
HO: Add handover decision debugging category
Change-Id: Iaf99d4e9ae08c38bf364dbb37d42098f976f6b8c
---
M include/osmocom/bsc/debug.h
M src/libcommon/debug.c
2 files changed, 9 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5912
HO: enable handover by initializing at startup; rename init function
Change-Id: I224884c84895ebf6c8cf498c16616214cb2b5779
---
M include/osmocom/bsc/handover_decision.h
M src/libbsc/handover_decision.c
M src/osmo-bsc/osmo_bsc_main.c
3 files changed, 6
Review at https://gerrit.osmocom.org/5916
HO: Count number of free timeslot on a given BTS
This is needed for handover algorithm to balance free slots and to prevent
congestion of one cell, while other cells still have free capacities.
Change-Id: Ic8bee8a515ee8aa9a99af71756fe60b8dd8f868b
---
Review at https://gerrit.osmocom.org/5903
fixup: neigh_meas_avg: fix condition to reduce window size
Change-Id: Ia2269be448436d676289c84b9b05da7f51ee4a85
---
M src/libbsc/handover_decision.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/5918
HO: make bts_by_arfcn_bsic() public
Change-Id: Ie746f76433f6b46a71a91b7714cc034c4355d993
---
M include/osmocom/bsc/handover_decision.h
M src/libbsc/handover_decision.c
2 files changed, 4 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5915
HO: Change debug category at handover decision: DHO -> DHODEC
Change-Id: I7322b790f647b681bfe3a9c95b04516fbc7cbf88
---
M src/libbsc/handover_decision.c
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/5910
Correctly set T3105 for ipaccess BTS type
The given value is 10 * ms, so 13 is used instead of 128.
If T3105 is set at config to something greater 0, it is used instead of
the default value.
Adjusst nanobts_omlattr_test.c accordingly.
Change-Id:
Review at https://gerrit.osmocom.org/5905
HO: Always update rqd_ta after receiving measurement report
The up-to-date rqd_ta is required for assignment command. If the phone
moves, the timing advance might change. The rqd_ta will be updated by
each measurement report.
Change-Id:
Neels Hofmeyr has abandoned this change.
Change subject: HO: add algorithm cfg; skip HO 1 if HO 2 is configured
..
Abandoned
squashed into 'add handover algo 2 parameters...'
--
To view, visit https://gerrit.osmocom.org/5913
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5914
to look at the new patch set (#2).
HO: add handover algo 2 parameters; skip HO 1 if HO 2 is configured
Change-Id: I8811ee8a75be09048042b511ee4bd9bc1de63976
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5920
to look at the new patch set (#2).
HO: Add a penalty timer list to the subscriber connection entity
This penalty timer is used to temporarily block cells where handover
or assignment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5919
to look at the new patch set (#2).
HO: add queue to cache DTAP messages during handover/assignment
Add ho_dtap_cache to gsm_subscriber_connection, a stock msgb queue to be used
with
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5916
to look at the new patch set (#2).
HO: Count number of free timeslot on a given BTS
This is needed for handover algorithm to balance free slots and to prevent
congestion of one cell,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5915
to look at the new patch set (#2).
HO: Change debug category at handover decision: DHO -> DHODEC
Change-Id: I7322b790f647b681bfe3a9c95b04516fbc7cbf88
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5918
to look at the new patch set (#2).
HO: make bts_by_arfcn_bsic() public
Change-Id: Ie746f76433f6b46a71a91b7714cc034c4355d993
---
M include/osmocom/bsc/handover_decision.h
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5917
to look at the new patch set (#2).
HO: rename gsm_bts_neighbor() to bts_by_arfcn_bsic()
The name sounds like it is looking up neighbors, instead it simply traverses
the global list of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5921
to look at the new patch set (#2).
HO: Implement load based handover, as handover_decision_2.c
Change-Id: Ice2d3ef5668564a9d3bc4d5118d59dfaa9af6978
---
M configure.ac
M
Review at https://gerrit.osmocom.org/5863
TBF: make UL ack state internal
* add functions/macros for setting TBF's UL ack state
* add functions for checking TBF's UL ack state
* update TBF test output due to extended state transition logging
N. B: this should not be confused with TBF-UL
Review at https://gerrit.osmocom.org/5864
TBF: make poll state internal
* add functions/macros for setting TBF's poll state
* add function for checking TBF's poll state
* update TBF test output due to extended state transition logging
Change-Id: I6db1c4e7bd0a49aeb5e391afe371c36b96c6a702
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5844
to look at the new patch set (#3).
tests: fix LDADD: link libosmovty from current build
Do not link against the system-wide installed libosmovty during build. Instead,
use the
Patch Set 2:
> > could you clarify?
>
> It's documented in
> https://www.gnu.org/software/automake/manual/html_node/Linking.html
> In a nutshell, LDADD applies to all the programs, prog_LDADD
> applies single program. So having only "prog_LDADD = $(LDADD)" is
> confusing and redundant.
Patch Set 2: -Code-Review
> This is the main change of this patch.
Adding yes, string splitting - no. But like I've said, I don't consider it to
be blocker.
> following the pattern present in this file
So this slipped passed review sometime before. Should be fixed as well.
> could you
Review at https://gerrit.osmocom.org/5862
TBF: make UL/DL state internal
* add functions/macros for setting TBF's UL/DL state
* add functions for checking TBF's UL/DL state
* move pre-free check into separate function
* update TBF test output due to extended state transition logging
N. B:
96 matches
Mail list logo
