osmo-hlr[master]: cover all build artifacts in .gitignore

2018-01-28 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6149/1//COMMIT_MSG Commit Message: Line 7: cover all build artifacts in .gitignore This sounds like you've invented a way to ignore *all* build products once and for all... My suggestion is: Add missing build products to .gitignore. --

osmo-bts[master]: rsl: do not allow MODE MODIFY request with unsupp. codec/rate

2018-01-28 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6097/1/src/common/bts.c File src/common/bts.c: Line 693: for (i = 0;; i++) { > This way: (i = 0; i < _GSM_PCHAN_MAX; i++) Oops, I was mistaken. As the size of bts->support.cm array is different for different BTS models, you may use

[MERGED] osmo-bsc[master]: bssmap_handle_assignm_req(): Decode channel type as first step

2018-01-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bssmap_handle_assignm_req(): Decode channel type as first step .. bssmap_handle_assignm_req(): Decode channel type as first step The decision on how to

[MERGED] osmo-bsc[master]: remove obsolete gsm_subscriber_connection.bts member

2018-01-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: remove obsolete gsm_subscriber_connection.bts member .. remove obsolete gsm_subscriber_connection.bts member This member was merely a cache for

osmo-bsc[master]: remove obsolete gsm_subscriber_connection.bts member

2018-01-28 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5511 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3bff8b18425ef5d45eb460ac9eb620023013ba0 Gerrit-PatchSet: 9 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: update.gitignore with 'tags' files and 'deps' directory

2018-01-28 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6148 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b51bbb4dce9757be7f2430b83b7879e24aa0df1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: cosmetic: Remove data/len variables in bssmap_handle_assignm...

2018-01-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: Remove data/len variables in bssmap_handle_assignm_req() .. cosmetic: Remove data/len variables in bssmap_handle_assignm_req() There's

[PATCH] osmo-hlr[master]: cover all build artifacts in .gitignore

2018-01-28 Thread Alexander Huemer
Review at https://gerrit.osmocom.org/6149 cover all build artifacts in .gitignore Change-Id: I48b93adc280c1b0521e7f5acc1f66ce5db462915 --- M .gitignore 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/49/6149/1 diff --git