Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6615
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d26c0b4f36ee3c66ed1a9e2e9fa2fa8272da16d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6614
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2c77c776823f595130edac963be953026049423
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6617
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a851181a99f2f35ea4ff1b38c7afe27a04e5f18
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6616/2//COMMIT_MSG
Commit Message:
Line 9: No code is using it and we always lock to console anyways.
log?
--
To view, visit https://gerrit.osmocom.org/6616
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6613
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8282745ef0282d41599eaf94fe460a1d29b18e2a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6610
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f24fbf453e0a94d7a95c3df7cc75f0e4bd456
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6608
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0231adbd2171214de133d26b3fbf36130ee8aa0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Logger: Remove unused includes
..
Logger: Remove unused includes
Change-Id: I4d26c0b4f36ee3c66ed1a9e2e9fa2fa8272da16d
---
M CommonLibs/Logger.h
1 file
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6627
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d0460cbb633b470f6117d07643f68aefb1530eb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Logger: Drop syslog support
..
Logger: Drop syslog support
This feature is currently not being used, so let's drop it to make it
easier to integrate
Harald Welte has submitted this change and it was merged.
Change subject: Logger: Drop support to log into file
..
Logger: Drop support to log into file
This feature is currently not being used, so let's simplify current code
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6607
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica9cfae5a691e4d967d046b04e5bb16a71a89adf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Logger: Remove unused logging macros
..
Logger: Remove unused logging macros
Change-Id: I1133e181183bec8dabe2fa77d0385f783458503f
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6616
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fde99c6af5a845e635b5d27abab855682071f14
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Logger: get rid of alarm APIs
..
Logger: get rid of alarm APIs
It's only used internally inside the Logger module, and in case there's
an "alarm" (level
Harald Welte has submitted this change and it was merged.
Change subject: Logger: Remove gLogToConsole flag
..
Logger: Remove gLogToConsole flag
No code is using it and we always lock to console anyways.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6626
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ea3855a1f3d1cba6ac173b0f9cf9052d5d028fc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Logger: Drop unused gLogEarly
..
Logger: Drop unused gLogEarly
Change-Id: I2c8f24fbf453e0a94d7a95c3df7cc75f0e4bd456
---
M CommonLibs/Logger.cpp
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6628
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2f6e4cb6a8f3b77e452f36a83ec11e7554e6c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 4:
(4 comments)
https://gerrit.osmocom.org/#/c/6619/4//COMMIT_MSG
Commit Message:
Line 12: Depends on libosmocore Change-Id
Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9
Related: OS#2184
https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c
File CommonLibs/debug.c:
Line 9:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6609
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89c7186f74bde7e6ac5f6e98f0b3e4c35274
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: TBF: make network counters internal
..
TBF: make network counters internal
* store N310* counters in shared array similar to corresponding timers
* add
Review at https://gerrit.osmocom.org/6653
GSM_RR_Types: Add ts_IMM_ASS and ts_MEAS_REP
which allows us to send RR IMMEDIATE ASSIGNMENT (DL/AGCH) and
RR MEASUREMENT REPORT (UL/SACCH) messages from tests.
Change-Id: Ic75041e84c15c77805ecafb823bf7108920675ca
---
M library/GSM_RR_Types.ttcn
1
Review at https://gerrit.osmocom.org/6652
L1CTL: Add optional link_id argument to t_L1CTL_DATA_IND()
Change-Id: Ib4cf42825da1034966086d9232273c2328a94947
---
M library/L1CTL_Types.ttcn
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:
Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
Why not to use a macros here?
#define CHAN_NR_IS_DCHAN(chan) \
(chan & 0x80)
--
To view, visit https://gerrit.osmocom.org/6635
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Pass ASP_IPA_EVENT_UP to RSL_CCHAN port
..
RSL_Emulation: Pass ASP_IPA_EVENT_UP to RSL_CCHAN port
When emulating the BSC side of RSL,
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: also test gsm48_generate_lai() and
gsm48_decode_lai()
..
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai()
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: cosmetically re-order MCC to come before MNC
..
gsm0408_test: cosmetically re-order MCC to come before MNC
For consistency in human
Harald Welte has submitted this change and it was merged.
Change subject: RSL: Properly reject RSL CHAN_NR IE for incompatible PCHAN
..
RSL: Properly reject RSL CHAN_NR IE for incompatible PCHAN
If we receive a message for a
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: include BCD and leading zeros in test output
..
gsm0408_test: include BCD and leading zeros in test output
(Preparation for adding 3-digit
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: RA test: include min/max value cases
..
gsm0408_test: RA test: include min/max value cases
(Preparation for adding 3-digit MNC)
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6662
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6661
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: gsm0408_test: RA test cases as array-of-struct
..
cosmetic: gsm0408_test: RA test cases as array-of-struct
(Preparation for adding 3-digit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6645
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I517ed9edf77fac37d9de7a39df24c419a8a65d96
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: sgsn_test: guard against struct gprs_ra_id changing
..
sgsn_test: guard against struct gprs_ra_id changing
sgsn_test initializes various struct
Patch Set 1:
Back rto all of heels' comments
--
To view, visit https://gerrit.osmocom.org/6602
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd441eb2b6b75dfbe001b49b01bea015ca6e11c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Harald Welte has submitted this change and it was merged.
Change subject: mgcp_client: cosmetic: clean up SDP params parsing
..
mgcp_client: cosmetic: clean up SDP params parsing
The mgcp_response_parse_params() is in a
Harald Welte has submitted this change and it was merged.
Change subject: mgcp_client: detect SDP section-start parsing errors
..
mgcp_client: detect SDP section-start parsing errors
After call to mgcp_find_section_end(),
Harald Welte has submitted this change and it was merged.
Change subject: mgcp_client: show failure by MGCP SDP section parsing test
..
mgcp_client: show failure by MGCP SDP section parsing test
To show how the current code
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6638
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6652
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4cf42825da1034966086d9232273c2328a94947
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6653
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic75041e84c15c77805ecafb823bf7108920675ca
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: L1CTL: Add optional link_id argument to t_L1CTL_DATA_IND()
..
L1CTL: Add optional link_id argument to t_L1CTL_DATA_IND()
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: GSM_RR_Types: Add ts_IMM_ASS and ts_MEAS_REP
..
GSM_RR_Types: Add ts_IMM_ASS and ts_MEAS_REP
which allows us to send RR IMMEDIATE ASSIGNMENT (DL/AGCH)
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6660
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: RSL: Ensure we don't accept DCHAN messages for CCHAN
..
RSL: Ensure we don't accept DCHAN messages for CCHAN
If the Channel Number IE points to a common
Harald Welte has submitted this change and it was merged.
Change subject: octphy: ensure all BTS models set features
..
octphy: ensure all BTS models set features
Most of the BTS models do not or do register not all of thier
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6641
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6d50c6f4e2348b23f31c3415b0f5577a3f5be50
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6631
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6d0c9c729367e00a9ab7fff7c89007d336e59d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: gsm_data_shared: extend bts feature list with speech codecs
..
gsm_data_shared: extend bts feature list with speech codecs
The feature list does not
Harald Welte has submitted this change and it was merged.
Change subject: compiler warning: ignore deprecated in mgcp_client_test.c
..
compiler warning: ignore deprecated in mgcp_client_test.c
mgcp_msg_crcx() causes
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I977dc729ba856631245aedf76afd48eac92166f7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6656
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6655
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6654
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6c645ebf82d5f8d9d51c4c4cc804a0172008156
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6657
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6658
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: IPA_Emulation: Make dependencies to RSL/MGCP/SCCP/GSUP
conditional
..
IPA_Emulation: Make dependencies to RSL/MGCP/SCCP/GSUP conditional
Let's use the
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Types: Add templates for "BSC side"
..
RSL_Types: Add templates for "BSC side"
So far, the RSL templates have been used for BSC testing, i.e.
TTCN3
Review at https://gerrit.osmocom.org/6671
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Depends:
Review at https://gerrit.osmocom.org/6672
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Note that in gbproxy_test.ok, 0-0
Review at https://gerrit.osmocom.org/6670
hnb-test: log accurate three-digit MNC with leading zeros
Depends: Id2240f7f518494c9df6c8bda52c0d5092f90f221 (libosmocore)
Change-Id: Ie3dd206bca2f38a0ef7ee7f9d3b6bf2eacc899a4
---
M src/tests/hnb-test.c
1 file changed, 4 insertions(+), 3 deletions(-)
introduce GSM_MCC_MNC_INVALID
In some cases, we want to mark an unset MCC-MNC. Define uint16-max for this
purpose.
osmo-bsc code is already doing so with a -1 and using int data types, which
will become inconvenient with the new API that handles MCC and MNC as uint16_t.
Change-Id:
Patch Set 1: Code-Review+1
Would be also great to have a minimalistic commit description,
i.e. where do we use gsm48_ra_id and why?
--
To view, visit https://gerrit.osmocom.org/6667
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: IPA_Emulation: Don't log IPAC_MSGT_ID_RESP as
"Unknown/unsupported"
..
IPA_Emulation: Don't log IPAC_MSGT_ID_RESP as "Unknown/unsupported"
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Introduce notion of 'bts_role'
..
RSL_Emulation: Introduce notion of 'bts_role'
So far we assumed we emulate the BTS side and talk to a
Review at https://gerrit.osmocom.org/6656
gsm0408_test: include BCD and leading zeros in test output
(Preparation for adding 3-digit MNC)
Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 8 insertions(+), 5
Review at https://gerrit.osmocom.org/6659
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually different; so far we treated both as 23. Re-encode an incoming BCD or
string of 023 as it were, i.e. not
Review at https://gerrit.osmocom.org/6662
gsm0408_test: add test cases for MNC with leading zeros
Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 149 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6663
gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing.
gsm48_mnc_cmp() will be used by osmo-sgsn.git
Change-Id:
Review at https://gerrit.osmocom.org/6661
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 45 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6658
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai()
Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 53 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6654
cosmetic: gsm0408_test: RA test cases as array-of-struct
(Preparation for adding 3-digit MNC)
Change-Id: Ic6c645ebf82d5f8d9d51c4c4cc804a0172008156
---
M tests/gsm0408/gsm0408_test.c
1 file changed, 12 insertions(+), 8 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6655
gsm0408_test: cosmetically re-order MCC to come before MNC
For consistency in human readability, MCC simply should come first, always.
Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee
---
M tests/gsm0408/gsm0408_test.c
M
Review at https://gerrit.osmocom.org/6668
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Depends:
Review at https://gerrit.osmocom.org/6669
pcu_if: implement support for 3-digit MNC -- TODO
I am actually unsure how this one relates to the pcuif of osmo-bts and
osmo-pcu, if at all. Pushing this for review to probe the community for the
proper counterpart of this.
Change-Id:
Review at https://gerrit.osmocom.org/6667
use gsm48_ra_id instead of buf
Change-Id: I0d3908fb8ca1e2e669d257b5d59b40675fa85d06
---
M include/osmocom/bsc/abis_nm.h
M include/osmocom/bsc/gsm_data.h
M src/libbsc/abis_nm.c
M src/libbsc/bts_ipaccess_nanobts_omlattr.c
M src/libbsc/gsm_data.c
5 files
Review at https://gerrit.osmocom.org/
implement support for 3-digit MNC with leading zeros
Receive the mnc_3_digits flag from the PCU interface. Bump the PCU interface
version from 7 to 9 to match osmo-bts (see
I49cd762c3c9d7ee6a82451bdf3ffa2a060767947 there).
Add 3-digit flags and use
Review at https://gerrit.osmocom.org/6664
GSM_MNC_INVALID
Change-Id: Ieee7add0bd6d94cf84743a49794bbcd38561b72f
---
M include/osmocom/gsm/gsm48.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/6664/1
diff --git
Review at https://gerrit.osmocom.org/6665
implement support for 3-digit MNC with leading zeros
Record the mnc_3_digits flag from SI and pass on via the PCU interface.
Bump the PCU interface version from 7 to 9, since osmo-bsc.git had a pcuif of
version 8 already, and its addition of the
Review at https://gerrit.osmocom.org/6657
gsm0408_test: RA test: include min/max value cases
(Preparation for adding 3-digit MNC)
Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 22 insertions(+), 0
Review at https://gerrit.osmocom.org/6660
gsm0408_test: check for new mnc_3_digits flag
Note that on the input side, the 3-digits flag may be left false when the MNC
is >99 anyway. On the decoded side, the flag is set accurately.
Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
---
M
gsm0408_test: add test cases for MNC with leading zeros
Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 149 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing.
gsm48_mnc_cmp() will be used by osmo-sgsn.git
Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6
---
M
gsm0408_test: check for new mnc_3_digits flag
Note that on the input side, the 3-digits flag may be left false when the MNC
is >99 anyway. On the decoded side, the flag is set accurately.
Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
---
M tests/gsm0408/gsm0408_test.c
M
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c
File CommonLibs/debug.c:
Line 9: .description = "Transciever",
> _ei_ not _ie_ because its receiver, not reciever and "Transceiver" is from
Typo indeed :-)
Review at https://gerrit.osmocom.org/6631
compiler warning: ignore deprecated in mgcp_client_test.c
mgcp_msg_crcx() causes deprecation warning, but it's fine for a unit test
to use deprecated API.
Change-Id: Iba6d0c9c729367e00a9ab7fff7c89007d336e59d
---
M tests/mgcp_client/mgcp_client_test.c
mgcp_client: show failure by MGCP SDP section parsing test
To show how the current code fails, add test_sdp_section_start() to
mgcp_client_test.c, and temporarily accept failing output. This will be fixed
in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98.
Change-Id:
Review at https://gerrit.osmocom.org/6638
mgcp_client: show failure by MGCP SDP section parsing test
To show how the current code fails, add test_sdp_section_start() to
mgcp_client_test.c, and temporarily accept failing output. This will be fixed
in change
Review at https://gerrit.osmocom.org/6640
mgcp_client: detect SDP section-start parsing errors
After call to mgcp_find_section_end(), actually check the proper variable to
evaluate its return value.
Show in mgcp_client_test output that the parsing errors are fixed, and enable
the assertion
Review at https://gerrit.osmocom.org/6639
mgcp_client: cosmetic: clean up SDP params parsing
The mgcp_response_parse_params() is in a jumble. Straighten out these cosmetic
issues:
- Move assertion of r->body close to its first use.
- Instead of a talloc_zero and osmo_strlcpy dance, simply use
mgcp_client: cosmetic: clean up SDP params parsing
The mgcp_response_parse_params() is in a jumble. Straighten out these cosmetic
issues:
- Move assertion of r->body close to its first use.
- Instead of a talloc_zero and osmo_strlcpy dance, simply use talloc_strdup().
- Drop the first unused
Review at https://gerrit.osmocom.org/6643
vty: display bts features in vty command show bts
The VTY command show bts does not display the bts specific
features yet.
- Also display the feature list in snow-bts
Change-Id: I509f2a7bbfa96c70bdfea4ff2488ee371e914620
---
M src/common/vty.c
1 file
Review at https://gerrit.osmocom.org/6644
bts: use feature list instead of speech codec table
osmo-bts has a table of pchan/channel mode combinations for every
bts. This table models the codec capabilitys of the BTS hardware.
However, having the speech codec apabilities modeled inside the
BTS
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6623
to look at the new patch set (#2).
ports.h: Add VTY and CTRL ports for osmo-trx
Change-Id: Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9
---
M include/osmocom/ctrl/ports.h
M
Review at https://gerrit.osmocom.org/6634
RSL: Properly reject RSL CHAN_NR IE for incompatible PCHAN
If we receive a message for a dedicated channel, whose channel number
structure doesn't match with the physical channel (timeslot) type,
we must properly reject this. For RSL CHAN ACT it means
Review at https://gerrit.osmocom.org/6635
RSL: Ensure we don't accept DCHAN messages for CCHAN
If the Channel Number IE points to a common channel, we cannot
accept such messages in code paths that only process dedicated
channels, such as RLL/DCHAN/IPA.
Related: OS#2972, OS#2971
Change-Id:
Review at https://gerrit.osmocom.org/6642
octphy: ensure all BTS models set features
Most of the BTS models do not or do register not all of thier
features to the the feature list.
- Update/extend the feature lists for all BTS-Models
Change-Id: I26765a64153368016921c2ac115b1c4aec9bc5e4
---
M
1 - 100 of 143 matches
Mail list logo