osmocom-bb[fixeria/trx]: trxcon: Define event names for osmo_fsm's

2018-03-01 Thread Vadim Yanitskiy
Patch Set 2: Code-Review+1 (1 comment) Anyway, this change makes sense. https://gerrit.osmocom.org/#/c/7009/2/src/host/trxcon/trxcon.c File src/host/trxcon/trxcon.c: Line 128: static const struct value_string app_evt_names[] = { Hmm, it's pretty strange that it's sending both TRX and L1CTL

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-01 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7021 jenkins: add osmo-gsm-tester_run-{prod,rnd} Both jobs doing the actual test run on the prod or rnd tester. Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 --- M jobs/osmo-gsm-tester.yml A jobs/osmo-gsm-tester_run-prod.sh A

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-01 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7022 jenkins: add job osmo-gsm-tester_gerrit The job verifies the gerrit patchset. Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 --- M jobs/osmo-gsm-tester.yml A jobs/osmo-gsm-tester_gerrit.sh 2 files changed, 64 insertions(+), 1 deletion(-) git

[PATCH] osmo-ttcn3-hacks[master]: hlr: Rename module + file from GSUP_Test to HLR_Tests

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7017 hlr: Rename module + file from GSUP_Test to HLR_Tests Change-Id: I906c0046a4cf6ae95e5a0aca918f4375fedfea55 --- R hlr/HLR_Tests.ttcn M hlr/regen_makefile.sh 2 files changed, 2 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: gtp: Add some CAUSE enum definitions

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7016 gtp: Add some CAUSE enum definitions Change-Id: Id52eb710201428ba180ca6ffd5129f3126e54850 --- M library/GTP_Templates.ttcn 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: hlr: Integrate VTY and CTRL support

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7018 hlr: Integrate VTY and CTRL support Change-Id: I3fbc26a98d31df6d4753848bba655a517801d686 --- A hlr/HLR_Tests.cfg A hlr/HLR_Tests.default M hlr/HLR_Tests.ttcn M hlr/gen_links.sh M hlr/regen_makefile.sh 5 files changed, 64 insertions(+), 5 deletions(-)

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-01 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7020 jenkins: add job osmo-gsm-tester_build-trigger-all osmo-gsm-tester_build-trigger-all triggers a new build of all osmo-gsm-tester build jobs. Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd --- M jobs/osmo-gsm-tester.yml 1 file changed, 12

osmocom-bb[fixeria/trx]: WIP: host/trxcon/scheduler: add PDTCH channel support

2018-03-01 Thread Vadim Yanitskiy
Patch Set 1: Code-Review-1 Verified-1 This change was not properly tested. Just an initial step to implement PDTCH support. Let's discuss what we also need to do here? As I know, we also would need to handle some TBF specific L1CTL commands -- To view, visit

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7014 to look at the new patch set (#2). fake_trx: Increase TOA256 value ranges In theory, the maximum TA value is 63 symbols, i.e. 63*256 in this context. However, our test cases want to

osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Vadim Yanitskiy
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7014 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I691d081256e8c6d18ef2836299ed8f7d502da3ee Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx: Send positive response to FAKE_TOA commands

2018-03-01 Thread Vadim Yanitskiy
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7012 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba138835149a7264f4db3a6b05f54ca501c4d54 Gerrit-PatchSet: 3 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx: Always send control responses to where commands ar...

2018-03-01 Thread Vadim Yanitskiy
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7011 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a0bba6eed059b101af95dac7d059f34dd715fc Gerrit-PatchSet: 3 Gerrit-Project: osmocom-bb Gerrit-Branch:

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-01 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7019 jenkins: add osmo-gsm-tester-build jobs The build jobs building all osmocom components which will be used by the osmo-gsm-tester. A .tgz archive will be used as artefact which is copied later by the osmo-gsm-tester test run. Change-Id:

[PATCH] osmocom-bb[fixeria/trx]: WIP: host/trxcon/scheduler: add PDTCH channel support

2018-03-01 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7023 WIP: host/trxcon/scheduler: add PDTCH channel support Change-Id: I1176576f54c1d68e79cc6ac37d61a9033f7018dd --- M src/host/trxcon/Makefile.am M src/host/trxcon/sched_lchan_desc.c A src/host/trxcon/sched_lchan_pdtch.c M src/host/trxcon/sched_trx.h 4

osmocom-bb[fixeria/trx]: fake_trx: Log IP/Port information at start-up

2018-03-01 Thread Vadim Yanitskiy
Patch Set 2: Code-Review-1 (1 comment) Let's implement a new method in the UDPLink, e.g. desc_link(), which would return a link description. I think it's more flexible way, what do you think? https://gerrit.osmocom.org/#/c/7010/2/src/target/fake_trx/ctrl_if_bts.py File

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-01 Thread lynxis lazus
Patch Set 1: This job hasn't been yet deployed on the jenkins. -- To view, visit https://gerrit.osmocom.org/7022 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 Gerrit-PatchSet: 1 Gerrit-Project:

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-01 Thread lynxis lazus
Patch Set 1: Both jobs hasn't been yet deployed on the jenkins. -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 Gerrit-PatchSet: 1

[PATCH] osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: make sure altstep exists

2018-03-01 Thread dexter
Review at https://gerrit.osmocom.org/7025 MSC_ConnectionHandler: make sure altstep exists The altstep as_handover does not exit as each of its branches is equipped with a repeat statement on the end. This trapps us in an endless loop. - remove the repeat statement at the last logical step

osmocom-bb[fixeria/trx]: fake_trx: Always send control responses to where commands ar...

2018-03-01 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7011 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a0bba6eed059b101af95dac7d059f34dd715fc Gerrit-PatchSet: 3 Gerrit-Project: osmocom-bb Gerrit-Branch:

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Harald Welte
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7014 to look at the new patch set (#4). fake_trx: Increase TOA256 value ranges In theory, the maximum TA value is 63 symbols, i.e. 63*256 in this context. However, our

osmocom-bb[fixeria/trx]: WIP: host/trxcon/scheduler: add PDTCH channel support

2018-03-01 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7023/1/src/host/trxcon/sched_lchan_pdtch.c File src/host/trxcon/sched_lchan_pdtch.c: Line 44: int rx_pdtch_fn(struct trx_instance *trx, struct trx_ts *ts, I think PDCH is more correct than PDTCH. Basically, a PDCH slot can carry PACCH,

osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Harald Welte
Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/7014 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I691d081256e8c6d18ef2836299ed8f7d502da3ee Gerrit-PatchSet: 4 Gerrit-Project: osmocom-bb Gerrit-Branch: fixeria/trx

[MERGED] osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx: Increase TOA256 value ranges .. fake_trx: Increase TOA256 value ranges In theory, the maximum TA value is 63 symbols, i.e. 63*256 in this

[PATCH] osmo-ttcn3-hacks[master]: BSC_Tests: use isvalue() instead of isbound()

2018-03-01 Thread dexter
Review at https://gerrit.osmocom.org/7024 BSC_Tests: use isvalue() instead of isbound() Currently we use isbound() in f_start_handler() to check if the BTS which we want to connect is indeed populated. However. isbound() seems never become true in this particular situation. - Use isvalue()

[PATCH] osmocom-bb[fixeria/trx]: trxcon: Fix '-i' to specify the "TRX IP address"

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7026 trxcon: Fix '-i' to specify the "TRX IP address" The command line help states '-i' is for 'TRX IP address', which is the remote IP address at which the TRX is to be found. Hoewever, it was used as the local (bind) IP address of the socket used towards

[MERGED] osmo-ttcn3-hacks[master]: BSC_Tests: use isvalue() instead of isbound()

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC_Tests: use isvalue() instead of isbound() .. BSC_Tests: use isvalue() instead of isbound() Currently we use isbound() in f_start_handler() to check

[MERGED] osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: make sure altstep exists

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: MSC_ConnectionHandler: make sure altstep exists .. MSC_ConnectionHandler: make sure altstep exists The altstep as_handover does not exit as each of its

osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: make sure altstep exists

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7025 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cb57a9fef606f459542708206f5ea4de1def7a1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: BSC_Tests: use isvalue() instead of isbound()

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7024 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ddd55b7626087570311999b85ec7632b162c06 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: bts: Make IP address of fake_trx BB CTRL port configurable

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7027 bts: Make IP address of fake_trx BB CTRL port configurable Change-Id: Idbfe9e0327ed6acefd87afc8596485a488fc44d9 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[MERGED] osmo-ttcn3-hacks[master]: hlr: Rename module + file from GSUP_Test to HLR_Tests

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hlr: Rename module + file from GSUP_Test to HLR_Tests .. hlr: Rename module + file from GSUP_Test to HLR_Tests Change-Id:

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Harald Welte
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7014 to look at the new patch set (#3). fake_trx: Increase TOA256 value ranges In theory, the maximum TA value is 63 symbols, i.e. 63*256 in this context. However, our

[MERGED] osmocom-bb[fixeria/trx]: fake_trx: Send positive response to FAKE_TOA commands

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx: Send positive response to FAKE_TOA commands .. fake_trx: Send positive response to FAKE_TOA commands Now that ctrl_if.py is capable of sending

[MERGED] libosmocore[master]: introduce GSM_MCC_MNC_INVALID

2018-03-01 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: introduce GSM_MCC_MNC_INVALID .. introduce GSM_MCC_MNC_INVALID In some cases, we want to mark an unset MCC-MNC. Define uint16-max for this purpose.

osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-03-01 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7014 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I691d081256e8c6d18ef2836299ed8f7d502da3ee Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx: Send positive response to FAKE_TOA commands

2018-03-01 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7012 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba138835149a7264f4db3a6b05f54ca501c4d54 Gerrit-PatchSet: 3 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: trxcon: Define event names for osmo_fsm's

2018-03-01 Thread Harald Welte
Patch Set 2: I agree with the "strange" part. What's even more strange is that there are two FSMs that have no events at all ;) -- To view, visit https://gerrit.osmocom.org/7009 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmocom-bb[fixeria/trx]: trxcon: Define event names for osmo_fsm's

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: trxcon: Define event names for osmo_fsm's .. trxcon: Define event names for osmo_fsm's Change-Id: Id3279e99966a0ab236923c497ac0abbc9ed2c93c --- M

[MERGED] libosmocore[master]: timer: Introduce osmo_clock_gettime to override clock_gettime

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: timer: Introduce osmo_clock_gettime to override clock_gettime .. timer: Introduce osmo_clock_gettime to override clock_gettime Change-Id:

libosmocore[master]: timer: Document osmo_gettimeofday API

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7015 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f9e13645033c61ffaed97e457deb5e78a6bec58 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: timer: Introduce osmo_clock_gettime to override clock_gettime

2018-03-01 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6961 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bebc6e01fc9d238065bc2517058f0ba85620349 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-ttcn3-hacks[master]: hlr: Rename module + file from GSUP_Test to HLR_Tests

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7017 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906c0046a4cf6ae95e5a0aca918f4375fedfea55 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: hlr: Integrate VTY and CTRL support

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hlr: Integrate VTY and CTRL support .. hlr: Integrate VTY and CTRL support Change-Id: I3fbc26a98d31df6d4753848bba655a517801d686 --- A hlr/HLR_Tests.cfg

osmo-ttcn3-hacks[master]: hlr: Integrate VTY and CTRL support

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7018 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fbc26a98d31df6d4753848bba655a517801d686 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: gtp: Add some CAUSE enum definitions

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7016 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52eb710201428ba180ca6ffd5129f3126e54850 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: gtp: Add some CAUSE enum definitions

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gtp: Add some CAUSE enum definitions .. gtp: Add some CAUSE enum definitions Change-Id: Id52eb710201428ba180ca6ffd5129f3126e54850 --- M

osmocom-bb[fixeria/trx]: trxcon: Define event names for osmo_fsm's

2018-03-01 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7009 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3279e99966a0ab236923c497ac0abbc9ed2c93c Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: WIP: host/trxcon/scheduler: add PDTCH channel support

2018-03-01 Thread Harald Welte
Patch Set 1: regarding L1CTL: You can check virt_phy and how it implements L1CTL_TBF_CFG_REQ / L1CTL_DATA_TBF_REQ / L1CTL_DATA_TBF_CONF as committed in b2c19fc5d35f25a63b2ee523761c3d9714b146e9 -- To view, visit https://gerrit.osmocom.org/7023 To unsubscribe, visit

[MERGED] osmocom-bb[fixeria/trx]: fake_trx: Always send control responses to where commands ar...

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx: Always send control responses to where commands are from .. fake_trx: Always send control responses to where commands are from fake_trx is

[MERGED] libosmocore[master]: timer: Document osmo_gettimeofday API

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: timer: Document osmo_gettimeofday API .. timer: Document osmo_gettimeofday API Change-Id: I1f9e13645033c61ffaed97e457deb5e78a6bec58 --- M

osmo-sgsn[master]: implement support for 3-digit MNC with leading zeros

2018-03-01 Thread Neels Hofmeyr
Patch Set 2: > just to make sure we have tested this somehow, particularly the > gbproxy changes (see my last comment) ack. (I recently tend to miss comments without a -1 marking, sorry about that.) -- To view, visit https://gerrit.osmocom.org/6672 To unsubscribe, visit

[MERGED] osmo-ttcn3-hacks[master]: bts: ensure fake_trx BB CTRL IP is used from main component

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: ensure fake_trx BB CTRL IP is used from main component .. bts: ensure fake_trx BB CTRL IP is used from main component .. not just from the ConnHdlr

osmo-ttcn3-hacks[master]: bts: ensure fake_trx BB CTRL IP is used from main component

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7028 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db2884d2519dfd4ae08ff1a4dae5b488677da4c Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: hlr: Add hlr sub-directory to master Makefile (for 'make com...

2018-03-01 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7031 to look at the new patch set (#2). hlr: Add hlr sub-directory to master Makefile (for 'make compile' checks) Change-Id: Idbd8241fc7d217885f65f84e11f9f1ea13adb82e --- M Makefile M

osmo-ttcn3-hacks[master]: hlr: Add hlr sub-directory to master Makefile (for 'make com...

2018-03-01 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7031 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbd8241fc7d217885f65f84e11f9f1ea13adb82e Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmocom-bb[fixeria/trx]: trxcon: Fix '-i' to specify the "TRX IP address"

2018-03-01 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7026 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0252b15e9c7942687c6dc470951d777f7af651c Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: hlr: Add hlr sub-directory to master Makefile (for 'make com...

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hlr: Add hlr sub-directory to master Makefile (for 'make compile' checks) .. hlr: Add hlr sub-directory to master Makefile (for 'make compile' checks)

osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-03-01 Thread Harald Welte
Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6387 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b76ae6b00043e706dddc78209311e00ace85bb7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch:

[MERGED] osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Generate the S_L_INP_TEI_UP signal earlier. .. Generate the S_L_INP_TEI_UP signal earlier. The S_L_INP_TEI_UP signal was generated when the first

osmo-ttcn3-hacks[master]: bts: Make IP address of fake_trx BB CTRL port configurable

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7027 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbfe9e0327ed6acefd87afc8596485a488fc44d9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: bts: Make IP address of fake_trx BB CTRL port configurable

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Make IP address of fake_trx BB CTRL port configurable .. bts: Make IP address of fake_trx BB CTRL port configurable Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: bts: ensure fake_trx BB CTRL IP is used from main component

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7028 bts: ensure fake_trx BB CTRL IP is used from main component .. not just from the ConnHdlr component, as in previous patch Change-Id: I3db2884d2519dfd4ae08ff1a4dae5b488677da4c --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] osmo-bts[master]: octphy: replace #warning with #pragma message

2018-03-01 Thread dexter
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6992 to look at the new patch set (#2). octphy: replace #warning with #pragma message warning causes the compiler to throw an actual warning. Lets change

osmo-ttcn3-hacks[master]: hlr: Make test run again using current OsmoHLR / TTCN-3 library

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7030 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4304d6f69a349845d74a9dbe5e366525d5d8956f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: hlr: Make test run again using current OsmoHLR / TTCN-3 library

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hlr: Make test run again using current OsmoHLR / TTCN-3 library .. hlr: Make test run again using current OsmoHLR / TTCN-3 library Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: hlr: Add hlr sub-directory to master Makefile (for 'make com...

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7031 hlr: Add hlr sub-directory to master Makefile (for 'make compile' checks) Change-Id: Idbd8241fc7d217885f65f84e11f9f1ea13adb82e --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: hlr: Make test run again using current OsmoHLR / TTCN-3 library

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7030 hlr: Make test run again using current OsmoHLR / TTCN-3 library Change-Id: I4304d6f69a349845d74a9dbe5e366525d5d8956f --- M hlr/HLR_Tests.default M hlr/HLR_Tests.ttcn 2 files changed, 15 insertions(+), 3 deletions(-) git pull

[PATCH] osmo-bts[master]: l1_tch: remove dead code

2018-03-01 Thread dexter
Review at https://gerrit.osmocom.org/7029 l1_tch: remove dead code the file l1_tch.c in the octphy spcific code has its root in the tch.c file of sysmobts. It contains some sysmobts specific ifdefs which enclose dead code. - Remove the sysmobts specif ifdefs and the dead code Change-Id:

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/aarch64

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

osmo-bsc[master]: a_reset: Add FSM event names

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6952 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief1eff45a896d6191bdc64c232be69e85bfc63dc Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ttcn3-hacks[master]: gsup: Make tr_GSUP_ISD_REQ more tolerant

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7040 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic63cd5c9a5e9ed46c70f7d7869b4ece281b97e44 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: hlr: Add TC_vty_msisdn_isd

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7039 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I597a3c2d49aa6fa65007304105363a3e99fa4ae9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: hlr: Add TC_vty_msisdn_isd

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hlr: Add TC_vty_msisdn_isd .. hlr: Add TC_vty_msisdn_isd This tests whether the HLR is sending an InsertSubscriberData to the VLR of an

osmocom-bb[fixeria/trx]: WIP: host/trxcon/scheduler: add PDTCH channel support

2018-03-01 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7023/1/src/host/trxcon/sched_lchan_pdtch.c File src/host/trxcon/sched_lchan_pdtch.c: Line 44: int rx_pdtch_fn(struct trx_instance *trx, struct trx_ts *ts, > I think PDCH is more correct than PDTCH. Basically, a PDCH slot can carry

[PATCH] osmo-ttcn3-hacks[master]: hlr: Add testcases for PURGE_MS procedure

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7042 hlr: Add testcases for PURGE_MS procedure Change-Id: I9d54d5e4b6fe24d3ee710b57e0c69a30b89d3450 --- M hlr/HLR_Tests.ttcn M library/GSUP_Types.ttcn 2 files changed, 114 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: hlr: Fix test of UL+ISD state machine

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7041 hlr: Fix test of UL+ISD state machine Don't exit too early: After sending ISD.resp we still need to wait for the UL.res from the HLR before continuing processing. Change-Id: Iab42a397cbca83b86fc8a6b26ae2d66abb81c187 --- M hlr/HLR_Tests.ttcn 1 file

[MERGED] osmo-bsc[master]: a_reset: Add FSM event names

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: a_reset: Add FSM event names .. a_reset: Add FSM event names The FSM lacks a proper definition of the FSM event names. This causes problems when

[PATCH] osmo-hlr[master]: Fix responses to PURGE MS

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7043 Fix responses to PURGE MS When performing PURGE MS, OsmoHLR before this patch used toreturn an error even in the successful case. The reasone for this is some wrong assumptions about the return values of db_subscr_purge(). Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: msc: cosmetic: f_perform_lu() / pars: move send_early_cm to ...

2018-03-01 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7047 msc: cosmetic: f_perform_lu() / pars: move send_early_cm to BSC_ConnHdlrPars By moving to the BSC_ConnHdlrPars, also the tests that expect a LU failure able to indicate a send_cm_update flag. All current callers of f_perform_lu() pass send_early_cm as

[PATCH] osmo-ttcn3-hacks[master]: msc: cosmetic: f_start_handler(): drop the id arg, use testc...

2018-03-01 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7046 msc: cosmetic: f_start_handler(): drop the id arg, use testcasename() Change-Id: Id4efe8cd00f44ea744996efe04802c5107f2a191 --- M msc/MSC_Tests.ttcn 1 file changed, 42 insertions(+), 41 deletions(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: msc: cosmetic: pass BSC_ConnHdlrPars to f_start_handler() as...

2018-03-01 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7048 msc: cosmetic: pass BSC_ConnHdlrPars to f_start_handler() as argument Previously, f_start_handler() would initialize the BSC_ConnHdlrPars instance, making it impossible to change those parameters before the test function was invoked. Add separate

[PATCH] osmo-ttcn3-hacks[master]: msc: add TC_lu_imsi_auth_tmsi_encr_3_1_no_cm

2018-03-01 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7049 msc: add TC_lu_imsi_auth_tmsi_encr_3_1_no_cm This is a variation on TC_lu_imsi_auth_tmsi_encr_3_1 that "indicates" inability of A5/3 by completely omitting a Classmark2. Add flag send_cm_update to f_tc_lu_imsi_auth_tmsi_encr_3_1() so that we can

[PATCH] osmo-ttcn3-hacks[master]: msc: cosmetic: ts_CM1 template: parameterize esind (Early cl...

2018-03-01 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7051 msc: cosmetic: ts_CM1 template: parameterize esind (Early classmark Sending) Change-Id: If841fc2c9996bef5b962519a325e18f1c13d2b0f --- M library/L3_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull

[MERGED] osmo-msc[master]: implement support for 3-digit MNC with leading zeros

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: implement support for 3-digit MNC with leading zeros .. implement support for 3-digit MNC with leading zeros Add 3-digit flags and use the new RAI and

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

[MERGED] osmo-ttcn3-hacks[master]: hlr: Reduce code duplication by using template

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hlr: Reduce code duplication by using template .. hlr: Reduce code duplication by using template Change-Id: I7dcf0d27144e5dcf29babcb679ca9ef04b1f46a3

[MERGED] osmo-ttcn3-hacks[master]: gsup: Make tr_GSUP_ISD_REQ more tolerant

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsup: Make tr_GSUP_ISD_REQ more tolerant .. gsup: Make tr_GSUP_ISD_REQ more tolerant We permit other subscriber data that's not the MSISDN, but we

osmo-ttcn3-hacks[master]: hlr: Reduce code duplication by using template

2018-03-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7038 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcf0d27144e5dcf29babcb679ca9ef04b1f46a3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_(bb|bts).py: log link info at start-up

2018-03-01 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7010 to look at the new patch set (#4). fake_trx/ctrl_if_(bb|bts).py: log link info at start-up Change-Id: I4ebeed7271d91ab2e45199e0fb59776c00ad833c --- M src/target/fake_trx/ctrl_if_bb.py

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_(bb|bts).py: log link info at start-up

2018-03-01 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7010 to look at the new patch set (#5). fake_trx/ctrl_if_(bb|bts).py: log link info at start-up Change-Id: I4ebeed7271d91ab2e45199e0fb59776c00ad833c --- M src/target/fake_trx/ctrl_if_bb.py

[MERGED] osmo-hlr[master]: vty: Don't print error if removing auth data while none present

2018-03-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: Don't print error if removing auth data while none present .. vty: Don't print error if removing auth data while none present It's a bit confusing

[PATCH] osmo-ttcn3-hacks[master]: hlr: Add TC_vty_msisdn_isd

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7039 hlr: Add TC_vty_msisdn_isd This tests whether the HLR is sending an InsertSubscriberData to the VLR of an active/registered subscriber after the MSISDN is updated in the HLR. Change-Id: I597a3c2d49aa6fa65007304105363a3e99fa4ae9 Related: OS#2785 --- M

[PATCH] osmo-ttcn3-hacks[master]: hlr: Reduce code duplication by using template

2018-03-01 Thread Harald Welte
Review at https://gerrit.osmocom.org/7038 hlr: Reduce code duplication by using template Change-Id: I7dcf0d27144e5dcf29babcb679ca9ef04b1f46a3 --- M hlr/HLR_Tests.ttcn 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

[PATCH] osmo-ttcn3-hacks[master]: Makefile: use -j8, allow manual PARALLEL_MAKE val

2018-03-01 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7044 Makefile: use -j8, allow manual PARALLEL_MAKE val Set default -j to 8: even on a machine with less cores, using -j8 isn't really going to slow down the build. On a machine with eight cores, -j8 is going to speed up significantly. By using '?=', allow

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 166s]

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64

2018-03-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_(bb|bts).py: log link info at start-up

2018-03-01 Thread Vadim Yanitskiy
Patch Set 4: Verified-1 -- To view, visit https://gerrit.osmocom.org/7010 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ebeed7271d91ab2e45199e0fb59776c00ad833c Gerrit-PatchSet: 4 Gerrit-Project: osmocom-bb Gerrit-Branch: fixeria/trx

  1   2   >