Review at https://gerrit.osmocom.org/7501
gscon: fix illegal state transitions
The GSCON fsm has two illegal state transions. The transions
themselves are logically legal but theur respective entries
in out_state_mask are missing.
- remove unnecessary transition from ST_ACTIVE to ST_ACTIVE
-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7494
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I196033e44d50ebb73cf9b44cbdc94a2b8b4f98ce
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7500
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabaaab57f0d1687607eaaa4e09c7c2439fbd7a25
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7501
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I165c3e8b4b268b50e5f4a482b0fe890e940637b3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7495
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I420c7be84e3af555cc5e8bddbff7261013348375
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7497
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6319a958b3c7247510c1930bac8b02b95f9dcf2
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7498
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a10b615288107e8fc12ffdbbe0099cf51abe94f
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: gsm0808_test: drop extraneous assertion
..
cosmetic: gsm0808_test: drop extraneous assertion
Recent commit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7499
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib07380894a6d513896c9135f175ecbf653a23eec
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7496
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56d70ae14d363f7ca655dced16d93d795b3f940d
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7493
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb2ea363e8a9d86b24338df3584abc93ebc6dd4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Stefan Sperling has submitted this change and it was merged.
Change subject: preserve 'when' flags of new osmo_fd in ipaccess_rcvmsg()
..
preserve 'when' flags of new osmo_fd in ipaccess_rcvmsg()
ipaccess_rcvmsg() disposes of
Patch Set 1:
It seems osmo-gsm-tester_gerrit job was misisng some configs I see in other
gerrit jobs. I added it and I'm trying it now with another patch of mine.
The main issue is that those jobs were migrated lately to use
jenkins-job-builder and the confgis were pushed to jenkins but the
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7462/1/src/input/ipaccess.c
File src/input/ipaccess.c:
Line 197: memcpy(>list, >list,
sizeof(newbfd->list));
> why not just
Seems to me like both forms are equivalent and it's not an important enough
detail to
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7428
to look at the new patch set (#2).
cosmetic: remove dead code
There is a lot of dead code in osmo_bsc_msc.c that used to handle
the IPA multiplexed SSCP lite A
Review at https://gerrit.osmocom.org/7507
cosmetic: Add fixme note for OS#3112
Change-Id: I0c3ffb567aff08014f8fb96928077afb8c2f229c
---
M src/osmo-bsc/osmo_bsc_msc.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/7507/1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: don't match on event names in comments
..
contrib/fsm-to-dot: don't match on event names in comments
Strip comments from function
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7487
to look at the new patch set (#2).
octphy: integrate octasics latest header release
At the moment osmo-bts does not compile with the latest header
file release from
Review at https://gerrit.osmocom.org/7503
Generate the S_L_INP_TEI_UP signal earlier.
The S_L_INP_TEI_UP signal was generated when the first message from a BTS
arrives on the OML/RSL link, rather than when the OML/RSL link comes up.
Instead, generate this signal when the link is brought up, so
Review at https://gerrit.osmocom.org/7505
contrib/fsm-to-dot: mark illegal states in red
If an FSM transitions to a state that actually belongs to a different FSM,
print an error and mark it red, instead of exiting with exception.
Change-Id: I73d95a0c65ca1ea586ad55234610671a53d6220f
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: less false positives on event parsing
..
contrib/fsm-to-dot: less false positives on event parsing
Do some more mad hacking to only
Review at https://gerrit.osmocom.org/7506
contrib/fsm-to-dot: warn about identically named FSMs
FSMs with identical names confuse the script, so at least warn about them.
IMHO we should also have different names for each FSM, so not bothering to make
the script safe against identical naming.
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/7505
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d95a0c65ca1ea586ad55234610671a53d6220f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: mark arrows that feed events
..
contrib/fsm-to-dot: mark arrows that feed events
Most arrows draw state transitions, but some want
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: warn and draw unallowed state transitions
..
contrib/fsm-to-dot: warn and draw unallowed state transitions
Hacked as it is,
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: allow transition from and to the same state
..
contrib/fsm-to-dot: allow transition from and to the same state
In osmo-bsc's new
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: add default edge label '-'
..
contrib/fsm-to-dot: add default edge label '-'
When some edges have no label, it is sometimes hard to
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: add -h option to print basic instructions
..
contrib/fsm-to-dot: add -h option to print basic instructions
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: mark illegal states in red
..
contrib/fsm-to-dot: mark illegal states in red
If an FSM transitions to a state that actually belongs
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/7506
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe7e85d2fdf23e2ba964f3b47be1954edc63cef
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: warn about identically named FSMs
..
contrib/fsm-to-dot: warn about identically named FSMs
FSMs with identical names confuse the
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/7508/1/src/libbsc/bts_nokia_site.c
File src/libbsc/bts_nokia_site.c:
Line 1237: ret = abis_nm_sendmsg(bts, msg);
change in behavior: previously, abis_nm_sendmsg() could return a positive value
in the last loop
Review at https://gerrit.osmocom.org/7510
paging: paging_request_bts: Fix wrong return value
Change-Id: I48f5efbcddd98e15256edfca06ba0ae6acb5bab1
---
M src/libbsc/paging.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/7510/1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7511
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8075d076cc34570fefce3beb577567707a29d4e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_vty.c: In function
‘lchan_summary’:
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_vty.c:1464:9: error: ‘ts’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
lchan = >lchan[lchan_nr];
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3ca50009e25c8e10bcbd15e430caf6de18a040
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7504
fix TCH/H for TC_chan_exhaustion
At the moment we use onle TCH/F and PDCH in our osmo-bsc config,
but the tests TC_assignment_codec_amr_h and TC_assignment_codec_h
requre a half rate channel in order to work. Configuring one TCH/F
to TCH/H seems not to
Patch Set 1:
we will need the config file change in docker-playground.git.
--
To view, visit https://gerrit.osmocom.org/7504
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a9602f1b49b5aa0fc510faa151fe16c0b404d
Gerrit-PatchSet: 1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7504
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a9602f1b49b5aa0fc510faa151fe16c0b404d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7501
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I165c3e8b4b268b50e5f4a482b0fe890e940637b3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7511
bssap: Log non handled paging requests
Return code in bssap_test is changed to ack it was sent and prevent the
log from being printed.
Change-Id: Ie8075d076cc34570fefce3beb577567707a29d4e
---
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/bssap/bssap_test.c
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7508/1/src/libbsc/bts_nokia_site.c
File src/libbsc/bts_nokia_site.c:
Line 1237: ret = abis_nm_sendmsg(bts, msg);
> change in behavior: previously, abis_nm_sendmsg() could return a positive v
I didn't think about this, thanks
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7510/1/src/libbsc/paging.c
File src/libbsc/paging.c:
Line 345: return 0;
why not handle the negative rc properly at the callers?
--
To view, visit https://gerrit.osmocom.org/7510
To unsubscribe, visit
Review at https://gerrit.osmocom.org/7512
gsup_test_client: gsupc_read_cb: fix uninitialized value 'io'
Change-Id: Idb3ca50009e25c8e10bcbd15e430caf6de18a040
---
M src/libgsupclient/gsup_test_client.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7508
libbsc: nokia_site: Fix uninitialized return val
Fixes following compilation warning:
bts_nokia_site.c:1248:9: error: ‘ret’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
return ret;
This could happen if parameter len is
Review at https://gerrit.osmocom.org/7509
bsc_vty: Fix uninitialized var false positive on gcc 7.3.1
Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
---
M src/libbsc/bsc_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7509/1//COMMIT_MSG
Commit Message:
Line 8:
would be nice to include the error message from gcc, so we can have an opinion
on how you dealt with it
--
To view, visit https://gerrit.osmocom.org/7509
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7510/1/src/libbsc/paging.c
File src/libbsc/paging.c:
Line 345: return 0;
> why not handle the negative rc properly at the callers?
Because the behaviour was changed recently by stsp in all those functions while
refactoring
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7502
to look at the new patch set (#2).
nanobts: Bind to specific addr instead of specific iface
This way root access is not required.
Change-Id: I02f6fc9e1cb1ea1e1d950eafe22c231a18100f98
Patch Set 2: Verified+1
I've now successfully verified that this works, by running a manual osmo-nitb
network with the patch compiled in. (at first I built master by accident and
thus also verified that the current master of openbsc.git fails to send the
proper leading-zero MNC). See also the
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7417
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf50fd7e1ca5472d0a38fcb87c68227d6de44f42
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3ca50009e25c8e10bcbd15e430caf6de18a040
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7513
message sequence charts for GSM <-> SIP codec selection
Those diagrams represent the current design of the way how
GSM <-> SIP codec selection should work in the future.
Related: OS#1683
Change-Id: If92379b41d859bdf7be4b7689dc0bbca7cb6e682
---
A
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/7502/2/COPYING
File COPYING:
Line 1: GNU GENERAL PUBLIC LICENSE
?!?
--
To view, visit https://gerrit.osmocom.org/7502
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7518
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ef9697ff365bae9fbf7c5888fdb0b88e63b13bb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: More progress on osmo-sip-connector tests
..
More progress on osmo-sip-connector tests
Change-Id: I34a5d7929264c7f5f21d3868a5f919874ffa106c
---
M
Harald Welte has submitted this change and it was merged.
Change subject: message sequence charts for GSM <-> SIP codec selection
..
message sequence charts for GSM <-> SIP codec selection
Those diagrams represent the current
Harald Welte has submitted this change and it was merged.
Change subject: MNCC_Emulation: Make ExpectedCreateCallback work for SETUP_REQ,
too
..
MNCC_Emulation: Make ExpectedCreateCallback work for SETUP_REQ, too
In server
Harald Welte has submitted this change and it was merged.
Change subject: MNCC_EncDec.cc: Fix decoding of speech versions in bearer
capabilities
..
MNCC_EncDec.cc: Fix decoding of speech versions in bearer capabilities
Harald Welte has submitted this change and it was merged.
Change subject: MNCC_Types: More types for MNCC server (MSC) side emulation
..
MNCC_Types: More types for MNCC server (MSC) side emulation
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7519
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I988668cac9970af12d59d05a3a9facca257851c6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7513
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If92379b41d859bdf7be4b7689dc0bbca7cb6e682
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7521
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd1744da7da983412d5d34c40fd896bc7b896db
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: gsup_test_client: gsupc_read_cb: fix uninitialized value 'io'
..
gsup_test_client: gsupc_read_cb: fix uninitialized value 'io'
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7520
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd79ee769c967dc209a7e1859d9d8b18d09843e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7522
mslot_class: find_free_tfi(): use uint32_t to shift 1 << 31
Avoid runtime error seen on jenkins admin-deb9build slave, when building
osmo-pcu with_dsp=None,with_vty=False, during ts_alloc and tbf regression
tests:
+../../../src/mslot_class.c:242:22:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/7502/2/COPYING
File COPYING:
Line 1: GNU GENERAL PUBLIC LICENSE
> ?!?
That was a test to try to retrigger the the job as the gerrit job seems to be
not working fine.
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7466
to look at the new patch set (#2).
More progress on osmo-sip-connector tests
Change-Id: I34a5d7929264c7f5f21d3868a5f919874ffa106c
---
M library/MNCC_Types.ttcn
M
Harald Welte has restored this change.
Change subject: WIP: SIP progress
..
Restored
--
To view, visit https://gerrit.osmocom.org/7466
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: restore
Review at https://gerrit.osmocom.org/7520
MNCC_EncDec.cc: Fix decoding of speech versions in bearer capabilities
Change-Id: I4fd79ee769c967dc209a7e1859d9d8b18d09843e
---
M library/MNCC_EncDec.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7521
MNCC_Types: More types for MNCC server (MSC) side emulation
Change-Id: I1dd1744da7da983412d5d34c40fd896bc7b896db
---
M library/MNCC_Types.ttcn
1 file changed, 239 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Review at https://gerrit.osmocom.org/7519
MNCC_Emulation: Make ExpectedCreateCallback work for SETUP_REQ, too
In server mode, we need to handle SETUP_REQ in ExpectedCreateCallback,
not only SETUP_IND like in client mode.
Change-Id: I988668cac9970af12d59d05a3a9facca257851c6
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7466
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34a5d7929264c7f5f21d3868a5f919874ffa106c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7523
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cc41a40fb8706e9b0752be6e7c1f34dc692d87
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Makefile: Add new 'sip' testsuite to list of testsuites
..
Makefile: Add new 'sip' testsuite to list of testsuites
Change-Id:
Review at https://gerrit.osmocom.org/7523
Makefile: Add new 'sip' testsuite to list of testsuites
Change-Id: Ie7cc41a40fb8706e9b0752be6e7c1f34dc692d87
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
76 matches
Mail list logo