[MERGED] docker-playground[master]: add 'osmo-sip-master' Dockerfile

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add 'osmo-sip-master' Dockerfile .. add 'osmo-sip-master' Dockerfile Change-Id: Ie9623df1b3181ddcfd868c14f0b05614853447b0 --- A osmo-sip-master/.release

docker-playground[master]: add ttcn3-sip-test container

2018-03-27 Thread Harald Welte
Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7525 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe2a2b47c266788d51e98d64bca7017caf19e29 Gerrit-PatchSet: 2 Gerrit-Project: docker-playground

[MERGED] docker-playground[master]: add ttcn3-sip-test container

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add ttcn3-sip-test container .. add ttcn3-sip-test container Change-Id: Ibfe2a2b47c266788d51e98d64bca7017caf19e29 --- A ttcn3-sip-test/.release A

[MERGED] osmocom-bb[master]: virt_phy: Add missing gprs related entries to l1ctlPrimNames

2018-03-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: virt_phy: Add missing gprs related entries to l1ctlPrimNames .. virt_phy: Add missing gprs related entries to l1ctlPrimNames Change-Id:

docker-playground[master]: add 'osmo-sip-master' Dockerfile

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7524 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9623df1b3181ddcfd868c14f0b05614853447b0 Gerrit-PatchSet: 1 Gerrit-Project: docker-playground

[PATCH] docker-playground[master]: add ttcn3-sip-test container

2018-03-27 Thread Harald Welte
add ttcn3-sip-test container Change-Id: Ibfe2a2b47c266788d51e98d64bca7017caf19e29 --- A ttcn3-sip-test/.release A ttcn3-sip-test/Dockerfile A ttcn3-sip-test/Makefile A ttcn3-sip-test/SIP_Tests.cfg A ttcn3-sip-test/jenkins.sh A ttcn3-sip-test/osmo-sip-connector.cfg 6 files changed, 144

[MERGED] libosmocore[master]: VTY: Don't welcome the user to the "control" interface, if i...

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: VTY: Don't welcome the user to the "control" interface, if it's VTY .. VTY: Don't welcome the user to the "control" interface, if it's VTY This is

[MERGED] osmo-bsc[master]: libbsc: nokia_site: Fix uninitialized return val

2018-03-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: libbsc: nokia_site: Fix uninitialized return val .. libbsc: nokia_site: Fix uninitialized return val Fixes following compilation warning:

[PATCH] docker-playground[master]: add 'osmo-sip-master' Dockerfile

2018-03-27 Thread Harald Welte
Review at https://gerrit.osmocom.org/7524 add 'osmo-sip-master' Dockerfile Change-Id: Ie9623df1b3181ddcfd868c14f0b05614853447b0 --- A osmo-sip-master/.release A osmo-sip-master/Dockerfile A osmo-sip-master/Makefile A osmo-sip-master/Release.key A osmo-sip-master/osmo-sip-connector.cfg 5 files

[PATCH] docker-playground[master]: add ttcn3-sip-test container

2018-03-27 Thread Harald Welte
Review at https://gerrit.osmocom.org/7525 add ttcn3-sip-test container Change-Id: Ibfe2a2b47c266788d51e98d64bca7017caf19e29 --- A ttcn3-sip-test/.release A ttcn3-sip-test/Dockerfile A ttcn3-sip-test/Makefile A ttcn3-sip-test/SIP_Tests.cfg A ttcn3-sip-test/jenkins.sh A

[MERGED] osmo-sip-connector[master]: mncc: use 'const' to denote read-only input buffer/message

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mncc: use 'const' to denote read-only input buffer/message .. mncc: use 'const' to denote read-only input buffer/message We normally use the 'const'

[MERGED] osmo-sip-connector[master]: comments

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: comments .. comments Change-Id: Icf0e9211a4e93eb1b05b5a5d68f9ba766982da8d --- M src/mncc.c 1 file changed, 14 insertions(+), 0 deletions(-) Approvals:

osmo-sip-connector[master]: Call the program "OsmoSIPcon" (also in vty)

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7491 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba20c1c90e528d08bd362be39d86317569c253e6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sip-connector

osmo-sip-connector[master]: comments

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7489 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf0e9211a4e93eb1b05b5a5d68f9ba766982da8d Gerrit-PatchSet: 1 Gerrit-Project: osmo-sip-connector Gerrit-Branch:

osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

2018-03-27 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 yea I meant in the commit log but ok -- To view, visit https://gerrit.osmocom.org/7509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09 Gerrit-PatchSet: 1

[MERGED] osmo-pcu[master]: mslot_class: find_free_tfi(): use uint32_t to shift 1 << 31

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mslot_class: find_free_tfi(): use uint32_t to shift 1 << 31 .. mslot_class: find_free_tfi(): use uint32_t to shift 1 << 31 Avoid runtime error seen on

[MERGED] osmo-ttcn3-hacks[master]: fix TCH/H for TC_chan_exhaustion

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix TCH/H for TC_chan_exhaustion .. fix TCH/H for TC_chan_exhaustion At the moment we use onle TCH/F and PDCH in our osmo-bsc config, but the tests

osmo-pcu[master]: mslot_class: find_free_tfi(): use uint32_t to shift 1 << 31

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7522 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cdf10e5fbc1173a7a09bd4fed8a66d06f80aeb1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-trx[master]: jenkins.sh: cleanup always the workspace

2018-03-27 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6911 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3 Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] osmo-bsc[master]: change return type of page_subscriber() to void

2018-03-27 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7526 change return type of page_subscriber() to void We deliberately ignore errors from page_subscriber() so there is no point in having a non-void return value. Make this function log an error if paging failed. Adjust an implementation override of

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-27 Thread Pau Espin Pedrol
Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7022 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 Gerrit-PatchSet: 7 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-27 Thread Pau Espin Pedrol
Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 Gerrit-PatchSet: 6 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] openbsc[master]: bsc: Improve handling of paging_request return value

2018-03-27 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7528 bsc: Improve handling of paging_request return value Detail better in the API documentation what's the expected return value for paging_request. Change-Id: I17fa3b549bff297531b2777d658b0e0112a3031f --- M openbsc/src/libbsc/paging.c M

[PATCH] openbsc[master]: bsc: paging: Fix losing paging messages for BTS

2018-03-27 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7529 bsc: paging: Fix losing paging messages for BTS Since eb241aa1d5720a36cf97f29390c2890cf3aecba7 (year 2010) we are delaying transmission of paging packets 500ms in order to avoid crashing the nanobts because of sending too many packets. In consequence,

[PATCH] openbsc[master]: bsc: Improve handling of paging_request return value

2018-03-27 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7528 to look at the new patch set (#2). bsc: Improve handling of paging_request return value Detail better in the API documentation what's the expected return value for paging_request.

openbsc[master]: bsc: paging: Fix losing paging messages for BTS

2018-03-27 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7529 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2605367b2735b48bce2b31504c444360b5ca6953 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: gscon: fix illegal state transitions

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gscon: fix illegal state transitions .. gscon: fix illegal state transitions The GSCON fsm has two illegal state transions. The transions themselves are

[MERGED] docker-playground[master]: ttcn3-bscc-test/osmo-bsc.cfg: Add TCH/H channels

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ttcn3-bscc-test/osmo-bsc.cfg: Add TCH/H channels .. ttcn3-bscc-test/osmo-bsc.cfg: Add TCH/H channels The configuration of osmo-bsc currently only

osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: Set up the jenkins node accordingly and re-trigger the jenkins job so it gets +1 verified, then we can merge. -- To view, visit https://gerrit.osmocom.org/6909 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-gsm-tester[master]: nanobts: Bind to specific addr instead of specific iface

2018-03-27 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7502 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f6fc9e1cb1ea1e1d950eafe22c231a18100f98 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: nanobts: Bind to specific addr instead of specific iface

2018-03-27 Thread Pau Espin Pedrol
Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/7502 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f6fc9e1cb1ea1e1d950eafe22c231a18100f98 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-ci[master]: ansible: jenkins-slave: setup ttcn3 repository

2018-03-27 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7531 ansible: jenkins-slave: setup ttcn3 repository Change-Id: I3aa1bf52f6fcae129278dab7081ea5cfc97d0759 --- M ansible/roles/osmocom-jenkins-slave/defaults/main.yml M ansible/roles/osmocom-jenkins-slave/tasks/main.yml A

[PATCH] osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-27 Thread Pau Espin Pedrol
Hello Stefan Sperling, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7405 to look at the new patch set (#5). Move make artifacts to build subdir Avoid having 50-100 symlinks and .o objects in the same dir where the source/cfg

osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-03-27 Thread Harald Welte
Patch Set 1: my assumption is that * before this patch, the proposed test would fail (i.e. link not up) * after this patch, the proposed test will pass as the UP signal is created at connect, not at receive -- To view, visit https://gerrit.osmocom.org/7503 To unsubscribe, visit

osmo-bsc[master]: paging: paging_request_bts: Fix wrong return value

2018-03-27 Thread Stefan Sperling
Patch Set 1: Code-Review+1 (1 comment) This is good for consistency, though I don't think it has any effect on run-time behaviour. Does it? https://gerrit.osmocom.org/#/c/7510/1/src/libbsc/paging.c File src/libbsc/paging.c: Line 345: return 0; > I think paging was always

osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-03-27 Thread Harald Welte
Patch Set 1: how did you test it exactly? AFAICT you cannot provoke this behavior with real OsmoBTS as it will always send the RSL CCCH LOAD INDICATION or an EVENT CHANGE REPORT or anything immediately after the connection is up. So in order to trigger this situation, you'd have to

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-27 Thread Pau Espin Pedrol
Patch Set 6: Can we unify the sh script instead of having 2 of them with only 1 line changing? -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-27 Thread Neels Hofmeyr
Patch Set 7: Code-Review-1 hmm, I prefer to have gerrit verification jobs in an independent yml file, like we do so far with the other jjb files. This seems to anyway not use anything of the existing bits in the yml file, just adds another job below/in-between the other defs? Do you agree?

osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-27 Thread Neels Hofmeyr
Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/7020/5/jobs/osmo-gsm-tester-trigger.yml File jobs/osmo-gsm-tester-trigger.yml: Line 16: project:

osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-27 Thread lynxis lazus
Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/7020/5/jobs/osmo-gsm-tester-trigger.yml File jobs/osmo-gsm-tester-trigger.yml: Line 14: # hopefully the trigger will support lists in the future read this comment please -- To view, visit https://gerrit.osmocom.org/7020 To

[PATCH] osmo-gsm-tester[master]: nanobts: Bind to specific addr instead of specific iface

2018-03-27 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7502 to look at the new patch set (#3). nanobts: Bind to specific addr instead of specific iface This way root access is not required. Change-Id: I02f6fc9e1cb1ea1e1d950eafe22c231a18100f98

[MERGED] openbsc[master]: bsc: Improve handling of paging_request return value

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc: Improve handling of paging_request return value .. bsc: Improve handling of paging_request return value Detail better in the API documentation

openbsc[master]: bsc: Improve handling of paging_request return value

2018-03-27 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7528 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17fa3b549bff297531b2777d658b0e0112a3031f Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openbsc[master]: bsc: paging: Fix losing paging messages for BTS

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc: paging: Fix losing paging messages for BTS .. bsc: paging: Fix losing paging messages for BTS Since eb241aa1d5720a36cf97f29390c2890cf3aecba7 (year

[MERGED] osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

2018-03-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1 .. bsc_vty: Fix uninitialized var false positive on gcc 7.3.1 Change-Id:

[MERGED] osmo-bsc[master]: paging: paging_request_bts: Fix wrong return value

2018-03-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: paging: paging_request_bts: Fix wrong return value .. paging: paging_request_bts: Fix wrong return value Change-Id:

[MERGED] osmo-bsc[master]: bssap: Log non handled paging requests

2018-03-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: bssap: Log non handled paging requests .. bssap: Log non handled paging requests Return code in bssap_test is changed to ack it was sent and prevent

[PATCH] osmo-trx[master]: jenkins.sh: cleanup always the workspace

2018-03-27 Thread lynxis lazus
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6911 to look at the new patch set (#2). jenkins.sh: cleanup always the workspace It was broken before becaues of checking emptyness against literal string will never be

docker-playground[master]: ttcn3-bscc-test/osmo-bsc.cfg: Add TCH/H channels

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7527 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcce03ab0c98545a1f316d88e1f3dd75e2ff65e1 Gerrit-PatchSet: 1 Gerrit-Project: docker-playground

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-27 Thread Neels Hofmeyr
Patch Set 6: Code-Review-1 agree with pau -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 Gerrit-PatchSet: 6 Gerrit-Project: osmo-ci

osmo-bsc[master]: change return type of page_subscriber() to void

2018-03-27 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7526 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18c2ba53d2055d3eaff8c9ed939eb844af6dd2e Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-27 Thread lynxis lazus
Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/7022/7/jobs/osmo-gsm-tester-runner.yml File jobs/osmo-gsm-tester-runner.yml: Line 40: - builder: it would mean, I've to doublicate the blocks copy_artifact and copy_artifact_all and the defaults runner -- To view, visit

[MERGED] osmo-bsc[master]: change return type of page_subscriber() to void

2018-03-27 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. Change subject: change return type of page_subscriber() to void .. change return type of page_subscriber() to void We deliberately ignore errors from

openbsc[master]: bsc: paging: Fix losing paging messages for BTS

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: Hm strange, my local build didn't catch those compilation issues. I think I didn't enable build of osmo-bsc probably, I'll re-check. -- To view, visit https://gerrit.osmocom.org/7529 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-27 Thread lynxis lazus
Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7021 to look at the new patch set (#6). jenkins: add osmo-gsm-tester_run-{prod,rnd} Both jobs doing the actual test run on the prod or rnd tester. Change-Id:

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-27 Thread lynxis lazus
Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7022 to look at the new patch set (#7). jenkins: add job osmo-gsm-tester_gerrit The job verifies the gerrit patchset. Change-Id:

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-27 Thread lynxis lazus
Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7019 to look at the new patch set (#5). jenkins: add osmo-gsm-tester-build jobs The build jobs building all osmocom components which will be used by the

[PATCH] osmo-bsc[master]: change return type of page_subscriber() to void

2018-03-27 Thread Stefan Sperling
change return type of page_subscriber() to void We deliberately ignore errors from page_subscriber() so there is no point in having a non-void return value. Provide more context in the error message logged if paging failed. Add a comment in an implementation override of

osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-03-27 Thread lynxis lazus
Patch Set 1: -Code-Review well. let's merge this one, as it's better than before. -- To view, visit https://gerrit.osmocom.org/6909 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56f314d78c0ca968b1fef9a91ecd540a7cc8fa86

osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-03-27 Thread Stefan Sperling
Patch Set 1: > how did you test it exactly? AFAICT you cannot provoke this > behavior with real OsmoBTS as it will always send the RSL CCCH > LOAD INDICATION or an EVENT CHANGE REPORT or anything immediately > after the connection is up. So in order to trigger this situation, > you'd have

osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates for HANDOVER REQUIRED

2018-03-27 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7530/1/library/BSSMAP_Templates.ttcn File library/BSSMAP_Templates.ttcn: Line 149: template (value) BSSMAP_IE_SpeechVersion ts_BSSMAP_IE_SpeechVersion(SpeechVersion val) := { isn't it possible to use BSSMAP_FIELD_CodecType here? Is the

[PATCH] docker-playground[master]: ttcn3-bscc-test/osmo-bsc.cfg: Add TCH/H channels

2018-03-27 Thread dexter
Review at https://gerrit.osmocom.org/7527 ttcn3-bscc-test/osmo-bsc.cfg: Add TCH/H channels The configuration of osmo-bsc currently only supports halfrate traffic channels. In order to test assignments which contain half rate codecs we also have to have halfrate channels available. Change-Id:

osmo-bsc[master]: change return type of page_subscriber() to void

2018-03-27 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7526 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18c2ba53d2055d3eaff8c9ed939eb844af6dd2e Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-27 Thread Neels Hofmeyr
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7019 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085 Gerrit-PatchSet: 5 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates for HANDOVER REQUIRED

2018-03-27 Thread dexter
Review at https://gerrit.osmocom.org/7530 BSSMAP_Templates: Add templates for HANDOVER REQUIRED In order to form a minimal HANDOVER REQUIRED message additional Templates (ts_) are needed. - Add Template ts_BSSMAP_IE_SpeechVersion - Add Template ts_BSSMAP_IE_CurrentChannelType1 - Add Template

osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-27 Thread Pau Espin Pedrol
Patch Set 4: (4 comments) https://gerrit.osmocom.org/#/c/7405/4/bsc/regen_makefile.sh File bsc/regen_makefile.sh: Line 14: ln -s build/BSC_Tests ../BSC_Tests || true > My first reflex is to not want this around. > It is useful to be able to run older versions of osmo-ttcn3-hacks in the same >

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-27 Thread lynxis lazus
Patch Set 6: I've looked further into. I don't want to add jjb variables in the shell script. This will break shell scripts quite easy. e.g. if you try to use ${FOO} in a shell script, it will treat it a {FOO} variable. -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-27 Thread Neels Hofmeyr
Patch Set 6: Code-Review+2 reconsidering, these are the shell instructions for the "Build step" config, and I think after all they're abstracted enough that we could have two separate ones. There's also the possibility of configuring env vars for the jenkins job, which would I think be

[PATCH] osmo-sip-connector[master]: osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCC

2018-03-27 Thread Harald Welte
Review at https://gerrit.osmocom.org/7532 osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCC In Change-Id Iba20c1c90e528d08bd362be39d86317569c253e6 we changed the prompt, but didn't update osmoappdesc.py Change-Id: I7c7868bda2195e5e67b2db5824caee8fbfb5a3b6 --- M osmoappdesc.py 1

[PATCH] osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

2018-03-27 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7406 to look at the new patch set (#3). jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning make clean has subdir/Makefile as dependency. As a result, subdir/gen_links.sh

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-27 Thread lynxis lazus
Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7020 to look at the new patch set (#6). jenkins: add job osmo-gsm-tester_build-trigger-all osmo-gsm-tester_build-trigger-all triggers a new build of all

[MERGED] osmo-gsm-tester[master]: nanobts: Bind to specific addr instead of specific iface

2018-03-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: nanobts: Bind to specific addr instead of specific iface .. nanobts: Bind to specific addr instead of specific iface This way root access is not

osmo-gsm-tester[master]: nanobts: Bind to specific addr instead of specific iface

2018-03-27 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7502 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f6fc9e1cb1ea1e1d950eafe22c231a18100f98 Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[PATCH] meta-telephony[201705]: osmo-bsc: Split meas-utils into its own package

2018-03-27 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7536 osmo-bsc: Split meas-utils into its own package Additionally, libpcap dependency is added to have osmo-meas-pcap2db available. Change-Id: Ia6b33dbdf882394fa14270c34306dccf46b724e4 --- M recipes-osmocom/osmo-bsc/osmo-bsc.inc 1 file changed, 8

[PATCH] meta-telephony[201705]: osmocom: Update recipes to latest master

2018-03-27 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7533 osmocom: Update recipes to latest master Change-Id: Ie68fc98ff09491f159535c555d8cf590f7a3401c --- M recipes-misc/libsmpp/libsmpp34_git.bb M recipes-osmocom/libasn1c/libasn1c_git.bb M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb M

[PATCH] meta-telephony[201705]: osmo-bsc: Split bs11-utils into its own package

2018-03-27 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7534 osmo-bsc: Split bs11-utils into its own package Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b --- M recipes-osmocom/osmo-bsc/osmo-bsc.inc 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony

[PATCH] meta-telephony[201705]: osmo-bsc: Split abisip-find into its own package

2018-03-27 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7535 osmo-bsc: Split abisip-find into its own package Change-Id: I9de9b676502370c2dcd0fb9d54b25884d4110af5 --- M recipes-osmocom/osmo-bsc/osmo-bsc.inc 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony

meta-telephony[201705]: osmocom: Update recipes to latest master

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 I build tested this branch. It has also been working fine while running in laforge/nightly (next commits are cherry-picked from it as components are upgraded in here). -- To view, visit https://gerrit.osmocom.org/7533 To unsubscribe, visit

meta-telephony[201705]: osmo-bsc: Split bs11-utils into its own package

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7534 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: osmo-bsc: Split meas-utils into its own package

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7536 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b33dbdf882394fa14270c34306dccf46b724e4 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: osmo-bsc: Split abisip-find into its own package

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7535 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de9b676502370c2dcd0fb9d54b25884d4110af5 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

[MERGED] osmo-ttcn3-hacks[master]: deps: Switch to our own fork of the M3UA ProtocolEmulation

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: deps: Switch to our own fork of the M3UA ProtocolEmulation .. deps: Switch to our own fork of the M3UA ProtocolEmulation .. as we have some patches that

[PATCH] osmo-ttcn3-hacks[master]: deps: Switch to our own fork of the M3UA ProtocolEmulation

2018-03-27 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7537 to look at the new patch set (#2). deps: Switch to our own fork of the M3UA ProtocolEmulation .. as we have some patches that are not yet in upstream Change-Id:

meta-telephony[201705]: osmocom: Update recipes to latest master

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: I also did some running tests in my sysmobts a few days ago and everything was fine. -- To view, visit https://gerrit.osmocom.org/7533 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-ttcn3-hacks[master]: deps: Switch to our own fork of the M3UA ProtocolEmulation

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a9380ae8838c571fe3d0776f60485b34c85d4e Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: deps: Switch to our own fork of the M3UA ProtocolEmulation

2018-03-27 Thread Harald Welte
Review at https://gerrit.osmocom.org/7537 deps: Switch to our own fork of the M3UA ProtocolEmulation .. as we have some patches that are not yet in upstream Change-Id: Ie8a9380ae8838c571fe3d0776f60485b34c85d4e --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull

osmo-ttcn3-hacks[master]: deps: Switch to our own fork of the M3UA ProtocolEmulation

2018-03-27 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a9380ae8838c571fe3d0776f60485b34c85d4e Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

meta-telephony[201705]: osmocom: Update recipes to latest master

2018-03-27 Thread Pau Espin Pedrol
Patch Set 1: TODO: once this is merged: - meta-telephony: rebase laforge/nightly on top of updated 201705. - meta-sysmocom-bsp: merge local brnach pespin/new-release into 201705. - meta-sysmocom-bsp: rebase laforge/nightly on top of updated 201705. -- To view, visit

[PATCH] osmo-ttcn3-hacks[master]: deps/Makefile: Various updates

2018-03-27 Thread Harald Welte
Review at https://gerrit.osmocom.org/7538 deps/Makefile: Various updates * SCCP changes were merged upstream, we don't need to use osmocom fork * SCCP upstream now has proper tag based version * M3UA now has a new version tag (with Routing Context) * UNIX_DOMAIN_SOCKET has new verison tag

[PATCH] osmo-ttcn3-hacks[master]: deps/Makefile: Add missing "git fetch" to /update and /clean...

2018-03-27 Thread Harald Welte
Review at https://gerrit.osmocom.org/7539 deps/Makefile: Add missing "git fetch" to /update and /clean targets When the Makefile was modified to use a new tag/hash of a given repo, the "make update" or "make clean" target will fail as the new version/tag is not yet known to the local repo,

osmo-ttcn3-hacks[master]: deps/Makefile: Add missing "git fetch" to /update and /clean...

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7539 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c44c744674cd4dab0c85086d68bde6f9be1fca Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: deps/Makefile: Various updates

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: deps/Makefile: Various updates .. deps/Makefile: Various updates * SCCP changes were merged upstream, we don't need to use osmocom fork * SCCP upstream

[MERGED] osmo-ttcn3-hacks[master]: deps/Makefile: Add missing "git fetch" to /update and /clean...

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: deps/Makefile: Add missing "git fetch" to /update and /clean targets .. deps/Makefile: Add missing "git fetch" to /update and /clean targets When the

osmo-sip-connector[master]: osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCC

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7532 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c7868bda2195e5e67b2db5824caee8fbfb5a3b6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sip-connector Gerrit-Branch:

[MERGED] meta-telephony[201705]: osmocom: Update recipes to latest master

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom: Update recipes to latest master .. osmocom: Update recipes to latest master Change-Id: Ie68fc98ff09491f159535c555d8cf590f7a3401c --- M

[MERGED] meta-telephony[201705]: osmo-bsc: Split bs11-utils into its own package

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc: Split bs11-utils into its own package .. osmo-bsc: Split bs11-utils into its own package Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b

[MERGED] osmo-sip-connector[master]: osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCC

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCC .. osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCC In Change-Id

meta-telephony[201705]: osmo-bsc: Split meas-utils into its own package

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7536 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b33dbdf882394fa14270c34306dccf46b724e4 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

[MERGED] meta-telephony[201705]: osmo-bsc: Split abisip-find into its own package

2018-03-27 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc: Split abisip-find into its own package .. osmo-bsc: Split abisip-find into its own package Change-Id:

meta-telephony[201705]: osmo-bsc: Split abisip-find into its own package

2018-03-27 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7535 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de9b676502370c2dcd0fb9d54b25884d4110af5 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

  1   2   >