libosmocore[master]: fix issue on big endian architecture

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7666 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a09d2d8ccf155e70a3977ae1747758b6bc5125e Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #81

See -- [...truncated 3.68 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

[PATCH] osmocom-bb[master]: host/trxcon: track talloc NULL contexts by default

Review at https://gerrit.osmocom.org/7669 host/trxcon: track talloc NULL contexts by default In order to be able to introspect not only the root application context, but also all other contexts, e.g. allocated within libosmocore or other libraries, let's enable tracking the use of NULL

[PATCH] osmocom-bb[master]: host/trxcon: don't free root talloc context

Review at https://gerrit.osmocom.org/7668 host/trxcon: don't free root talloc context This is useless, and prevents us from finding potential memory leaks at exit. Let's print talloc report instead of that. Change-Id: Ibf04942070d654e97c3ed77d69ab19e44602758c --- M src/host/trxcon/trxcon.c 1

[PATCH] osmocom-bb[master]: host/trxcon: use osmo_init_logging2()

Review at https://gerrit.osmocom.org/7667 host/trxcon: use osmo_init_logging2() The osmo_init_logging() doesn't allow to specify a talloc context for libosmocore logging subsystem, so this is why the new version was introduced. Let's use it. Change-Id:

[PATCH] osmo-trx[master]: configure.ac: Fix typo

Review at https://gerrit.osmocom.org/7671 configure.ac: Fix typo Unbreak git-version-gen when used with .tarball-version Change-Id: Id836c6822daf1f6835a8c869624b4b40dde47f3a --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx

libosmocore[master]: fix spelling

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7670/1//COMMIT_MSG Commit Message: Line 11: Signed-off-by: Thorsten Alteholz We don't use signed-off in osmocom -- To view, visit https://gerrit.osmocom.org/7670 To unsubscribe, visit

[PATCH] libosmocore[master]: fix spelling

Review at https://gerrit.osmocom.org/7670 fix spelling fix for some spelling issues found by lintian Signed-off-by: Thorsten Alteholz Change-Id: I69976ecae6939d9ff51bfe4ce7374890c6563b82 --- M src/gsm/ipa.c M src/sim/card_fs_sim.c M src/sim/card_fs_tetra.c 3 files

osmo-trx[master]: configure.ac: Fix typo

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7671 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id836c6822daf1f6835a8c869624b4b40dde47f3a Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

Jenkins build is back to normal : master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #342

See

[PATCH] osmo-msc[master]: VTY: add USSD processing back-end configuration

Review at https://gerrit.osmocom.org/7677 VTY: add USSD processing back-end configuration This change is a preparation for the upcoming remote USSD processing back-end support. It extends the VTY in order to allow one to choose preferred USSD handler. At the moment, the following handlers are

[PATCH] osmo-msc[master]: libmsc/ussd.c: cosmetic: correct logging level

Review at https://gerrit.osmocom.org/7675 libmsc/ussd.c: cosmetic: correct logging level Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9 --- M src/libmsc/ussd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/75/7675/1 diff

[PATCH] osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

Review at https://gerrit.osmocom.org/7674 libmsc/gsm_04_80.c: drop unused 'in_msg' argument Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b --- M include/osmocom/msc/gsm_04_80.h M src/libmsc/gsm_04_80.c M src/libmsc/ussd.c 3 files changed, 10 insertions(+), 13 deletions(-) git pull

[PATCH] osmo-msc[master]: ussd.h: cosmetic: move comment to a proper place

Review at https://gerrit.osmocom.org/7672 ussd.h: cosmetic: move comment to a proper place Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 --- M include/osmocom/msc/ussd.h 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc

[PATCH] osmo-msc[master]: ussd.h: cosmetic: use '#pragma once' include guard

Review at https://gerrit.osmocom.org/7673 ussd.h: cosmetic: use '#pragma once' include guard Change-Id: I0e78aa946b8e6bc7c31534751b2ee5c867bfd490 --- M include/osmocom/msc/ussd.h 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc

Build failed in Jenkins: master-osmo-bts » sysmo, superfemto_v3.0.1pre,default,osmocom-master-debian9 #478

See -- Started by upstream project "master-osmo-bts" build number 478 originally

Build failed in Jenkins: master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #344

See -- Started by upstream project "master-osmo-gmr" build number 344 originally caused by: Started by upstream

[PATCH] libosmocore[master]: add osmo_quote_str(), osmo_quote_str_buf() and test

add osmo_quote_str(),osmo_quote_str_buf() and test Rationale: with osmo_escape_str(), you get the escaped contents of the string, but not so graceful handling of NULL strings. The caller needs to quote it, and for NULL strings not quote it. osmo_quote_str() is like osmo_escape_str() but always

libosmocore[master]: GSUP: add USSD messages support according to 3GPP TS 09.02

Patch Set 3: Code-Review-1 Verified-1 Still WIP... -- To view, visit https://gerrit.osmocom.org/7600 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie17a78043a35fffbdd59e80fd2b2da39cce5e532 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore

Jenkins build is back to normal : master-osmo-bts » sysmo,superfemto_v3.0.1pre,default,osmocom-master-debian9 #479

See

[PATCH] libosmocore[master]: fsm_test: terminate the main loop instead of exit on timeout

Review at https://gerrit.osmocom.org/7679 fsm_test: terminate the main loop instead of exit on timeout In fsm_test.c, we have FSM instance cleanup after the select main loop, but we exit(0) in the timer cb; hence the final code is never called. Rather clean up the instance and hence also test

[PATCH] libosmocore[master]: fsm_test: more thoroughly test FSM inst ids and names

Review at https://gerrit.osmocom.org/7681 fsm_test: more thoroughly test FSM inst ids and names Place id and name testing in its separate section, test_id_api(). Add a test that actually allocates an FSM instance with a NULL id, which is allowed, but uncovers a bug of an unset FSM instance

[PATCH] libosmocore[master]: add gsm48_reject_value_names

Review at https://gerrit.osmocom.org/7683 add gsm48_reject_value_names There seems to be quite some confusion / overlap between enum gsm48_reject_value, gsm48_gsm_cause and gsm48_gmm_cause. I tried to go with gsm48_gsm_cause_names[], but e.g. GSM48_REJECT_CONGESTION is not represented.

[PATCH] libosmocore[master]: cosmetic: osmo_fsm_inst_update_id(): don't log "allocate"

Review at https://gerrit.osmocom.org/7682 cosmetic: osmo_fsm_inst_update_id(): don't log "allocate" On erratic id in osmo_fsm_inst_update_id(), don't say "Attempting to allocate FSM instance". Escape the invalid id using osmo_quote_str(). Change-Id: I770fc460de21faa42b403f694e853e8da01c4bef

[PATCH] libosmocore[master]: osmo_fsm_inst_find_by_name(): guard against strcmp(NULL)

Review at https://gerrit.osmocom.org/7680 osmo_fsm_inst_find_by_name(): guard against strcmp(NULL) strcmp() *must not* be passed NULL pointers, or we hit: ../../../src/libosmocore/src/fsm.c:123:8: runtime error: null pointer passed as argument 2, which is declared to never be null

[PATCH] libosmocore[master]: add osmo_fsm_inst_update_id_f()

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7629 to look at the new patch set (#2). add osmo_fsm_inst_update_id_f() In the osmo-msc, I would like to set the subscr conn FSM identifier by a string format, to include the type of

[PATCH] libosmocore[master]: fsm: id: properly set name in case of NULL id

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7627 to look at the new patch set (#2). fsm: id: properly set name in case of NULL id Since alloc relies on osmo_fsm_inst_update_id() to set the name, never skip that. In

[ABANDON] libosmocore[master]: fsm: collapse an empty id to a NULL id, adjust api doc

Neels Hofmeyr has abandoned this change. Change subject: fsm: collapse an empty id to a NULL id, adjust api doc .. Abandoned Actually, currently we reject an empty id by osmo_valid_identifier() check, which is good, and we