[PATCH] osmo-bsc[master]: fix initialization of acc ramping

2018-04-09 Thread Stefan Sperling
fix initialization of acc ramping Remove a redundant call to acc_ramp_init() during bootstrap_bts(). ACC ramping state is already initialized during VTY config parsing, and bootstrap_bts() accidentally disabled ACC ramping again even if it was enabled in the configuration. This bug was

osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

2018-04-09 Thread Vadim Yanitskiy
Patch Set 2: About indenting style, personally I don't like this style. This occupies the potential space, that could be used for listing arguments, by useless spaces and tabs just in order to make the code look aligned... Also, some parts of this code are to be modified in the near future, so

libosmocore[master]: fix issue on big endian architecture

2018-04-09 Thread Harald Welte
Patch Set 1: thanks. I think however that there are *many* more big endian related problems all over the Osmocom code base. So I'd not be surprised if you run into all kinds of trouble on such systems (e.g. PPC, MIPS). Fixes are appreciated, but nobody of the core developers is using any

[MERGED] libosmocore[master]: fix issue on big endian architecture

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix issue on big endian architecture .. fix issue on big endian architecture OSMO_IS_LITTLE_ENDIAN is always defined and has a value of either 0 or 1 as

meta-telephony[201705]: openbsc: enable smpp

2018-04-09 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7659 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20c77346e4894d6d146863fd79f6d27ef12cb3ee Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

osmo-msc[master]: libmsc/ussd.c: cosmetic: correct logging level

2018-04-09 Thread Harald Welte
Patch Set 2: > The MS is getting rejected in such cases. what do you mean with "the MS is rejected"? do we send a proper error message, as required by the relevant spec (typically the "procedures" part) in case of the MS sending a message the MSC doesn't understand? -- To view, visit

Jenkins build is back to normal : master-osmo-bts » lc15,origin/nrw/litecell15-next,default,osmocom-master-debian9 #488

2018-04-09 Thread jenkins
See

[MERGED] osmo-ttcn3-hacks[master]: update expected HLR test results to prevent unexpected 'pass'

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: update expected HLR test results to prevent unexpected 'pass' .. update expected HLR test results to prevent unexpected 'pass' With

osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7674 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] openbsc[master]: fix initialization of acc ramping

2018-04-09 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7692 fix initialization of acc ramping Remove a redundant call to acc_ramp_init() during bootstrap_bts(). ACC ramping state is already initialized during VTY config parsing, and bootstrap_bts() accidentally disabled ACC ramping again even if it was enabled

[MERGED] libosmocore[master]: add gsm48_reject_value_names

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: add gsm48_reject_value_names .. add gsm48_reject_value_names There seems to be quite some confusion / overlap between enum gsm48_reject_value,

[MERGED] libosmocore[master]: add osmo_quote_str(), osmo_quote_str_buf() and test

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: add osmo_quote_str(),osmo_quote_str_buf() and test .. add osmo_quote_str(),osmo_quote_str_buf() and test Rationale: with osmo_escape_str(), you get the

osmo-msc[master]: VTY: add USSD processing back-end configuration

2018-04-09 Thread Harald Welte
Patch Set 2: I think this may end up being too inflexible. For MNCC, it makes sense to distinguish between "internal" and "external socket": Both can deal with voice calls to all (reachable) subscribers. For SMS, we have any number of ESMEs, and we can configure prefix-based matches to look

osmo-msc[master]: ussd.h: cosmetic: remove useless comment

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: DTAP: Ensure proper DLCI is used in MSC-originated DTAP

2018-04-09 Thread Harald Welte
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7690 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If511b20f52575054cab1346d99a8cb68d827fdbf Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

Build failed in Jenkins: master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #349

2018-04-09 Thread jenkins
See -- Started by upstream project "master-osmo-gmr" build number 349 originally caused by: Started by upstream

osmo-bsc[master]: fix initialization of acc ramping

2018-04-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7691 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d99c9d3d5d424e21bb7710f719c42f9aef3e95 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

openbsc[master]: fix initialization of acc ramping

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7692 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5834fd953e65b8453dee0a7751d5a4cae12be83a Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

osmo-msc[master]: ussd.h: cosmetic: remove useless comment

2018-04-09 Thread Vadim Yanitskiy
Patch Set 2: > we put comments for functions typically in the .c file, by the > implementation of the function. .h files are usually plain listings > of the API without comments. Neels, ok, removed. -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit

osmo-msc[master]: VTY: add USSD processing back-end configuration

2018-04-09 Thread Vadim Yanitskiy
Patch Set 2: > Let's call it "internal", not " local", to use the same naming as > for mncc handlers Done. Also I've updated the configuration examples. -- To view, visit https://gerrit.osmocom.org/7677 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

2018-04-09 Thread Harald Welte
Patch Set 1: > About indenting style, personally I don't like this style. [..] Everyone of course has their own preference, and everyone is entitled to have that. However, in any software project it is generally good if there is a common style to be followed by all the code, as it enhances

osmo-msc[master]: Permit any Sender MSISDN when sending SMS from VTY

2018-04-09 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7694 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62b17e0a67989484415f0df2c8cb4ff1f94dbf2b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-bsc[master]: fix a format string error in bts_update_t3122_chan_load()

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7687 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09bb519e68886e650647b1369fd49d1964e76c7e Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] openbsc[master]: fix a format string error in bts_update_t3122_chan_load()

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix a format string error in bts_update_t3122_chan_load() .. fix a format string error in bts_update_t3122_chan_load() In a debug log message, an

openbsc[master]: fix a format string error in bts_update_t3122_chan_load()

2018-04-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7693 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia29feec023117734e4f50ae3487871e715821fed Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

osmo-ttcn3-hacks[master]: update expected HLR test results to prevent unexpected 'pass'

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7686 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8cfbef5a0adcb927917b0623f89309479a60001 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-bsc[master]: fix a format string error in bts_update_t3122_chan_load()

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix a format string error in bts_update_t3122_chan_load() .. fix a format string error in bts_update_t3122_chan_load() In a debug log message, an

[MERGED] libosmocore[master]: fsm_test: terminate the main loop instead of exit on timeout

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fsm_test: terminate the main loop instead of exit on timeout .. fsm_test: terminate the main loop instead of exit on timeout In fsm_test.c, we have FSM

[MERGED] libosmocore[master]: fsm_test: more thoroughly test FSM inst ids and names

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fsm_test: more thoroughly test FSM inst ids and names .. fsm_test: more thoroughly test FSM inst ids and names Place id and name testing in its

[MERGED] libosmocore[master]: osmo_fsm_inst_find_by_name(): guard against strcmp(NULL)

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: osmo_fsm_inst_find_by_name(): guard against strcmp(NULL) .. osmo_fsm_inst_find_by_name(): guard against strcmp(NULL) strcmp() *must not* be passed NULL

[MERGED] libosmocore[master]: fsm: id: properly set name in case of NULL id

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fsm: id: properly set name in case of NULL id .. fsm: id: properly set name in case of NULL id Since alloc relies on osmo_fsm_inst_update_id() to set

[MERGED] libosmocore[master]: cosmetic: osmo_fsm_inst_update_id(): don't log "allocate"

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: cosmetic: osmo_fsm_inst_update_id(): don't log "allocate" .. cosmetic: osmo_fsm_inst_update_id(): don't log "allocate" On erratic id in

[MERGED] libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: add osmo_fsm_inst_update_id_f() .. add osmo_fsm_inst_update_id_f() In the osmo-msc, I would like to set the subscr conn FSM identifier by a string

[PATCH] osmo-msc[master]: Permit any Sender MSISDN when sending SMS from VTY

2018-04-09 Thread Harald Welte
Review at https://gerrit.osmocom.org/7694 Permit any Sender MSISDN when sending SMS from VTY In the old days, OsmoNITB couldn't process any SMS that wasn't between two subscribers on the same NITB. We've long re-worked the internals in order to process SMS with arbitrary sender MSISDN (e.g.

[MERGED] meta-telephony[201705]: openbsc: remove c-ares dependency

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: openbsc: remove c-ares dependency .. openbsc: remove c-ares dependency Since openbsc ed03661871ac8ee1715c04390d25631537b084ac, the c-ares dependency has

meta-telephony[201705]: openbsc: remove c-ares dependency

2018-04-09 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7660 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bee6e0132252d0e5adc3517908dcf05021547ea Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

[MERGED] meta-telephony[201705]: openbsc: enable smpp

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: openbsc: enable smpp .. openbsc: enable smpp libsmpp34 was listed in DEPENDS but it's use was not enabled. Change-Id:

[PATCH] osmo-bsc[master]: fix initialization of acc ramping

2018-04-09 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7691 fix initialization of acc ramping Remove a redundant call to acc_ramp_init() during bootstrap_bts(). ACC ramping state is already initialized during VTY config parsing, and bootstrap_bts() accidentally disabled ACC ramping again even if it was enabled

Build failed in Jenkins: master-osmo-bts » lc15, origin/nrw/litecell15-next,default,osmocom-master-debian9 #487

2018-04-09 Thread jenkins
See -- [...truncated 87.56 KB...] checking for suffix of object files... o

Jenkins build is back to normal : master-osmo-hlr » a1=default,a2=default,a3=default,osmocom-master-debian9 #433

2018-04-09 Thread jenkins
See

[PATCH] openbsc[master]: fix initialization of acc ramping

2018-04-09 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7692 to look at the new patch set (#2). fix initialization of acc ramping Remove a redundant call to acc_ramp_init() during bootstrap_bts(). ACC ramping state is already initialized during

osmo-bsc[master]: fix initialization of acc ramping

2018-04-09 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7691 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d99c9d3d5d424e21bb7710f719c42f9aef3e95 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

openbsc[master]: fix initialization of acc ramping

2018-04-09 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7692 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5834fd953e65b8453dee0a7751d5a4cae12be83a Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #82

2018-04-09 Thread jenkins
See -- [...truncated 3.69 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Build failed in Jenkins: master-osmo-hlr » a1=default,a2=default,a3=default,osmocom-master-debian9 #432

2018-04-09 Thread jenkins
See -- [...truncated 27.08 KB...] checking for objdir... .libs checking if gcc supports -fno-rtti

[PATCH] openbsc[master]: fix a format string error in bts_update_t3122_chan_load()

2018-04-09 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7693 fix a format string error in bts_update_t3122_chan_load() In a debug log message, an unsigned 64-bit value was printed with %lu but it should be printed with PRIu64 from inttypes.h instead. Port of osmo-bsc commit

openbsc[master]: fix a format string error in bts_update_t3122_chan_load()

2018-04-09 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7693 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia29feec023117734e4f50ae3487871e715821fed Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: improve failure diagnostics in TC_vty_msisdn_isd HLR test

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: improve failure diagnostics in TC_vty_msisdn_isd HLR test .. improve failure diagnostics in TC_vty_msisdn_isd HLR test Check for reception of an Insert

osmo-ttcn3-hacks[master]: improve failure diagnostics in TC_vty_msisdn_isd HLR test

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7684 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0809617cca621cc22f29b078828057fd49f27e5 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

libosmocore[master]: fix issue on big endian architecture

2018-04-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7666 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a09d2d8ccf155e70a3977ae1747758b6bc5125e Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-msc[master]: libmsc/ussd.c: cosmetic: correct logging level

2018-04-09 Thread Harald Welte
Patch Set 2: My point is that we're actually reporting a parser error here, not an "unhandled message". "unhandled" sounds to me like "unhandled because there's no USSD code present". -- To view, visit https://gerrit.osmocom.org/7675 To unsubscribe, visit https://gerrit.osmocom.org/settings

[MERGED] openbsc[master]: fix initialization of acc ramping

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix initialization of acc ramping .. fix initialization of acc ramping Remove a redundant call to acc_ramp_init() during bootstrap_bts(). ACC ramping

[MERGED] osmo-bsc[master]: fix initialization of acc ramping

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix initialization of acc ramping .. fix initialization of acc ramping Remove a redundant call to acc_ramp_init() during bootstrap_bts(). ACC ramping

osmo-msc[master]: ussd.h: cosmetic: move comment to a proper place

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: we put comments for functions typically in the .c file, by the implementation of the function. .h files are usually plain listings of the API without comments. -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/7674/1/include/osmocom/msc/gsm_04_80.h File include/osmocom/msc/gsm_04_80.h: Line 10:const char* response_text, const struct ss_request *req); (I would rather keep the same indenting style as below, and for added

osmo-hlr[master]: notify GSUP clients when HLR subscriber information changes

2018-04-09 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7685/1/src/hlr.c File src/hlr.c: Line 49: /* Trigger 'Insert Subscriber Data' messages to all connected GSUP clients. to all GSUP clients is ok for now, as we only expect a single MSC+SGSN to be connected. However, in larger scale

[PATCH] osmo-ttcn3-hacks[master]: WIP: SMPP codec for TITAN

2018-04-09 Thread Harald Welte
Review at https://gerrit.osmocom.org/7695 WIP: SMPP codec for TITAN Change-Id: Ib1952ffa0cbc915ab4c088da03fec2da4258b47c --- A library/SMPP_Types.ttcn 1 file changed, 520 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/7695/1 diff

[PATCH] osmo-ttcn3-hacks[master]: msc: Initial SMS testing (MO + MT SMS, successful case, no S...

2018-04-09 Thread Harald Welte
Review at https://gerrit.osmocom.org/7698 msc: Initial SMS testing (MO + MT SMS, successful case, no SMPP) Change-Id: I707330454ffab87daebf22ba83e6ba2873996424 --- M library/L3_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 3 files changed, 502 insertions(+), 3

[MERGED] osmo-msc[master]: Permit any Sender MSISDN when sending SMS from VTY

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Permit any Sender MSISDN when sending SMS from VTY .. Permit any Sender MSISDN when sending SMS from VTY In the old days, OsmoNITB couldn't process any

osmo-msc[master]: Permit any Sender MSISDN when sending SMS from VTY

2018-04-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7694 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62b17e0a67989484415f0df2c8cb4ff1f94dbf2b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: DTAP: Ensure proper DLCI is used in MSC-originated DTAP

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: DTAP: Ensure proper DLCI is used in MSC-originated DTAP .. DTAP: Ensure proper DLCI is used in MSC-originated DTAP The DLCI field of the DTAP header

[MERGED] osmo-ttcn3-hacks[master]: msc: generate mobile identity inside f_establish_fully()

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: generate mobile identity inside f_establish_fully() .. msc: generate mobile identity inside f_establish_fully() This reduces the code duplication

osmo-ttcn3-hacks[master]: L3_Templates: Introudce constants for tiFlag

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7696 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic06eb2016eb9979b8556366e4a909f3c0336aa92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-msc[master]: DTAP: Ensure proper DLCI is used in MSC-originated DTAP

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7690 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If511b20f52575054cab1346d99a8cb68d827fdbf Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: libmsc/ussd.c: cosmetic: correct log level and message

2018-04-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: libmsc/ussd.c: cosmetic: correct log level and message .. libmsc/ussd.c: cosmetic: correct log level and message Change-Id:

osmo-msc[master]: libmsc/ussd: don't overwrite rc if decoding failed

2018-04-09 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7676 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344e4b3a9aad617686a7ddbdeae5780fd8b07e58 Gerrit-PatchSet: 4 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] libosmocore[master]: GSUP: implement simple session management support

2018-04-09 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7700 GSUP: implement simple session management support Unlike TCAP/MAP, GSUP is just a transport layer without the dialogue/context. This makes impossible to have a session based communication (e.g. USSD) over GSUP. This change introduces two new IEs: -

[PATCH] libosmocore[master]: GSUP: add USSD messages support according to 3GPP TS 09.02

2018-04-09 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7600 to look at the new patch set (#4). GSUP: add USSD messages support according to 3GPP TS 09.02 In order to be able to transfer USSD messages via GSUP, this change

[ABANDON] osmo-ttcn3-hacks[master]: WIP: SMPP codec for TITAN

2018-04-09 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: WIP: SMPP codec for TITAN .. Abandoned Ericsson has released a complete SMPP codec. no need to reinvent the wheel. -- To view, visit https://gerrit.osmocom.org/7695 To

osmo-ttcn3-hacks[master]: msc: generate mobile identity inside f_establish_fully()

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7697 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa071b131a8ff372d70677c8622d227f88e9ea53 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: L3_Templates: Introudce constants for tiFlag

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: L3_Templates: Introudce constants for tiFlag .. L3_Templates: Introudce constants for tiFlag ... this makes the code more readable/understandable.

osmo-msc[master]: libmsc/ussd.c: cosmetic: correct log level and message

2018-04-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7675 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: msc: generate mobile identity inside f_establish_fully()

2018-04-09 Thread Harald Welte
Review at https://gerrit.osmocom.org/7697 msc: generate mobile identity inside f_establish_fully() This reduces the code duplication in every caller of the function. Change-Id: Iaa071b131a8ff372d70677c8622d227f88e9ea53 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed,

[PATCH] osmo-ttcn3-hacks[master]: L3_Templates: Introudce constants for tiFlag

2018-04-09 Thread Harald Welte
Review at https://gerrit.osmocom.org/7696 L3_Templates: Introudce constants for tiFlag ... this makes the code more readable/understandable. Change-Id: Ic06eb2016eb9979b8556366e4a909f3c0336aa92 --- M library/L3_Templates.ttcn M msc/gen_links.sh M msc/regen_makefile.sh 3 files changed, 29

[PATCH] osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

2018-04-09 Thread Vadim Yanitskiy
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7674 to look at the new patch set (#3). libmsc/gsm_04_80.c: drop unused 'in_msg' argument It isn't used, so no need to pass it. Change-Id:

[PATCH] osmo-msc[master]: libmsc/ussd: don't overwrite rc if decoding failed

2018-04-09 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7676 to look at the new patch set (#3). libmsc/ussd: don't overwrite rc if decoding failed Change-Id: I344e4b3a9aad617686a7ddbdeae5780fd8b07e58 --- M src/libmsc/ussd.c 1 file

[PATCH] osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7699 libmsc/ussd: implement basic USSD session management During some long period, including the OpenBSC time, the USSD processing code was (and still is) pretty trivial, so there was no transaction management, nor connection reference counting. Meanwhile,

osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (15 comments) https://gerrit.osmocom.org/#/c/7699/1/include/osmocom/msc/ussd.h File include/osmocom/msc/ussd.h: Line 33:struct gsm_trans *trans; a gsm_trans always belongs to a conn. Do you really need a separate conn pointer? Can there be a valid

osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7699/1/src/libmsc/ussd.c File src/libmsc/ussd.c: Line 129: OSMO_ASSERT(session); > if we pass a NULL in here, osmo-msc would crash on the assert, taking down btw, I made the same mistake recently and you hit that in OS#3125 --

osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7699/1/tests/msc_vlr/msc_vlr_test_authen_reuse.err File tests/msc_vlr/msc_vlr_test_authen_reuse.err: Line 263: DCC (ti 08 sub MSISDN:42342 callref 0) New transaction > read above three log lines. the first two have incomplete or no

osmo-ttcn3-hacks[master]: msc: Initial SMS testing (MO + MT SMS, successful case, no S...

2018-04-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7698 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707330454ffab87daebf22ba83e6ba2873996424 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: msc: Initial SMS testing (MO + MT SMS, successful case, no S...

2018-04-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: Initial SMS testing (MO + MT SMS, successful case, no SMPP) .. msc: Initial SMS testing (MO + MT SMS, successful case, no SMPP) Change-Id:

[PATCH] osmo-bts[master]: WIP: l1_utils: increase size of octphy_cid_vals[] to 51

2018-04-09 Thread dexter
Review at https://gerrit.osmocom.org/7701 WIP: l1_utils: increase size of octphy_cid_vals[] to 51 *** WORK IN PROGRESS: DO NOT MERGE UNTIL CHECKED BACK WITH OCTASIC *** The size of the array octphy_cid_vals[] is currently set to 37, which also matches the amount of elements defined in

[PATCH] osmo-msc[master]: cosmetic: embed compl_l3_type in FSM id

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7708 cosmetic: embed compl_l3_type in FSM id In the subscr_conn_fsm instance's ID, include the Complete Layer 3 type, so that we can see on the first glance whether a state transition belongs to MO or MT. The huge patch is due to the cosmetic change

[PATCH] osmo-msc[master]: msc conn ref counts: log human readable list of conn owners

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7710 msc conn ref counts: log human readable list of conn owners Change-Id: I2a09efafbdbdde0399238f7d79feea8612605201 --- M src/libmsc/osmo_msc.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M

[PATCH] osmo-msc[master]: trans_free: drop bad assertion

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7702 trans_free: drop bad assertion I assumed that trans_free() would always be called before freeing the FSM. But the actual conn free dance that tries to make sure a release is triggered from all directions actually may run into a situation where conn->fi

[PATCH] osmo-msc[master]: fix BSC Clear Request

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7707 fix BSC Clear Request On receiving a Clear Request, don't send a Clear Command "out of band", let the FSM do the release handling by invoking msc_subscr_conn_mo_close(). Fixes: ttcn3 MSC_Tests.TC_lu_clear_request Change-Id:

[PATCH] osmo-msc[master]: CC: intentionally release T308 on BSSMAP Clear Request from BSC

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7704 CC: intentionally release T308 on BSSMAP Clear Request from BSC So far we hit a running T308 during CC release when caused by a BSSMAP Clear Request, and we loudly log that as error. However, now I understand that T308 is a direct cause of the

[PATCH] osmo-msc[master]: refactor subscr_conn and subscr_conn_fsm de-/alloc

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7705 refactor subscr_conn and subscr_conn_fsm de-/alloc Refactor: 1. Glue the gsm_subscriber_connection alloc to the subscr_conn_fsm. 2. Add separate AUTH_CIPH state to the FSM. 3. Use conn->use_count to trigger conn release. 4. Add separate RELEASING

[PATCH] osmo-msc[master]: msc_vlr_test_call: reproduce OS#3062

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7703 msc_vlr_test_call: reproduce OS#3062 Change-Id: Ice7197b48d4e163a3c4d97b559fdcd7e88c4107e --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_tests.c M tests/msc_vlr/msc_vlr_tests.h 4 files changed, 436

osmo-msc[master]: msc_vlr_test_call: reproduce OS#3062

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: note related ttcn3 test: https://gerrit.osmocom.org/7712 -- To view, visit https://gerrit.osmocom.org/7703 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7197b48d4e163a3c4d97b559fdcd7e88c4107e Gerrit-PatchSet: 1

[PATCH] osmo-ttcn3-hacks[master]: MNCC: don't delete call table entries

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7711 MNCC: don't delete call table entries If we receive an MNCC_REL_ind, we still may want to reply with an MNCC_REL_cnf. If the REL_ind, however, already drops the call table entry, all I get is: "MNCC Call table not found by MNCC Call ID " The call

[PATCH] osmo-ttcn3-hacks[master]: msc: add TC_mo_cc_bssmap_clear to catch OS#3062

2018-04-09 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7712 msc: add TC_mo_cc_bssmap_clear to catch OS#3062 The test currently crashes osmo-msc, which is fixed by I5c30e0f9545fb76615776ff6cc16b56aeb5b043a (osmo-msc). Related: OS#3062 Change-Id: Ic80646e1fba37bb6163ca3a7eead7980b4ad7a51 --- M msc/MSC_Tests.ttcn

[PATCH] osmo-msc[master]: msc_vlr_test_call: reproduce OS#3062

2018-04-09 Thread Neels Hofmeyr
msc_vlr_test_call: reproduce OS#3062 A related ttcn3 test is added in Ic80646e1fba37bb6163ca3a7eead7980b4ad7a51 Related: OS#3062 Change-Id: Ice7197b48d4e163a3c4d97b559fdcd7e88c4107e --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_tests.c M

[PATCH] osmo-msc[master]: refactor subscr_conn and subscr_conn_fsm de-/alloc

2018-04-09 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7705 to look at the new patch set (#2). refactor subscr_conn and subscr_conn_fsm de-/alloc Refactor: 1. Glue the gsm_subscriber_connection alloc to the subscr_conn_fsm. 2. Add separate

[PATCH] osmo-msc[master]: CC: intentionally release T308 on BSSMAP Clear Request from BSC

2018-04-09 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7704 to look at the new patch set (#2). CC: intentionally release T308 on BSSMAP Clear Request from BSC So far we hit a running T308 during CC release when caused by a BSSMAP Clear Request,

osmo-msc[master]: msc_vlr_test_call: reproduce OS#3062

2018-04-09 Thread Neels Hofmeyr
Patch Set 2: Verified+1 add V+1 manually, the jenkins result wasn't counted -- To view, visit https://gerrit.osmocom.org/7703 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7197b48d4e163a3c4d97b559fdcd7e88c4107e Gerrit-PatchSet: 2

osmo-msc[master]: VTY: add USSD processing back-end configuration

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7677/1/src/osmo-msc/msc_main.c File src/osmo-msc/msc_main.c: Line 634: /* Initialize USSD */ > Probably, it's my bad habit to comment each code block... it's in many computer science syllabi as well: "comment every code block! even

osmo-msc[master]: libmsc/ussd.c: cosmetic: correct logging level

2018-04-09 Thread Vadim Yanitskiy
Patch Set 2: > My point is that we're actually reporting a parser error here, not > an "unhandled message". "unhandled" sounds to me like "unhandled > because there's no USSD code present". I am not the author of the original logging message. As I pointed out, the

osmo-msc[master]: libmsc/ussd.c: cosmetic: correct logging level

2018-04-09 Thread Vadim Yanitskiy
Patch Set 2: > > The MS is getting rejected in such cases. > > what do you mean with "the MS is rejected"? I mean that a GSM 04.80 message with REJECT component is sent. > do we send a proper > error message, as required by the relevant spec (typically the > "procedures" part) in case of

  1   2   >