osmo-ci[master]: add docker-cleanup.sh script

2018-04-10 Thread lynxis lazus
Patch Set 1: Code-Review+1 (2 comments) LGTM. Some nitpicks. https://gerrit.osmocom.org/#/c/7655/1/scripts/docker-cleanup.sh File scripts/docker-cleanup.sh: PS1, Line 4: ` nitpicks: shellcheck says: - $() instead of ``. `` are legacy - \^osmocom-build could be replaced with ^osmocom-build

osmo-hlr[master]: notify GSUP clients when HLR subscriber information changes

2018-04-10 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 (1 comment) about that FIXME, I think there should also be an issue about that, lest we forget the FIXME. https://gerrit.osmocom.org/#/c/7685/1/src/hlr.h File src/hlr.h: Line 42: struct hlr_subscriber; (we usually place opaque declarations like this after the

[MERGED] osmo-msc[master]: trans_free: drop bad assertion

2018-04-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: trans_free: drop bad assertion .. trans_free: drop bad assertion I assumed that trans_free() would always be called before freeing the FSM. But the

[MERGED] osmo-msc[master]: msc_vlr_test_call: reproduce OS#3062

2018-04-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: msc_vlr_test_call: reproduce OS#3062 .. msc_vlr_test_call: reproduce OS#3062 A related ttcn3 test is added in Ic80646e1fba37bb6163ca3a7eead7980b4ad7a51

osmo-ci[master]: add docker-cleanup.sh script

2018-04-10 Thread Harald Welte
Patch Set 1: i've merely attached the script we use in production on the non-ansible nodes. pleas take it from here. -- To view, visit https://gerrit.osmocom.org/7655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmocore[master]: deprecate PLMN de-/coding functions incapable of 3-digit MNC...

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7713 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55dfaf7ce74870de44120b26c42d45bb7b184341 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: avoid warning in gsm0808_create_layer3

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7714 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie098af4fc9640240196eda10fd61edcb3a872455 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread lynxis lazus
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7716 to look at the new patch set (#2). ansible: docker: cleanup old docker images Change-Id: I77fe38775b3f6055691bbf654de4019916b75fd7 --- M ansible/roles/docker/tasks/main.yml 1 file

osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7716 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77fe38775b3f6055691bbf654de4019916b75fd7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix fake_trx.py path

2018-04-10 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7715 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9931651d477dc95c561a5ed554d5360b465d4da Gerrit-PatchSet: 1 Gerrit-Project: docker-playground

[MERGED] docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix fake_trx.py path

2018-04-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: ttcn3-bts-test/jenkins.sh: fix fake_trx.py path .. ttcn3-bts-test/jenkins.sh: fix fake_trx.py path Change-Id: Ie9931651d477dc95c561a5ed554d5360b465d4da

osmo-ttcn3-hacks[master]: msc: add TC_mo_cc_bssmap_clear to catch OS#3062

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7712 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic80646e1fba37bb6163ca3a7eead7980b4ad7a51 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7716 ansible: docker: cleanup old docker images Change-Id: I77fe38775b3f6055691bbf654de4019916b75fd7 --- M ansible/roles/docker/tasks/main.yml 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

osmo-ttcn3-hacks[master]: MNCC: don't delete call table entries

2018-04-10 Thread Harald Welte
Patch Set 1: I don't like this, sorry :( After having lots of basic tests in place, it's very likely that we will start executing more of them in parallel in the near future, at which point 16 entries in the call table will very soon run out if they're not being cleaned up anymore. -- To

[PATCH] libosmocore[master]: deprecate PLMN de-/coding functions incapable of 3-digit MNC...

2018-04-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7713 deprecate PLMN de-/coding functions incapable of 3-digit MNC with leading zeros All our projects have seen patches to move to 3-digit MNC handling. Furthermore, since our builds no longer break from deprecation warnings, I shall no longer refrain from

[PATCH] libosmocore[master]: avoid warning in gsm0808_create_layer3

2018-04-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7714 avoid warning in gsm0808_create_layer3 Change-Id: Ie098af4fc9640240196eda10fd61edcb3a872455 --- M src/gsm/gsm0808.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/7714/1 diff

[PATCH] docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix fake_trx.py path

2018-04-10 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7715 ttcn3-bts-test/jenkins.sh: fix fake_trx.py path Change-Id: Ie9931651d477dc95c561a5ed554d5360b465d4da --- M ttcn3-bts-test/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground

osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+1 this is only once per night. We've seen this is insufficient on heavy activity on build nodes in the past. I think I wrote it somewhere already (redmine ticket?) that we need this more frequently, like every 6 or 12 hours -- To view, visit

[PATCH] osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread lynxis lazus
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7716 to look at the new patch set (#3). ansible: docker: cleanup old docker images Fixes: OS#3144 Change-Id: I77fe38775b3f6055691bbf654de4019916b75fd7 --- M ansible/roles/docker/tasks/main.yml

[PATCH] docker-playground[master]: add .gitreview

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7719 add .gitreview Allows `git review` to automatic setup gerrit Change-Id: I179c02d38496bf3d408020db7f0baf79ee064705 --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground

[PATCH] docker-playground[master]: Makefile: use $USER/image when depending on a generated image

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7720 Makefile: use $USER/image when depending on a generated image Te make scripts will generate docker images like "$username/foobar-test". When depending on an previous image, the $username must match or the build will about with image not found.

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #83

2018-04-10 Thread jenkins
See -- [...truncated 3.66 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

docker-playground[master]: add .gitreview

2018-04-10 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7719 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I179c02d38496bf3d408020db7f0baf79ee064705 Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch: master

[MERGED] osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: docker: cleanup old docker images .. ansible: docker: cleanup old docker images Fixes: OS#3144 Change-Id:

osmo-ci[master]: ansible: docker: cleanup old docker images

2018-04-10 Thread Harald Welte
Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7716 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77fe38775b3f6055691bbf654de4019916b75fd7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch:

[PATCH] osmo-ci[master]: jobs: update-osmo*: remove non-existent node build2-deb8build

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7718 jobs: update-osmo*: remove non-existent node build2-deb8build The jobs will stall when trying to handle a non-existent node Change-Id: Id9f25d8a5f6d0521e2b70884f46de5dee14d8092 --- M jobs/update-osmo-ci-on-slaves.yml M

[PATCH] osmo-ci[master]: jobs: update-osmo-* reformat a list to be human readable

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7717 jobs: update-osmo-* reformat a list to be human readable Change-Id: Ic64463d3974fdbf3967e67a77c75490d7ca80fb7 --- M jobs/update-osmo-ci-on-slaves.yml M jobs/update-osmo-python-on-slaves.yml 2 files changed, 20 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-bsc[master]: ensure that acc_ramp_init() is only called once

2018-04-10 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7723 ensure that acc_ramp_init() is only called once There are plans to register signal handlers in acc_ramp_init(). Once we do that, the acc_ramp_init() function should only be called once to avoid duplicate signal handlers on the handler list. However,

[PATCH] osmo-ci[master]: osmocom-jenkins-slave: call fstrim periodically

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7724 osmocom-jenkins-slave: call fstrim periodically Change-Id: I82c497f476abf43148e8d7c027f53b87b5a738fb --- M ansible/hosts M ansible/roles/osmocom-jenkins-slave/defaults/main.yml M ansible/roles/osmocom-jenkins-slave/tasks/main.yml 3 files changed, 13

osmo-ci[master]: osmocom-jenkins-slave: call fstrim periodically

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c497f476abf43148e8d7c027f53b87b5a738fb Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

docker-playground[master]: Makefile: use $USER/image when depending on a generated image

2018-04-10 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied42c3e1de9a2ffaca22ba4cd02e6a398e48e97d Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch: master

docker-playground[master]: Makefile: use $USER/image when depending on a generated image

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied42c3e1de9a2ffaca22ba4cd02e6a398e48e97d Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch:

docker-playground[master]: add .gitreview

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7719 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I179c02d38496bf3d408020db7f0baf79ee064705 Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch:

[PATCH] docker-playground[master]: jenkins-common: move workspace to /tmp/jenkins when build ou...

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7721 jenkins-common: move workspace to /tmp/jenkins when build outside jenkins When users building the scripts, the WORKSPACE variable must be set. Increase the overview of created folders and files by using a subdirectory in /tmp Change-Id:

[PATCH] osmo-gsm-manuals[master]: jenkins.sh: add hostkey for osmocom.org:48

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7725 jenkins.sh: add hostkey for osmocom.org:48 Otherwise it will depend on a setting this up in a seperate step. This way it's more decoupled from the build host. Change-Id: Iea1f5810bc7d4370724fdd7eb875c9a27b3d82af --- M contrib/jenkins.sh 1 file

Build failed in Jenkins: master-osmo-gsm-manuals » a1=default,a2=default,a3=default,admin2-deb9build #105

2018-04-10 Thread jenkins
See -- [...truncated 101.23 KB...] warning: failed to load external entity

osmo-gsm-manuals[master]: jenkins.sh: add hostkey for osmocom.org:48

2018-04-10 Thread lynxis lazus
Patch Set 1: required to move the build job to a new host. -- To view, visit https://gerrit.osmocom.org/7725 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea1f5810bc7d4370724fdd7eb875c9a27b3d82af Gerrit-PatchSet: 1 Gerrit-Project:

[PATCH] osmo-bsc[master]: only log actual access control class ramping changes

2018-04-10 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7722 only log actual access control class ramping changes Silence log messages about no-op changes to access granted to access control classes. For example, these always occur while configuration files are being loaded. Change-Id:

Jenkins build is back to normal : master-osmo-gsm-manuals » a1=default,a2=default,a3=default,admin2-deb9build #106

2018-04-10 Thread jenkins
See

osmo-hlr[master]: notify GSUP clients when HLR subscriber information changes

2018-04-10 Thread Stefan Sperling
Patch Set 2: > (1 comment) > > about that FIXME, I think there should also be an issue about that, > lest we forget the FIXME. https://osmocom.org/issues/3154 -- To view, visit https://gerrit.osmocom.org/7685 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

osmo-ci[master]: osmocom-jenkins-slave: install gsm-manual dependencies

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7726 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa60bd986220e065b1e9eca4308f2b089d505d9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: jobs: master-builds.yml: allow osmo-gsm-manuals to build any...

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7727 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fe39b643e7a15dbfd2efd55dce78dde30cf099 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-ci[master]: osmocom-jenkins-slave: install gsm-manual dependencies

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7726 osmocom-jenkins-slave: install gsm-manual dependencies Change-Id: I3fa60bd986220e065b1e9eca4308f2b089d505d9 --- M ansible/roles/osmocom-jenkins-slave/tasks/main.yml 1 file changed, 3 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-ci[master]: jobs: master-builds.yml: allow osmo-gsm-manuals to build any...

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7727 jobs: master-builds.yml: allow osmo-gsm-manuals to build anywhere When https://gerrit.osmocom.org/#/c/7725/ has been merged, there is no need to limit this build to OsmocomApi. Change-Id: Ic5fe39b643e7a15dbfd2efd55dce78dde30cf099 --- M

osmo-pcu[master]: pcu_l1_if: add frame number to log output

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7729 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idce994dbf86a2bbf861907d75418a2a3867244db Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: cosmetic: remove runaway semicolon

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7728 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33c335dc8d564a8357ffb5b1163c2c4b1a578b49 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-bsc[master]: trigger acc ramping based on trx rf-locked state

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7732 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4124f1da3dadec003de45c1da8435506ee8f0a34 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25bff85d9e5c277da76bffa11d31972e9fdc323 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester: move usrp tasks to gsm-tester-bts

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/7738/1/ansible/roles/gsm-tester-bts/tasks/main.yml File ansible/roles/gsm-tester-bts/tasks/main.yml: Line 18: name: "{{ item }}" where does item come from in here? -- To view, visit https://gerrit.osmocom.org/7738 To

osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-10 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7737 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47f578c4b9bb7b1dc81ccf93a7e82a335f6968a2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

2018-04-10 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7743 rewrite subscriber_update_notify() without calls into luop This function relied on implementation details of the luop code. Port what is necessary for an independent Insert Subscriber Data Tx operation from the luop code into this function. A next

[MERGED] osmo-hlr[master]: notify GSUP clients when HLR subscriber information changes

2018-04-10 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. Change subject: notify GSUP clients when HLR subscriber information changes .. notify GSUP clients when HLR subscriber information changes Add a function which

osmo-pcu[master]: tbf: hex output of tbf data in log

2018-04-10 Thread Harald Welte
Patch Set 1: not entirely sure if we want to do this... -- To view, visit https://gerrit.osmocom.org/7731 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c5adda8aaead00b1ba4359c34866e6842ea161f Gerrit-PatchSet: 1 Gerrit-Project:

osmo-pcu[master]: tbf: add frame number to log output

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7730 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a744dc5cd7c1de1baea13fffac026c83d091429 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[PATCH] osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: execute the job on a ttcn3 node

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7742 jobs: gerrit-osmo-ttcn3-hacks: execute the job on a ttcn3 node Only ttcn3 nodes have the eclipse-titan compiler installed Change-Id: If946af8fa3f7bd2d13914c9895d3f74b58fdef24 --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 1

osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7741/1/ansible/roles/gsm-tester-bts/files/Release.key File ansible/roles/gsm-tester-bts/files/Release.key: Line 1: -BEGIN PGP PUBLIC KEY BLOCK- I think it's better to download it from OBS as specified in the Night Builds wiki

docker-playground[master]: Makefile: use $USER/image when depending on a generated image

2018-04-10 Thread lynxis lazus
Patch Set 1: This is the last patch required to move nplab- to the new build slaves. -- To view, visit https://gerrit.osmocom.org/7720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied42c3e1de9a2ffaca22ba4cd02e6a398e48e97d

Build failed in Jenkins: master-osmo-gsm-manuals » a1=default,a2=default,a3=default,admin2-deb9build #104

2018-04-10 Thread jenkins
See -- Started by upstream project "master-osmo-gsm-manuals" build number 104 originally caused by: Started by

[ABANDON] osmo-gsm-tester[master]: WIP.. see what is executed? Where is cdf_test

2018-04-10 Thread Holger Freyther
Holger Freyther has abandoned this change. Change subject: WIP.. see what is executed? Where is cdf_test .. Abandoned helped to show misconfiguration of the gerrit job.. -- To view, visit https://gerrit.osmocom.org/7492 To

osmo-ci[master]: ansible: gsm-tester: install sispmctl to control usb power s...

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7740 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1af197d4b24e25196e10d2afa3ab8eea73ad729 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-modems: improve name

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7739 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4186baaf565442c96555b723622c93b1cbd9f4f7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-10 Thread lynxis lazus
Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7737/1/ansible/roles/gsm-tester-bts/tasks/main.yml File ansible/roles/gsm-tester-bts/tasks/main.yml: Line 9: name: python3-usb > why executable: pip3 is not defined here but it is below? this is a package via apt Line 11: - name:

[PATCH] osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-10 Thread lynxis lazus
ansible: setup-gsm-tester: use udhcpd as dhcp server Required for ip.access Change-Id: I5ae43ebcd3c87e625110d8ff6afa0476f4b1facf --- A ansible/host_vars/osmo-gsm-tester-prod.yml A ansible/host_vars/osmo-gsm-tester-rnd.yml M ansible/setup-gsm-tester.yml 3 files changed, 19 insertions(+), 0

osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-10 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7741 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b704d402c83db54401d1c06acb715cce821f2e4 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7741/1/ansible/roles/gsm-tester-bts/files/Release.key File ansible/roles/gsm-tester-bts/files/Release.key: Line 1: -BEGIN PGP PUBLIC KEY BLOCK- > I like to have an explicit downloaded Release.key or we could download it, Relying

osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-10 Thread lynxis lazus
Patch Set 2: here they are. Thanks! -- To view, visit https://gerrit.osmocom.org/7736 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae43ebcd3c87e625110d8ff6afa0476f4b1facf Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch:

[PATCH] osmo-pcu[master]: tbf: add frame number to log output

2018-04-10 Thread dexter
Review at https://gerrit.osmocom.org/7730 tbf: add frame number to log output Currently, the TBF timer log messages lack the frame number in the logoutput - Add frame number to TBF timer related log-statements Change-Id: I5a744dc5cd7c1de1baea13fffac026c83d091429 Related: SYS#4139 Patch-by:

[PATCH] osmo-pcu[master]: cosmetic: remove runaway semicolon

2018-04-10 Thread dexter
Review at https://gerrit.osmocom.org/7728 cosmetic: remove runaway semicolon Change-Id: I33c335dc8d564a8357ffb5b1163c2c4b1a578b49 Related: SYS#4139 Patch-by: Octasic inc. --- M src/pcu_l1_if.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu

[PATCH] osmo-pcu[master]: tbf: hex output of tbf data in log

2018-04-10 Thread dexter
Review at https://gerrit.osmocom.org/7731 tbf: hex output of tbf data in log The log text of tbf_dl.cpip and tbf_ul.cpp only displays the length of the actual tbf data but not the content, which might be useful for debugging. - log tbf data in gprs_rlcmac_dl_tbf::append_data() - log tbf data

[PATCH] osmo-pcu[master]: pcu_l1_if: add frame number to log output

2018-04-10 Thread dexter
Review at https://gerrit.osmocom.org/7729 pcu_l1_if: add frame number to log output Currently, the log output lacks the frame number. - make get_current_fn() public - add frame number to the log statements in pcu_l1_if.cpp Change-Id: Idce994dbf86a2bbf861907d75418a2a3867244db Related:

[PATCH] osmo-bsc[master]: trigger acc ramping based on trx rf-locked state

2018-04-10 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7732 trigger acc ramping based on trx rf-locked state Make ACC ramping listen to network management signals and trigger or abort ACC ramping based on the RF locked state of TRX 0. This works as expected with a virtphy setup when RF lock state is changed

osmo-gsm-tester[master]: WIP.. see what is executed? Where is cdf_test

2018-04-10 Thread lynxis lazus
Patch Set 1: @holger can please you abandon this review? -- To view, visit https://gerrit.osmocom.org/7492 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9cd27c9d2628ad1d001ec57f6c80c3690df9a86 Gerrit-PatchSet: 1 Gerrit-Project:

osmo-gsm-manuals[master]: jenkins.sh: add hostkey for osmocom.org:48

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7725 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea1f5810bc7d4370724fdd7eb875c9a27b3d82af Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

[PATCH] libosmo-abis[master]: configure.ac: Fix condition check for RTP_SIGNAL_PTR_CAST de...

2018-04-10 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7733 configure.ac: Fix condition check for RTP_SIGNAL_PTR_CAST define While building libosmo-netif on a system with an old ortp (0.22), it was seen that warning related to RTP_SIGNAL_PTR_CAST not being correctly selected were being printed. The compilation

osmo-ci[master]: jobs: update-osmo*: remove non-existent node build2-deb8build

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7718 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9f25d8a5f6d0521e2b70884f46de5dee14d8092 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-bsc[master]: only log actual access control class ramping changes

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37580f4058f6e3a21d338234b1e22ea46f9538c6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: ansible: add role udhcpd: setup a udhcpd server

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7735/1/ansible/roles/udhcpd/defaults/main.yml File ansible/roles/udhcpd/defaults/main.yml: Line 16: udhcpd_static_leases: [] we are missing the leases here? - label: NanoBTS-ONW-1900 type: nanobts ipa_unit_id: 9 addr: 10.42.42.53

osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7737/1/ansible/roles/gsm-tester-bts/tasks/main.yml File ansible/roles/gsm-tester-bts/tasks/main.yml: Line 9: name: python3-usb why executable: pip3 is not defined here but it is below? -- To view, visit

osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-10 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7736 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae43ebcd3c87e625110d8ff6afa0476f4b1facf Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-10 Thread lynxis lazus
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7741/1/ansible/roles/gsm-tester-bts/files/Release.key File ansible/roles/gsm-tester-bts/files/Release.key: Line 1: -BEGIN PGP PUBLIC KEY BLOCK- > I think it's better to download it from OBS as specified in the Night Build I like

osmo-bsc[master]: trigger acc ramping based on trx rf-locked state

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: I'll review them this night/tomorrow -- To view, visit https://gerrit.osmocom.org/7732 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4124f1da3dadec003de45c1da8435506ee8f0a34 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc

[PATCH] osmo-ci[master]: ansible: add role udhcpd: setup a udhcpd server

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7735 ansible: add role udhcpd: setup a udhcpd server Change-Id: Ia272ae9c2b245d0a06f84b91f50dd875d4488e02 --- A ansible/roles/udhcpd/README.md A ansible/roles/udhcpd/defaults/main.yml A ansible/roles/udhcpd/tasks/main.yml A

[PATCH] osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7736 ansible: setup-gsm-tester: use udhcpd as dhcp server Required for ip.access Change-Id: I5ae43ebcd3c87e625110d8ff6afa0476f4b1facf --- M ansible/setup-gsm-tester.yml 1 file changed, 9 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7737 ansible: gsm-tester-bts: install ip.access dependencies Change-Id: I47f578c4b9bb7b1dc81ccf93a7e82a335f6968a2 --- A ansible/roles/gsm-tester-bts/README.md A ansible/roles/gsm-tester-bts/tasks/main.yml 2 files changed, 17 insertions(+), 0 deletions(-)

[PATCH] osmo-ci[master]: ansible: gsm-tester-modems: improve name

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7739 ansible: gsm-tester-modems: improve name Use same scheme as of gsm-tester-bts. This should improve readability. Change-Id: I4186baaf565442c96555b723622c93b1cbd9f4f7 --- M ansible/roles/gsm-tester-modems/tasks/main.yml 1 file changed, 3 insertions(+),

[PATCH] osmo-ci[master]: ansible: gsm-tester: move usrp tasks to gsm-tester-bts

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7738 ansible: gsm-tester: move usrp tasks to gsm-tester-bts Change-Id: I9caebed94c3473051b82e2cdc35f6dfb9f862084 --- M ansible/roles/gsm-tester-bts/tasks/main.yml M ansible/roles/gsm-tester-modems/tasks/main.yml 2 files changed, 22 insertions(+), 22

[PATCH] osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7741 ansible: gsm-tester-bts: add OBS osmocom:nightly to install osmocom utilities Useful for admininistrators. Change-Id: I7b704d402c83db54401d1c06acb715cce821f2e4 --- A ansible/roles/gsm-tester-bts/files/Release.key M

[PATCH] osmo-ci[master]: ansible: gsm-tester: install sispmctl to control usb power s...

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7740 ansible: gsm-tester: install sispmctl to control usb power sockets Change-Id: Ie1af197d4b24e25196e10d2afa3ab8eea73ad729 --- M ansible/roles/gsm-tester/tasks/main.yml 1 file changed, 4 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-ci[master]: ansible: hosts: gsm-tester: use ansible_host to have more re...

2018-04-10 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7734 ansible: hosts: gsm-tester: use ansible_host to have more readable ansible output Change-Id: Ia7b60ace8afd0e2cc47c535da1856d4f34fdd735 --- M ansible/hosts 1 file changed, 2 insertions(+), 4 deletions(-) git pull

osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7736/1/ansible/setup-gsm-tester.yml File ansible/setup-gsm-tester.yml: Line 48: # udhcpd_static_leases is set via host_vars/* I don't see any file added in host_vars here adding support for the leases in prod. -- To view, visit

osmo-ci[master]: ansible: gsm-tester: move usrp tasks to gsm-tester-bts

2018-04-10 Thread lynxis lazus
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7738/1/ansible/roles/gsm-tester-bts/tasks/main.yml File ansible/roles/gsm-tester-bts/tasks/main.yml: Line 21: with_items: from here -- To view, visit https://gerrit.osmocom.org/7738 To unsubscribe, visit

osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7737/1/ansible/roles/gsm-tester-bts/tasks/main.yml File ansible/roles/gsm-tester-bts/tasks/main.yml: Line 11: - name: gsm-tester-bts | ip.access install pip3 dependencies > this is a package install via pip Indeed, sorry I didn't look

[PATCH] docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7744 ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble for handover tests. Set BSICs to 10, 11 and 12 (not 0,1,2 to mark the distinction from the cell_identity). It wasn't a

[PATCH] docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Neels Hofmeyr
ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble for handover tests. Set BSICs to 10, 11 and 12 (not 0,1,2 to mark the distinction from the cell_identity). It wasn't a problem so far since we cheated by passing the

[PATCH] osmo-ttcn3-hacks[master]: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7745 bsc cfg: fix ARFCN-BSIC collisions All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble for handover tests. Set BSICs to 10, 11 and 12 (not 0,1,2 to mark the distinction from the cell_identity). It wasn't a problem so far since

osmo-ttcn3-hacks[master]: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7745 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea8889ea40953f5a23eab40db52585556a410bc Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7744 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d Gerrit-PatchSet: 2 Gerrit-Project: docker-playground Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc cfg: fix ARFCN-BSIC collisions .. bsc cfg: fix ARFCN-BSIC collisions All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble

osmo-ci[master]: ansible: hosts: gsm-tester: use ansible_host to have more re...

2018-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7734 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b60ace8afd0e2cc47c535da1856d4f34fdd735 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester: install sispmctl to control usb power s...

2018-04-10 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7740 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1af197d4b24e25196e10d2afa3ab8eea73ad729 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

  1   2   >