libosmo-netif[master]: tests: jibuf_tool: Initial commit

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7774 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92307c8b1483dd488339771462290aae0ae5689a Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: tests: jibuf_tool: Add parameters to control size of buffer

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/ To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7fa39985f8d197e24c32cab80299aba2d03087 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: tests: jibuf_tool: Improve jibuf_test to read pcaps

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7775 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a13c823fb70e0adbc5fa0726fd66b15dc40014e Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: tests: jibuf_tool: Add OSMUX support

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7776 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f02da0329e6739ff340d31113161bb520b1b760 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: tests: jibuf_tool: Add seq.plt

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7780 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37bb3ab372b7ad7c3c1d09c8134827c932bf8bf8 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: jibuf: re-sync clock out of sync timestamps

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33556b33d7549654442d9bdd7f31128792506652 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: jibuf: Estimate src clock skew

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7781 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifae633d53107417a8e2f9b0f200d2711db72d199 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: jibuf: Take RTP marker into account

2018-04-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7778 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie142acfb45650e0af775f58226fd191beaf8178e Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

osmo-bsc[master]: inform A-RESET FSM about MSC CR timeouts

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7794 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836a552f2ad37c160081246579f842d104d0dd35 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] libosmocore[master]: test_gsm0808_enc_dec_cell_id_list_lac(): populate all LACs

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: test_gsm0808_enc_dec_cell_id_list_lac(): populate all LACs .. test_gsm0808_enc_dec_cell_id_list_lac(): populate all LACs Change-Id:

[MERGED] libosmocore[master]: add gsm0808_{enc,dec}_cell_id

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add gsm0808_{enc,dec}_cell_id .. add gsm0808_{enc,dec}_cell_id Clarify semantics and micro-optimise for the case of single Cell Identifer IEs. Test in

[MERGED] libosmocore[master]: add gsm0808_cell_id_list_add() to combine two cell identifie...

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add gsm0808_cell_id_list_add() to combine two cell identifier lists .. add gsm0808_cell_id_list_add() to combine two cell identifier lists This will be

[MERGED] libosmocore[master]: test_gsm0808_enc_dec_cell_id_list_lac(): validate encoded bytes

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: test_gsm0808_enc_dec_cell_id_list_lac(): validate encoded bytes .. test_gsm0808_enc_dec_cell_id_list_lac(): validate encoded bytes Change-Id:

[MERGED] libosmocore[master]: add tlv_parse2(), capable of multiple instances of the same IE

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add tlv_parse2(), capable of multiple instances of the same IE .. add tlv_parse2(), capable of multiple instances of the same IE Allow passing multiple

[MERGED] libosmocore[master]: add osmo_cgi_name()

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add osmo_cgi_name() .. add osmo_cgi_name() This will be used by cell idenitifier list code, like upcoming neighbor_ident VTY in osmo-bsc and regression

[MERGED] osmo-bsc[master]: fix handling of state changes in acc ramping

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix handling of state changes in acc ramping .. fix handling of state changes in acc ramping Take both the operative and administrative states into

osmo-bsc[master]: fix handling of state changes in acc ramping

2018-04-14 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7784 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3291439655598fb5ddc891a3e4cc35b0bad250f Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

2018-04-14 Thread Harald Welte
Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/7406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07fee78bba5b07c7f3f4359869e00ef2583e0769 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning .. jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning make clean has subdir/Makefile as

osmo-ttcn3-hacks[master]: LAPDm: Re-structure: Merge Frame type A+B which are really t...

2018-04-14 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7254 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3079899f42a61d67be03e3a17346af80d7b3be Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-msc[master]: smpp: Unset esme->acl on socket close

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7795 smpp: Unset esme->acl on socket close We set acl->esme during _process_bind(), but we don't clear it in case the TCP connection for the ESME is dead. This leads to a stale acl->esme pointer, which we will attempt to dereference the next time a SMS is

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #91

2018-04-14 Thread jenkins
See -- [...truncated 3.74 KB...] checking build system type... x86_64-unknown-linux-gnu checking host system type...

[MERGED] osmo-ttcn3-hacks[master]: msc: Add SMPP_Emulation + SMPP_Templates

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: Add SMPP_Emulation + SMPP_Templates .. msc: Add SMPP_Emulation + SMPP_Templates Change-Id: I80efe16f603227694c6242d556ae77590271e4c6 --- A

[MERGED] osmo-ttcn3-hacks[master]: msc: Fix console log levels

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: Fix console log levels .. msc: Fix console log levels In Change-Id I52a4c8118828c1605cf672889982f987568ad17d we introduced a name change for the

osmo-ttcn3-hacks[master]: msc: Fix console log levels

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7802 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdaf3446a81ea5f8310110f5cca2bdb3e552e3f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
sms_queue: fix use-after-free on 'pending' This bug is super obvious: We cannot first call sms_pending_free(pending) and then in the next line still dereference the pending->sms_id member. This bug was introduced in January with Change-Id: I3749855fe25d9d4e37ec96b0c2bffbc692b66a78 and

osmo-ttcn3-hacks[master]: msc: Add SMPP_Emulation + SMPP_Templates

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7800 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80efe16f603227694c6242d556ae77590271e4c6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: msc: Add SMPP tests for MO + MT SMS

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7801 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5349559c7c3096533fb07fcf53f0a44ff7f6567f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: deps: Use SMPP from osmocom fork

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7798 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6b120fe74b46183517264d85651ac0d99b4035 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: msc: Add SMPP_CodecPort

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7799 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57640ccc5370d6820bc303003e162f27ddc9fcfd Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: msc: Fix console log levels

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7802 msc: Fix console log levels In Change-Id I52a4c8118828c1605cf672889982f987568ad17d we introduced a name change for the SCCP/M3UA components, which meant that the log level configuration did no longer apply as intended. Change-Id:

docker-playground[master]: ttcn3-msc-test: Add SMPP config bits

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/7803 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I595a1ca2d47667e654f8a0a69bfe98c91ac58d39 Gerrit-PatchSet: 1 Gerrit-Project: docker-playground

[MERGED] osmo-ttcn3-hacks[master]: msc: Add SMPP tests for MO + MT SMS

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: Add SMPP tests for MO + MT SMS .. msc: Add SMPP tests for MO + MT SMS Change-Id: I5349559c7c3096533fb07fcf53f0a44ff7f6567f --- M

[PATCH] docker-playground[master]: ttcn3-msc-test: Add SMPP config bits

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7803 ttcn3-msc-test: Add SMPP config bits Change-Id: I595a1ca2d47667e654f8a0a69bfe98c91ac58d39 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground

[MERGED] osmo-ttcn3-hacks[master]: msc: Add SMPP_CodecPort

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: Add SMPP_CodecPort .. msc: Add SMPP_CodecPort Change-Id: I57640ccc5370d6820bc303003e162f27ddc9fcfd --- A library/SMPP_CodecPort.ttcn A

[MERGED] osmo-ttcn3-hacks[master]: deps: Use SMPP from osmocom fork

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: deps: Use SMPP from osmocom fork .. deps: Use SMPP from osmocom fork the osmocom fork has support for AlertNotification, which upstream doesn't. Pull

[MERGED] docker-playground[master]: ttcn3-msc-test: Add SMPP config bits

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ttcn3-msc-test: Add SMPP config bits .. ttcn3-msc-test: Add SMPP config bits Change-Id: I595a1ca2d47667e654f8a0a69bfe98c91ac58d39 --- M

[PATCH] osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7796 sms_queue: fix use-after-free on 'pending' This bug is super obvious: We cannot first call sms_pending_free(pending) and then in the next line still dereference the pending->sms_id member. Change-Id: Ibf17f270cdeb8153036eda3de274dd163bbff7e6 Closes:

[MERGED] osmo-bsc[master]: inform A-RESET FSM about MSC CR timeouts

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: inform A-RESET FSM about MSC CR timeouts .. inform A-RESET FSM about MSC CR timeouts The SUBSCR_CONN (GSCON) fsm starts a timer (993210, 20sec.) when

[MERGED] osmo-msc[master]: smpp: Unset esme->acl on socket close

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: smpp: Unset esme->acl on socket close .. smpp: Unset esme->acl on socket close We set acl->esme during _process_bind(), but we don't clear it in case

osmo-msc[master]: smpp: Unset esme->acl on socket close

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7795 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f140d7f9c7d89f200ddbcd81a8df66de69fb3e4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

Build failed in Jenkins: master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #932

2018-04-14 Thread jenkins
See -- [...truncated 765.68 KB...] ^~~~ ../include/osmocom/ranap/RANAP_RABParametersList.h:29:2:

[PATCH] osmo-ttcn3-hacks[master]: msc: Fix ti_flag mistake in f_mt_sms()

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7797 msc: Fix ti_flag mistake in f_mt_sms() The L3 transaction-id in MT-SMS is allocated in the MSC, so any messages we expect from the MSC must carry c_TIF_ORIG. Change-Id: I6ea977a7662fdfc9c504f13ac5632ac20a04f522 --- M msc/BSC_ConnectionHandler.ttcn 1

[PATCH] osmo-ttcn3-hacks[master]: msc: Add SMPP_CodecPort

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7799 msc: Add SMPP_CodecPort Change-Id: I57640ccc5370d6820bc303003e162f27ddc9fcfd --- A library/SMPP_CodecPort.ttcn A library/SMPP_CodecPort_CtrlFunct.ttcn A library/SMPP_CodecPort_CtrlFunctDef.cc M msc/gen_links.sh M msc/regen_makefile.sh 5 files changed,

[PATCH] osmo-ttcn3-hacks[master]: msc: Add SMPP tests for MO + MT SMS

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7801 msc: Add SMPP tests for MO + MT SMS Change-Id: I5349559c7c3096533fb07fcf53f0a44ff7f6567f --- M library/Osmocom_VTY_Functions.ttcn M library/SMPP_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 4 files changed, 269 insertions(+), 4

[PATCH] osmo-ttcn3-hacks[master]: msc: Add SMPP_Emulation + SMPP_Templates

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7800 msc: Add SMPP_Emulation + SMPP_Templates Change-Id: I80efe16f603227694c6242d556ae77590271e4c6 --- A library/SMPP_Emulation.ttcn A library/SMPP_Templates.ttcn M msc/gen_links.sh 3 files changed, 539 insertions(+), 1 deletion(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: deps: Use SMPP from osmocom fork

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7798 deps: Use SMPP from osmocom fork the osmocom fork has support for AlertNotification, which upstream doesn't. Pull request is pending, so we have to use our osmocom fork repo meanwhile. Change-Id: I9b6b120fe74b46183517264d85651ac0d99b4035 --- M

[MERGED] osmo-ttcn3-hacks[master]: msc: Fix ti_flag mistake in f_mt_sms()

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc: Fix ti_flag mistake in f_mt_sms() .. msc: Fix ti_flag mistake in f_mt_sms() The L3 transaction-id in MT-SMS is allocated in the MSC, so any

[MERGED] osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sms_queue: fix use-after-free on 'pending' .. sms_queue: fix use-after-free on 'pending' This bug is super obvious: We cannot first call

osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7796 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf17f270cdeb8153036eda3de274dd163bbff7e6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-ttcn3-hacks[master]: msc: Fix ti_flag mistake in f_mt_sms()

2018-04-14 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7797 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ea977a7662fdfc9c504f13ac5632ac20a04f522 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmocom-bb[fixeria/trx]: trxcon/scheduler: fix Measurement Reporting on SACCH

2018-04-14 Thread Vadim Yanitskiy
Patch Set 1: Verified-1 -- To view, visit https://gerrit.osmocom.org/7470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: fixeria/trx