[PATCH] osmo-bsc[master]: a_reset: cleanup + remove dead code

Review at https://gerrit.osmocom.org/8055 a_reset: cleanup + remove dead code The function a_reset_free() is not used anywhere at the code. The reason for this is that a BSC instance is never cleared once it is started up. Also the timer number is not according to the spec. - Remove

[MERGED] libosmocore[master]: define a constant for the max length of called party BCD IE

Stefan Sperling has submitted this change and it was merged. Change subject: define a constant for the max length of called party BCD IE .. define a constant for the max length of called party BCD IE According to TS 24.008

[PATCH] osmo-ttcn3-hacks[master]: make PCU tests send PS paging requests on BVCI zero

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/8020 to look at the new patch set (#2). make PCU tests send PS paging requests on BVCI zero osmo-pcu discards PAGING-PS messages unless received on the signalling BVCI 0. The

osmo-ttcn3-hacks[master]: make PCU tests send PS paging requests on BVCI zero

Patch Set 1: The next patch set will use a separate signaling port facing towards the test case. As you predicted, that approach works. However, the patch will still match on paging-ps messages only (see my other question). -- To view, visit https://gerrit.osmocom.org/8020 To unsubscribe,

osmo-hlr[master]: move creation of insert subscriber data messages to a common...

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7992/1/src/luop.c File src/luop.c: Line 53:if (msg_out == NULL) { > same here. OSMO_ASSERT(msg_out) is sufficient. Changed accordingly in next patch set. -- To view, visit https://gerrit.osmocom.org/7992 To unsubscribe, visit

[PATCH] osmo-hlr[master]: move creation of insert subscriber data messages to a common...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7992 to look at the new patch set (#2). move creation of insert subscriber data messages to a common function Move code to create an Insert Subscriber Data message into a common function

[PATCH] osmo-gsm-tester[master]: bts_osmotrx: Don't use binary name as inst name

Review at https://gerrit.osmocom.org/8053 bts_osmotrx: Don't use binary name as inst name Change-Id: Iee20738f2aa750aa9035a9e54ad667d8753ea12e --- M src/osmo_gsm_tester/bts_osmotrx.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester

osmo-ttcn3-hacks[master]: make PCU tests send PS paging requests on BVCI zero

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/8020/1/library/BSSGP_Emulation.ttcn File library/BSSGP_Emulation.ttcn: Line 538: [] BSSGP_SP.receive(tr_BSSGP_PS_PAGING(0)) -> value bs_pdu sender vc_conn { > I would argue this template should match all BSSGP messages for BVCI=0

[PATCH] osmo-msc[master]: a_reset: cleanup + remove dead code

Review at https://gerrit.osmocom.org/8054 a_reset: cleanup + remove dead code a_reset.c/h was originally developed to be used in both, bsc and msc without changes. Unfortunately no suitable library has been found for a_reset.c/h so the file ended up as duplicated code in both split brances.

osmo-gsm-tester[master]: bts_osmotrx: Don't use binary name as inst name

Patch Set 1: Code-Review+1 Verified+1 -- To view, visit https://gerrit.osmocom.org/8053 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee20738f2aa750aa9035a9e54ad667d8753ea12e Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester

[MERGED] osmo-gsm-tester[master]: bts_osmotrx: Don't use binary name as inst name

Pau Espin Pedrol has submitted this change and it was merged. Change subject: bts_osmotrx: Don't use binary name as inst name .. bts_osmotrx: Don't use binary name as inst name Change-Id:

osmo-gsm-tester[master]: bts_osmotrx: Don't use binary name as inst name

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8053 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee20738f2aa750aa9035a9e54ad667d8753ea12e Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-msc[master]: a_reset: cleanup + remove dead code

Patch Set 1: Code-Review+1 (7 comments) +2 for the dead code removal. Also added some general comments related to OS#3103. https://gerrit.osmocom.org/#/c/8054/1/src/libmsc/a_reset.c File src/libmsc/a_reset.c: Line 32: #define RESET_RESEND_TIMER_NO 16/* See also 3GPP TS 48.008 Chapter

osmo-hlr[master]: move creation of insert subscriber data messages to a common...

Patch Set 2: Code-Review-1 (2 comments) One thing that's worse after this patch: we add a couple of short-lived small dynamic allocations (gsup message, msisdn, apn). The root cause being that we failed to use actual arrays in the original definition of the gsup message struct. Instead of

[PATCH] osmo-bts[master]: let osmo-bts log a special notice if OML connection is close...

Review at https://gerrit.osmocom.org/8056 let osmo-bts log a special notice if OML connection is closed early A frequent configuration file error is that the unit_id settings of osmo-bts and osmo-bsc don't match. The BSC already prints an error in this case. Let the BTS print an error as well.

osmo-bsc[master]: a_reset: cleanup + remove dead code

Patch Set 1: (5 comments) please clarify... https://gerrit.osmocom.org/#/c/8055/1/src/libbsc/a_reset.c File src/libbsc/a_reset.c: Line 158 good point, where is the inevitable osmo_fsm_inst_term() needed to end this FSM when the connection to an MSC ends? Line 162 and now, who does ever

osmo-msc[master]: a_reset: cleanup + remove dead code

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/8054/1/src/libmsc/a_reset.c File src/libmsc/a_reset.c: Line 126: reset->fsm->priv = reset; ah, my bad, fsm->priv is actually set here. But rather use the priv arg of osmo_fsm_inst_alloc(), and rather decide on using priv or using

[PATCH] osmo-bts[master]: send a State Changed Event Report when rf is locked/unlocked

Review at https://gerrit.osmocom.org/8057 send a State Changed Event Report when rf is locked/unlocked Make osmo-bts send a State Changed Event Report when RF is locked or unlocked. This behaviour isn't mentioned in the spec as far as we know, but an ipaccess nanobts also produces these

[PATCH] osmo-gsm-tester[master]: tests: voice: Add tests to verify tch timeslots during phone...

Review at https://gerrit.osmocom.org/8064 tests: voice: Add tests to verify tch timeslots during phone calls Change-Id: I897757a21fee516ce96808a180121b09f06a0fea --- A suites/voice/mo_mt_call_hr.py 1 file changed, 18 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-gsm-tester[master]: tests: voice: Add tests to verify dynamic timeslots during p...

tests: voice: Add tests to verify dynamic timeslots during phone calls Change-Id: Id5e61eaff39ac7a6585dc7de2aeb2469dd2ce726 --- A suites/voice/mo_mt_call_dyn_ipa.py A suites/voice/mo_mt_call_dyn_osmo.py 2 files changed, 36 insertions(+), 0 deletions(-) git pull

meta-telephony[201705]: recipes-osmocom: Remove manual recreation of tarball-version...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8047 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c1ad67224cde2f3a25c6fe945509586ec84de0c Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: libosmo-sccp: Move version independent bits to .inc file

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8049 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c4078826c4a4d34221d3b503d6836788cc38012 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: recipes-osmocom: Move DEPENDS to .inc files

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8048 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I436e8c954e7c29c8e583507c048828e852704f4b Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: Remove libosmo-sccp_0.0.6.1.bb

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8046 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ccfd2a79955708fad8c37a86e0515bca1839ca6 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

[MERGED] meta-telephony[201705]: recipes-osmocom: Remove manual recreation of tarball-version...

Harald Welte has submitted this change and it was merged. Change subject: recipes-osmocom: Remove manual recreation of tarball-version file .. recipes-osmocom: Remove manual recreation of tarball-version file The reasoning

[MERGED] osmo-ci[master]: osmo-gsm-tester-builder: notify unstable builds

Harald Welte has submitted this change and it was merged. Change subject: osmo-gsm-tester-builder: notify unstable builds .. osmo-gsm-tester-builder: notify unstable builds Change-Id: I5a1d7b5e1af5b4fbd12effa870542df2d6be7647

[MERGED] meta-telephony[201705]: recipes-osmocom: Move DEPENDS to .inc files

Harald Welte has submitted this change and it was merged. Change subject: recipes-osmocom: Move DEPENDS to .inc files .. recipes-osmocom: Move DEPENDS to .inc files Change-Id: I436e8c954e7c29c8e583507c048828e852704f4b --- M

[MERGED] meta-telephony[201705]: Remove libosmo-sccp_0.0.6.1.bb

Harald Welte has submitted this change and it was merged. Change subject: Remove libosmo-sccp_0.0.6.1.bb .. Remove libosmo-sccp_0.0.6.1.bb This recipe is outdated as we use the _git ones nowadays. Change-Id:

[MERGED] meta-telephony[201705]: recipes-osmocom: Update to latest release

Harald Welte has submitted this change and it was merged. Change subject: recipes-osmocom: Update to latest release .. recipes-osmocom: Update to latest release Change-Id: Ibd3b95f51e8085df669015e107483e89b2a7d64e --- M

[MERGED] meta-telephony[201705]: libosmo-sccp: Move version independent bits to .inc file

Harald Welte has submitted this change and it was merged. Change subject: libosmo-sccp: Move version independent bits to .inc file .. libosmo-sccp: Move version independent bits to .inc file Change-Id:

osmo-ci[master]: osmo-gsm-tester-builder: notify unstable builds

Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/8052 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a1d7b5e1af5b4fbd12effa870542df2d6be7647 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch:

osmo-bsc[master]: osmo_bsc_vty.c: fix: write MGW configuration

Patch Set 1: there has been some discussion today on IRC about the MGW configuration being actually global and not beloging to any specific MSC config node? Pau? -- To view, visit https://gerrit.osmocom.org/8044 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

osmo-bsc[master]: osmo_bsc_vty.c: fix: write MGW configuration

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/8044 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d1eedb782a4f30bd089838969ce54f27cde060d Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: bts: Pass defaults config name at construct time

Review at https://gerrit.osmocom.org/8060 bts: Pass defaults config name at construct time It will be needed later at construction time when resolving the num of trx. Change-Id: I2c6a46ead14010f714897ea178917327215823e7 --- M src/osmo_gsm_tester/bts.py M src/osmo_gsm_tester/bts_nanobts.py M

[PATCH] osmo-gsm-tester[master]: bts: Allow setting amounf of TRX and timeslot in cfg and fro...

Review at https://gerrit.osmocom.org/8061 bts: Allow setting amounf of TRX and timeslot in cfg and from test at runtime The num_trx attribute for a given BTS states the number of TRX to be used by that BTS. If more than num_trx are configured in trx_list in the cfg file, then only up to

[PATCH] osmo-gsm-tester[master]: bts: Refactor conf_for_bsc_osmo

Review at https://gerrit.osmocom.org/8059 bts: Refactor conf_for_bsc_osmo Move duplicated code into a method in the superclass. Change-Id: Ie27932f94142f667c3fb8c054b77e04afa0d5cbb --- M src/osmo_gsm_tester/bts_nanobts.py M src/osmo_gsm_tester/bts_octphy.py M src/osmo_gsm_tester/bts_osmo.py M

[PATCH] osmo-gsm-tester[master]: Check physical channel configs

Review at https://gerrit.osmocom.org/8058 Check physical channel configs Change-Id: I5894678e0d6f306173cc550dd6806a7d6f8a4c11 --- M src/osmo_gsm_tester/resource.py M src/osmo_gsm_tester/schema.py 2 files changed, 9 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-gsm-tester[master]: tests: voice: Move logic to testlib.py

Review at https://gerrit.osmocom.org/8062 tests: voice: Move logic to testlib.py This way we can have several tests sharing similar logic. Change-Id: I5cfcc56970380a7c5400186fac5f504263d63c5f --- M src/osmo_gsm_tester/testenv.py A suites/voice/lib/testlib.py M suites/voice/mo_mt_call.py 3

[PATCH] osmo-gsm-tester[master]: tests: voice: Add tests to verify dynamic timeslots during p...

Review at https://gerrit.osmocom.org/8063 tests: voice: Add tests to verify dynamic timeslots during phone calls Change-Id: Id5e61eaff39ac7a6585dc7de2aeb2469dd2ce726 --- A suites/voice/mo_mt_call_dyn_ipa.py A suites/voice/mo_mt_call_dyn_osmo.py 2 files changed, 48 insertions(+), 0 deletions(-)

osmo-bts[master]: send a State Changed Event Report when rf is locked/unlocked

Patch Set 1: Code-Review+2 nice catch! -- To view, visit https://gerrit.osmocom.org/8057 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37e44ef4881c41f8835428b610e7863f37397c9f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch:

meta-telephony[201705]: recipes-osmocom: Update to latest release

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8050 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3b95f51e8085df669015e107483e89b2a7d64e Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

osmo-bts[master]: let osmo-bts log a special notice if OML connection is close...

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/8056/1/src/common/abis.c File src/common/abis.c: Line 153: if (g_bts->oml_conn_established_timestamp.tv_sec != 0 && osmo_gettimeofday(, NULL) == 0 && it's not super critical, I guess, but gettimeofday is not monotonic. So

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #115

See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

osmo-bsc[master]: osmo_bsc_vty.c: fix: write MGW configuration

Patch Set 1: https://osmocom.org/issues/3243 -- To view, visit https://gerrit.osmocom.org/8044 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d1eedb782a4f30bd089838969ce54f27cde060d Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc

osmo-bsc[master]: osmo_bsc_vty.c: fix: write MGW configuration

Patch Set 1: > there has been some discussion today on IRC about the MGW > configuration being actually global and not beloging to any > specific MSC config node? Pau? I think this is a separate issue. We need to store settings at least. -- To view, visit https://gerrit.osmocom.org/8044 To

Build failed in Jenkins: master-rtl-sdr » a1=default,a2=default,a3=default,osmocom-master-debian9 #27

See -- [...truncated 93.34 KB...] make[2]: Nothing to be done for 'dvi'. make[2]: Leaving directory

osmo-gsm-tester[master]: tests: voice: Add tests to verify tch timeslots during phone...

Patch Set 1: Code-Review-2 (3 comments) same, use a scenario.conf instead https://gerrit.osmocom.org/#/c/8064/1//COMMIT_MSG Commit Message: Line 7: tests: voice: Add tests to verify tch timeslots during phone calls "test voice calls on TCH timeslots" -- and what do you mean, all voice has to

osmo-gsm-tester[master]: tests: voice: Add tests to verify dynamic timeslots during p...

Patch Set 2: also note that some BTS kinds allow specific pchans only in specific timeslots, see verify_chan_comb() in osmo-bsc/src/libbsc/abis_nm.c. It may not be necessary to reflect these 1:1 in osmo-gsm-tester validation, just saying that semantically a BTS model needs to reflect what

osmo-gsm-tester[master]: bts: Pass defaults config name at construct time

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8060 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c6a46ead14010f714897ea178917327215823e7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: bts: Allow setting amounf of TRX and timeslot in cfg and fro...

Patch Set 1: Code-Review-1 (1 comment) I'm not sure I understand the max_trx. Which situation does it resolve? AFAIU a BTS simply has a given number of TRX by hardware, and a scenario may want to request a specific number of TRX (but I guess will generally not actually care how many there

osmo-gsm-tester[master]: tests: voice: Move logic to testlib.py

Patch Set 1: Code-Review-1 erm, what? you want to manipulate the python path from a test script? You introduce a "lib" to contain common parts to be re-used in several tests, I think to prepare incorporating config in the test scripts in the upcoming patches, config which should be in a

osmo-gsm-tester[master]: tests: voice: Add tests to verify dynamic timeslots during p...

Patch Set 2: Code-Review-2 (1 comment) as much as I'd like the dyn TS tested automatically soon, I'm afraid this goes in the wrong direction... https://gerrit.osmocom.org/#/c/8063/2/suites/voice/mo_mt_call_dyn_ipa.py File suites/voice/mo_mt_call_dyn_ipa.py: Line 16:

osmo-gsm-tester[master]: bts: Refactor conf_for_bsc_osmo

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/8059 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie27932f94142f667c3fb8c054b77e04afa0d5cbb Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: tests: voice: Add tests to verify dynamic timeslots during p...

Patch Set 2: Code-Review-1 Don't merge yet, these tests will fail due to issue in https://osmocom.org/issues/3244. We need to move the dyn tests to its own suite since they require gprs (sgsn, ggsn, etc.) We can keep the HR one in voice, and switch the default one to use FR perhaps. -- To