Change in ...libosmo-netif[master]: tests: osmux_test: Provide More accurate logging expectancies

2019-10-04 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/15670 to look at the new patch set (#2). Change subject: tests: osmux_test: Provide More accurate logging expectancies

Change in ...osmo-iuh[master]: iu_client: pass return value of osmo_sccp_user_sap_down() towards the...

2019-10-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15665 ) Change subject: iu_client: pass return value of osmo_sccp_user_sap_down() towards the caller .. Patch Set 1: Code-Review+1 -- To

Re: Build failure of network:osmocom:nightly/libosmo-netif in Raspbian_10/armv7l

2019-10-04 Thread Pau Espin Pedrol
I submitted some patches to make the test more reproducible and make it easier to spot errors: remote: https://gerrit.osmocom.org/c/libosmo-netif/+/15667 osmux: osmux_snprintf(): Append comma between osmux frames in msg remote: https://gerrit.osmocom.org/c/libosmo-netif/+/15668 osmux:

Change in ...libosmo-netif[master]: tests: osmux_test: Use fake time also for monotonic clock

2019-10-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15669 Change subject: tests: osmux_test: Use fake time also for monotonic clock .. tests: osmux_test: Use fake time also for monotonic

Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dum...

2019-10-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15668 Change subject: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dummy frames .. osmux: osmux_snprintf():

Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Append comma between osmux frames in msg

2019-10-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15667 Change subject: osmux: osmux_snprintf(): Append comma between osmux frames in msg .. osmux: osmux_snprintf(): Append comma

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Change in ...libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 1: > why not LOGP()? I guess I wanted it

Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64

2019-10-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build

Change in ...osmo-iuh[master]: iu_client: ranap_iu_tx_release() change default cause code to Success

2019-10-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15666 ) Change subject: iu_client: ranap_iu_tx_release() change default cause code to Success .. Patch Set 1: Code-Review+1 (2 comments)

Change in ...osmo-ttcn3-hacks[master]: Create dummy gsmtap sink with netcat

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15651 ) Change subject: Create dummy gsmtap sink with netcat .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15672 ) Change subject: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance control .. PCU_Tests_RAW.ttcn:

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15638 ) Change subject: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding .. Patch Set 1: Code-Review+2 -- To view,

Change in ...libosmo-netif[master]: osmux: squash LOGP message to one line

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15673 ) Change subject: osmux: squash LOGP message to one line .. osmux: squash LOGP message to one line It seems different

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15638 ) Change subject: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding .. PCU_Tests_RAW.ttcn: introduce a test

Change in ...docker-playground[master]: ttcn-*: Fix gsmtap log not enabled

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/15662 ) Change subject: ttcn-*: Fix gsmtap log not enabled .. ttcn-*: Fix gsmtap log not enabled gsmtap log won't be

Change in ...osmo-ttcn3-hacks[master]: Create dummy gsmtap sink with netcat

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15651 ) Change subject: Create dummy gsmtap sink with netcat .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...docker-playground[master]: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-h...

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/15652 ) Change subject: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-hacks .. debian-stretch-titan:

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671 ) Change subject: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI .. library/PCUIF_Types.ttcn: add

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671 ) Change subject: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI .. Patch Set 1: Code-Review+2 -- To view,

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15672 ) Change subject: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance control .. Patch Set 2: Code-Review+2

Change in ...libosmo-netif[master]: osmux: squash LOGP message to one line

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15673 ) Change subject: osmux: squash LOGP message to one line .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...docker-playground[master]: ttcn-*: Fix gsmtap log not enabled

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15662 ) Change subject: ttcn-*: Fix gsmtap log not enabled .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...docker-playground[master]: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-h...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15652 ) Change subject: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-hacks .. Patch Set 2: Code-Review+2

Change in ...libosmo-netif[master]: tests: osmux_test: Provide More accurate logging expectancies

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15670 ) Change subject: tests: osmux_test: Provide More accurate logging expectancies .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...simtrace2[master]: define LEDs for octsimtest

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/15650 ) Change subject: define LEDs for octsimtest .. define LEDs for octsimtest the OctSIM tester has only one amber LED. this is

Change in ...osmo-pcu[master]: Log RACH Requests using GSMTAP

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15632 ) Change subject: Log RACH Requests using GSMTAP .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-pcu[master]: Log AGCH and PCH blocks using GSMTAP

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15633 ) Change subject: Log AGCH and PCH blocks using GSMTAP .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-pcu[master]: Log RACH Requests using GSMTAP

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15632 ) Change subject: Log RACH Requests using GSMTAP .. Log RACH Requests using GSMTAP Change-Id:

Change in ...simtrace2[master]: make LED definitions board specific

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/15649 ) Change subject: make LED definitions board specific .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...simtrace2[master]: hw: put board specific pin definition in corresponding file

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/15647 ) Change subject: hw: put board specific pin definition in corresponding file .. hw: put board specific pin definition in

Change in ...simtrace2[master]: make LED definitions board specific

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/15649 ) Change subject: make LED definitions board specific .. make LED definitions board specific the LEDs (2 of them) were

Change in ...simtrace2[master]: define LEDs for octsimtest

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/15650 ) Change subject: define LEDs for octsimtest .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-pcu[master]: Log AGCH and PCH blocks using GSMTAP

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15633 ) Change subject: Log AGCH and PCH blocks using GSMTAP .. Log AGCH and PCH blocks using GSMTAP Change-Id:

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15657 ) Change subject: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-bts[master]: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15656 ) Change subject: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: API doc tweaks (mncc.h, gsm_08_08.h)

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15659 ) Change subject: API doc tweaks (mncc.h, gsm_08_08.h) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ccid-firmware[master]: Fix USB descriptor bugs (wrong interface, ProtocolsSuported, ...)

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15643 ) Change subject: Fix USB descriptor bugs (wrong interface, ProtocolsSuported, ...) .. Patch Set 1: Code-Review+2 -- To

Change in ...libosmocore[master]: API doc tweaks (mncc.h, gsm_08_08.h)

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15659 ) Change subject: API doc tweaks (mncc.h, gsm_08_08.h) .. API doc tweaks (mncc.h, gsm_08_08.h) Change-Id:

Change in ...osmo-ccid-firmware[master]: CCID: fix length checks in PC_to_RDR_{GetSlotStatus, SetParameters}

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15642 ) Change subject: CCID: fix length checks in PC_to_RDR_{GetSlotStatus,SetParameters} .. Patch Set 1: Code-Review+2 -- To

Change in ...osmo-iuh[master]: iu_client: pass return value of osmo_sccp_user_sap_down() towards the...

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15665 ) Change subject: iu_client: pass return value of osmo_sccp_user_sap_down() towards the caller .. iu_client: pass return

Change in ...osmo-iuh[master]: iu_client: pass return value of osmo_sccp_user_sap_down() towards the...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15665 ) Change subject: iu_client: pass return value of osmo_sccp_user_sap_down() towards the caller .. Patch Set 1: Code-Review+2 -- To

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail()

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15648 ) Change subject: MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail() .. Patch Set 1: Code-Review+2 -- To view,

Change in ...osmo-bsc[master]: gsm_08_08.c: Mark func bsc_find_msc() static

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15663 ) Change subject: gsm_08_08.c: Mark func bsc_find_msc() static .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-iuh[master]: iu_client: ranap_iu_tx_release() change default cause code to Success

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15666 ) Change subject: iu_client: ranap_iu_tx_release() change default cause code to Success .. Patch Set 1: Code-Review+1 -- To view,

Change in ...osmo-bsc[master]: gsm_08_08.c: Mark func bsc_find_msc() static

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15663 ) Change subject: gsm_08_08.c: Mark func bsc_find_msc() static .. gsm_08_08.c: Mark func bsc_find_msc() static Its currently

Change in ...osmo-bts[master]: common/l1sap: increase ToA precision for packet Access Bursts

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15658 ) Change subject: common/l1sap: increase ToA precision for packet Access Bursts .. common/l1sap: increase ToA precision for

Change in ...osmo-bts[master]: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15656 ) Change subject: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels .. scheduler: fix handling of PTCCH/U and

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15657 ) Change subject: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH .. osmo-bts-trx/scheduler: also detect

Change in ...osmo-bts[master]: common/l1sap: increase ToA precision for packet Access Bursts

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15658 ) Change subject: common/l1sap: increase ToA precision for packet Access Bursts .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...simtrace2[master]: hw: put board specific pin definition in corresponding file

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/15647 ) Change subject: hw: put board specific pin definition in corresponding file .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ccid-firmware[master]: ccid: Fix overflow in Fi value

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15646 ) Change subject: ccid: Fix overflow in Fi value .. ccid: Fix overflow in Fi value The Fi value can easily exceed

Change in ...osmo-ccid-firmware[master]: ccid_df: Ensure all three endpoints are correctly set

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15644 ) Change subject: ccid_df: Ensure all three endpoints are correctly set .. ccid_df: Ensure all three endpoints are

Change in ...osmo-ccid-firmware[master]: Fix USB descriptor bugs (wrong interface, ProtocolsSuported, ...)

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15643 ) Change subject: Fix USB descriptor bugs (wrong interface, ProtocolsSuported, ...) .. Fix USB descriptor bugs

Change in ...osmo-ccid-firmware[master]: ccid_gen_notify_slot_status: Fix bitmask of card slot insert status

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15645 ) Change subject: ccid_gen_notify_slot_status: Fix bitmask of card slot insert status ..

Change in ...osmo-ccid-firmware[master]: ccid_gen_notify_slot_status: Fix bitmask of card slot insert status

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15645 ) Change subject: ccid_gen_notify_slot_status: Fix bitmask of card slot insert status .. Patch Set 1: Code-Review+2 -- To

Change in ...osmo-ccid-firmware[master]: ccid: Fix overflow in Fi value

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15646 ) Change subject: ccid: Fix overflow in Fi value .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ccid-firmware[master]: CCID: fix length checks in PC_to_RDR_{GetSlotStatus, SetParameters}

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15642 ) Change subject: CCID: fix length checks in PC_to_RDR_{GetSlotStatus,SetParameters} .. CCID: fix length checks in

Change in ...osmo-ttcn3-hacks[master]: Create dummy gsmtap sink with netcat

2019-10-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15651 ) Change subject: Create dummy gsmtap sink with netcat .. Create dummy gsmtap sink with netcat otherwise ICMP messages

Change in ...docker-playground[master]: ttcn-*: Fix gsmtap log not enabled

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15662 ) Change subject: ttcn-*: Fix gsmtap log not enabled .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...docker-playground[master]: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-h...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15652 ) Change subject: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-hacks .. Patch Set 1: Code-Review+1

Change in ...docker-playground[master]: ttcn3-pcu: Enable GSMTAP

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15635 ) Change subject: ttcn3-pcu: Enable GSMTAP .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...docker-playground[master]: ttcn3-pcu: Enable GSMTAP

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/15635 ) Change subject: ttcn3-pcu: Enable GSMTAP .. ttcn3-pcu: Enable GSMTAP Depends on recent commit adding RACH, AGCH

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15672 ) Change subject: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance control .. Patch Set 2: Code-Review+1 --

Change in ...osmo-bts[master]: bts-trx: trx_set_bts(): Avoid double loop by checking current trx

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15628 ) Change subject: bts-trx: trx_set_bts(): Avoid double loop by checking current trx .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

2019-10-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671 ) Change subject: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI .. Patch Set 1: Code-Review+2 -- To view,

Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dum...

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15668 ) Change subject: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dummy frames .. osmux:

Change in ...libosmo-netif[master]: tests: osmux_test: Use fake time also for monotonic clock

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15669 ) Change subject: tests: osmux_test: Use fake time also for monotonic clock .. tests: osmux_test: Use fake time also for

Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Append comma between osmux frames in msg

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15667 ) Change subject: osmux: osmux_snprintf(): Append comma between osmux frames in msg .. osmux: osmux_snprintf(): Append

Change in ...libosmo-netif[master]: tests: osmux_test: Use fake time also for monotonic clock

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15669 ) Change subject: tests: osmux_test: Use fake time also for monotonic clock .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dum...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15668 ) Change subject: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dummy frames .. Patch Set 1: Code-Review+2

Change in ...osmo-bts[master]: bts-trx: Allocate struct osmo_trx_clock_state as part of bts-trx priv...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15614 ) Change subject: bts-trx: Allocate struct osmo_trx_clock_state as part of bts-trx private data .. Patch Set 4: Code-Review+1 -- To

Change in ...osmo-bts[master]: bts-trx: vty: Print phy link state in cmd 'show transceiver'

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15627 ) Change subject: bts-trx: vty: Print phy link state in cmd 'show transceiver' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-bts[master]: struct gsm_bts: Add model_priv pointer handing bts_model specific data

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15613 ) Change subject: struct gsm_bts: Add model_priv pointer handing bts_model specific data .. Patch Set 4: Code-Review+1 -- To view,

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

2019-10-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671 Change subject: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI .. library/PCUIF_Types.ttcn: add optional

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15672 Change subject: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance control .. PCU_Tests_RAW.ttcn: add a test

Change in ...libosmocore[master]: gsup: add OSMO_GSUP_SUPPORTED_RAT_TYPES_IE and OSMO_GSUP_CURRENT_RAT_...

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/12452 ) Change subject: gsup: add OSMO_GSUP_SUPPORTED_RAT_TYPES_IE and OSMO_GSUP_CURRENT_RAT_TYPE_IE .. gsup: add

Change in ...osmo-ttcn3-hacks[master]: library/RLCMAC_Types.ttcn: implement PTCCH/D message coding

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15637 ) Change subject: library/RLCMAC_Types.ttcn: implement PTCCH/D message coding .. Patch Set 1: Code-Review+2 -- To view,

Change in ...osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types.ttcn: implement Packet Power Control/Timing...

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15636 ) Change subject: library/RLCMAC_CSN1_Types.ttcn: implement Packet Power Control/Timing Advance ..

Change in ...osmo-ttcn3-hacks[master]: library/RLCMAC_Types.ttcn: implement PTCCH/D message coding

2019-10-04 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15637 ) Change subject: library/RLCMAC_Types.ttcn: implement PTCCH/D message coding .. library/RLCMAC_Types.ttcn: implement

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15638 ) Change subject: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding .. Patch Set 1: Code-Review+1 -- To view,

Change in ...osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types.ttcn: implement Packet Power Control/Timing...

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15636 ) Change subject: library/RLCMAC_CSN1_Types.ttcn: implement Packet Power Control/Timing Advance .. Patch Set 1: Code-Review+2

Change in ...docker-playground[master]: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-h...

2019-10-04 Thread pespin
Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/15652 to look at the new patch set (#2). Change subject: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-hacks

Change in ...docker-playground[master]: ttcn-*: Fix gsmtap log not enabled

2019-10-04 Thread pespin
Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/15662 to look at the new patch set (#2). Change subject: ttcn-*: Fix gsmtap log not enabled .. ttcn-*: Fix

Change in ...libosmo-netif[master]: tests: osmux_test: Provide More accurate logging expectancies

2019-10-04 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/15670 to look at the new patch set (#3). Change subject: tests: osmux_test: Provide More accurate logging expectancies

Change in ...libosmo-netif[master]: osmux: squash LOGP message to one line

2019-10-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15673 Change subject: osmux: squash LOGP message to one line .. osmux: squash LOGP message to one line It seems different compiler

Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Append comma between osmux frames in msg

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15667 ) Change subject: osmux: osmux_snprintf(): Append comma between osmux frames in msg .. Patch Set 1: Code-Review+2 -- To view,

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread fixeria
Hello pespin, laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15672 to look at the new patch set (#2). Change subject: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance control

Change in ...libosmo-netif[master]: tests: osmux_test: Provide More accurate logging expectancies

2019-10-04 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/15670 to look at the new patch set (#4). Change subject: tests: osmux_test: Provide More accurate logging expectancies

Change in ...osmo-bts[master]: bts-trx: Get rid of messy transceiver_available state handler

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15615 ) Change subject: bts-trx: Get rid of messy transceiver_available state handler .. Patch Set 5: Code-Review+1 -- To view, visit

Change in ...osmo-bts[master]: bts-trx: Drop unused func check_transceiver_availability()

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15631 ) Change subject: bts-trx: Drop unused func check_transceiver_availability() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce func helper f_establish_tbf_ul()

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15675 ) Change subject: pcu: Introduce func helper f_establish_tbf_ul() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: pcu: Allow tests to overwrite pcuif INFO_IND params

2019-10-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15674 ) Change subject: pcu: Allow tests to overwrite pcuif INFO_IND params .. Patch Set 1: Code-Review+1 You can always override

Change in ...libosmocore[master]: add osmo_fsm_inst_watch()

2019-10-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 ) Change subject: add osmo_fsm_inst_watch() .. Patch Set 2: I wish my reply could be shorter, but this is a quite important aspect

  1   2   >