er
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Tom Tsou <t...@tsou.cc>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: tnt <t...@246tnt.com>
Gerrit-HasComments: No
errit-Reviewer: Tom Tsou <t...@tsou.cc>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: tnt <t...@246tnt.com>
Gerrit-HasComments: No
tnt has posted comments on this change. ( https://gerrit.osmocom.org/9241 )
Change subject: Move 'src/target_dsp' to 'target/calypso_dsp'
..
Patch Set 1:
Err .. yeah, pretty much same as Harald. Doesn't bother me to have
tnt has posted comments on this change. ( https://gerrit.osmocom.org/9794 )
Change subject: fmt_ti.c: fix: properly pre-clean the output buffer
..
Patch Set 1:
This just looks like a false positive to me.
Sure msb_put_bit
t;axilira...@gmail.com>
Gerrit-Reviewer: tnt <t...@246tnt.com>
Gerrit-HasComments: Yes
-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: tnt <t...@246tnt.com>
Gerrit-HasComments: No
tnt has posted comments on this change. ( https://gerrit.osmocom.org/11480 )
Change subject: pySim/transport: introduce Calypso based reader interface
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org
tnt has posted comments on this change. ( https://gerrit.osmocom.org/11481 )
Change subject: pySim-*.py: refactor card reader driver initialization
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12641 )
Change subject: constrain gsm48_generate_mid() output array bounds
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12641
Gerrit-Change-Number: 12416
Gerrit-PatchSet: 5
Gerrit-Owner: tnt
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/12415 )
Change subject: convolve: Remove support for step, offset parameters
..
convolve: Remove support for step, offset parameters
- Those
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/12417 )
Change subject: arm/convolve: Fix the vfp4 real convolution for h_len=12
..
arm/convolve: Fix the vfp4 real convolution for h_len=12
Change
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12423 )
Change subject: ctrl2cgi: update comments
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12423
To unsubscribe
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12425 )
Change subject: vty: The telnet interface is TCP only. Fix the comments
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/12415
Change subject: convolve: Remove support for step, offset parameters
..
convolve: Remove support for step, offset parameters
- Those are not used any
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/12417
Change subject: arm/convolve: Fix the vfp4 real convolution for h_len=12
..
arm/convolve: Fix the vfp4 real convolution for h_len=12
Change-Id
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/12418
Change subject: tests: Re-enable the convolve_test by default
..
tests: Re-enable the convolve_test by default
Change-Id
tnt has removed a vote on this change.
Change subject: new file: 3
..
Removed Code-Review+2 by tnt
--
To view, visit https://gerrit.osmocom.org/12216
To unsubscribe, or for help writing mail filters, visit
https
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12216 )
Change subject: new file: 3
..
Patch Set 1: Code-Review+2
Nice !
--
To view, visit https://gerrit.osmocom.org/12216
To unsubscribe, or for help
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12216 )
Change subject: new file: 3
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12216
To unsubscribe, or for help writing
Gerrit-Owner: tnt
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
-Number: 12416
Gerrit-PatchSet: 4
Gerrit-Owner: tnt
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Owner: tnt
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/12418 )
Change subject: tests: Re-enable the convolve_test by default
..
tests: Re-enable the convolve_test by default
Change-Id
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12625
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences
..
Patch Set 12:
(1 comment)
https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation
..
Patch Set 2: Code-Review-1
(1 comment)
Looks good to me except
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/12983
Change subject: [WIP] fsm: Delay processing events after dispatch is complete
..
[WIP] fsm: Delay processing events after dispatch is complete
Change
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation
..
Patch Set 1:
I'm rechecking the specs right now, but this 'jumble' function
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation
..
Patch Set 1: Code-Review-1
Confirmed by re-reading both rfc5993 (which
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation
..
Patch Set 1:
> the sysmoBTS PHY (just like the PHY of the litecell
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
Patch Set 3:
(2 comments)
Fixed in latest patch set
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/13172 )
Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x
..
assignment_fsm: Properly support assigning signalling
: I82645708dd27864cf33ea9cc993ead0983415602
Gerrit-Change-Number: 13242
Gerrit-PatchSet: 2
Gerrit-Owner: tnt
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: tnt
Gerrit-CC: Harald Welte
Gerrit-CC: Max
Gerrit-CC: Pau Espin Pedrol
Gerrit-CC: Vadim Yanitskiy
: I82645708dd27864cf33ea9cc993ead0983415602
Gerrit-Change-Number: 13242
Gerrit-PatchSet: 3
Gerrit-Owner: tnt
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: tnt
Gerrit-CC: Harald Welte
Gerrit-CC: Max
Gerrit-CC: Pau Espin Pedrol
Gerrit-CC: Vadim Yanitskiy
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13241 )
Change subject: tests: AM_LDFLAGS = -noinstall for all tests
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13241
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13247 )
Change subject: gitignore: add amr_test
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13247
To unsubscribe, or for help
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
Patch Set 3: Code-Review+2
--
To view, visit https
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
libmsc: Allow different channel types
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13249 )
Change subject: Don't return error on normal shutdown
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13249
tnt has abandoned this change. ( https://gerrit.osmocom.org/12983 )
Change subject: [WIP] fsm: Add function to queue events for FSM instance.
..
Abandoned
Just generally a bad idea .. changes semantics ... breaks everything
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13242
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
libmsc: Allow different channel types to be requested
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
Patch Set 1:
(8 comments)
Tx for the review, will fix
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13172
Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x
..
assignment_fsm: Properly support assigning signalling mode TCH/x
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13248 )
Change subject: libvlr: Allow 2G auth tuples to be re-used without going
through AUTH
..
Patch Set 1:
> looks good to me. I'm a bit wondering ab
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13203
Change subject: rtp: Add 'autoconnect' feature to the osmo_rtp_socket
..
rtp: Add 'autoconnect' feature to the osmo_rtp_socket
The bound RTP socket
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13197 )
Change subject: trxcon/scheduler: clarify decoding of incomplete xCCH blocks
..
Patch Set 1: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13209 )
Change subject: Fix build on non-glibc systems
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13209
To unsubscribe
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences
..
Patch Set 9:
(1 comment)
https://gerrit.osmocom.org/#/c/12625/9/src/osmo-bsc
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/12905
Change subject: gsm_08_08.h: Add constants for Channel Type in signalling mode
..
gsm_08_08.h: Add constants for Channel Type in signalling mode
tnt has posted comments on this change. ( https://gerrit.osmocom.org/6315 )
Change subject: osmo-bts-trx: add extended (11-bit) RACH support
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6315
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences
..
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/#/c/12625/8/include/osmocom
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12850 )
Change subject: protocol/gsm_04_14: Fix the OPEN LOOP message type
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12850
tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences
..
Patch Set 8:
(2 comments)
https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/12850 )
Change subject: protocol/gsm_04_14: Fix the OPEN LOOP message type
..
protocol/gsm_04_14: Fix the OPEN LOOP message type
Change-Id
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/12850
Change subject: protocol/gsm_04_14: Fix the OPEN LOOP message type
..
protocol/gsm_04_14: Fix the OPEN LOOP message type
Change-Id
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/14051
Change subject: codec/ecu: Add a bit of precision about the actual frame format
used
..
codec/ecu: Add a bit of precision about the actual frame
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/14051 )
Change subject: codec/ecu: Add a bit of precision about the actual frame format
used
..
codec/ecu: Add a bit of precision about the actual
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13992 )
Change subject: make LOG_TRANS() NULL-safe again
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13992
To unsubscribe
tnt has posted comments on this change. ( https://gerrit.osmocom.org/9598 )
Change subject: transceiver: RSSI was calculated reverse.
..
Patch Set 2: Code-Review-2
Spec for TRX interface specifies it as being reverse logic
tnt has abandoned this change. ( https://gerrit.osmocom.org/13963 )
Change subject: libmsc: Make sure to not dereference a NULL trans
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/13963
To unsubscribe, or for help
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13961 )
Change subject: gsm_23_003: add GSM23003_MSISDN_{MIN,MAX}_DIGITS
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13961
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13963
Change subject: libmsc: Make sure to not dereference a NULL trans
..
libmsc: Make sure to not dereference a NULL trans
All those were identified
tnt has posted comments on this change. ( https://gerrit.osmocom.org/9598 )
Change subject: transceiver: RSSI was calculated reverse.
..
Patch Set 2:
The 'RSSI' definitely seems to be 'opposite' logic ... not sure why
tnt has posted comments on this change. ( https://gerrit.osmocom.org/14050 )
Change subject: Make sure to default to AMR octet-aligned mode
..
Patch Set 1: Code-Review+1
lgtm. Also tested the patch and works.
--
To view
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13818 )
Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x
..
Patch Set 1: Code-Review+1
Yeah fix seems obviously correct
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13809 )
Change subject: cosmetic: uhd: Move smpl_buf out of UHDDevice, move UHDDevice
class definition to .h
..
Patch Set 1: Code-Review+1
I would probably
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13833 )
Change subject: uhd: No need to use dynamic mem for rx_buffers
..
Patch Set 1: Code-Review-1
(1 comment)
I'd like to make sure you tried running
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13829 )
Change subject: cosmetic: uhd: Use loglevel ERROR instead of ERR
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13829
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13831 )
Change subject: Move smpl_buf out of uhd dir to re-use it in other devices
..
Patch Set 1: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13810 )
Change subject: uhd: smpl_buf: Drop UHD specifics out back to UHDDevice
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13832 )
Change subject: device: Drop unused numberRead/numberWritten APIs
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13832
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13828 )
Change subject: uhd: smpl_buf: Use TIMESTAMP type in str_status
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13828
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13872 )
Change subject: lms: Use smpl_buf to recover from timestamp jumps
..
Patch Set 2:
(1 comment)
Globally looks good, just minor naming convention
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/14674 )
Change subject: Add C/I computation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/14613 )
Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU
..
Patch Set 3: Code-Review+1
(1 comment)
This change
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/14726 )
Change subject: contrib/jenkins.sh: run "make maintainer-clean"
..
Patch Set 1: Verified+1
--
To view, v
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/14726 )
Change subject: contrib/jenkins.sh: run "make maintainer-clean"
..
Patch Set 1: Code-Review+2
--
To view, v
tnt has removed a vote on this change.
Change subject: contrib/jenkins.sh: run "make maintainer-clean"
..
Removed Verified-1 by Jenkins Builder (102)
--
To view, visit https://gerrit.osmocom.org/c/osmo-e
tnt has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-e1d/+/14726 )
Change subject: contrib/jenkins.sh: run "make maintainer-clean"
..
contrib/jenkins.sh: run "make maintainer-clea
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/17054 )
Change subject: OM2000: Add some more message types and IEs we now understand
..
Patch Set 1: Code-Review+1
lgtm
--
To view, visit
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16825 )
Change subject: e1d: Implement varions non-LAPD timeslot modes
..
Patch Set 4: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16824 )
Change subject: e1d: Don't connect to e1d at program start time
..
Patch Set 2: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16823 )
Change subject: e1d: Use LOGPIL/LOGPITS logging macros to give context
..
Patch Set 2: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16820 )
Change subject: e1d: Remove EXCEPTFD handling
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16822 )
Change subject: e1d: Use line->port_nr to specify e1d interface/line
..
Patch Set 2: Code-Review+1
--
To view, visit ht
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16819 )
Change subject: e1d: Don't use perror() directly, use osmocom logging instead
..
Patch Set 2: Code-Review+1
--
To view, visit
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16821 )
Change subject: e1d: Remove bogus vty_show function.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/14868 )
Change subject: e1d: Use HAVE_E1D in C source, not ENABLE_E1D
..
Patch Set 3: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/16825 )
Change subject: e1d: Implement varions non-LAPD timeslot modes
..
Patch Set 2: Code-Review-1
(1 comment)
https
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/14869 )
Change subject: e1d: add missing forward-declaration of e1inp_e1d_init()
..
Patch Set 3: Code-Review+1
--
To view, visit https
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/14867 )
Change subject: e1d: Initial osmo-e1d support
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/17993 )
Change subject: configure.ac: Fix HAVE_CLOCK_GETTIME undef when func in -lrt
..
Patch Set 1: Code-Review+1
LGTM and works on both
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18009 )
Change subject: bts_nokia_site: Fix LAPD segfault during reset procedure
..
Patch Set 1:
Just tested this and it fixed the segfault
tnt has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/17959 )
Change subject: om2k: Add definitions for the TG object
..
om2k: Add definitions for the TG object
Signed-off-by: Sylvain Munaut
tnt has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/17960 )
Change subject: om2k: Allow TG and MCTR to be manipulated via VTY
..
om2k: Allow TG and MCTR to be manipulated via VTY
Signed-off
tnt has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/17961 )
Change subject: om2k: Allow the CON configuration request to be triggered via
VTY
..
om2k: Allow the CON configuration request
1 - 100 of 584 matches
Mail list logo
