Review at https://gerrit.osmocom.org/7845
protocol/gsm_04_08.h: drop incorrect GSM48_PDISC_USSD
According to the GSM TS 04.07, section 11.2.3.1.1 "Protocol
discriminator", bits 1 to 4 of the first octet of a standard
L3 message contain the protocol discriminator IE.
Meanwhile, the GSM48_PDISC_USSD represents value 0x11, i.e.
0b10001, that requires 5 bits, and moreover it is not
documented anywhere. Let's drop it.
Change-Id: Ic4eb8a6db4ff1dfd535bd0c84e7acf1908422f64
---
M include/osmocom/gsm/protocol/gsm_04_08.h
M src/gsm/gsm48.c
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/7845/1
diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h
b/include/osmocom/gsm/protocol/gsm_04_08.h
index 6a5fb3b..68ba650 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -977,7 +977,6 @@
#define GSM48_PDISC_EXTEND 0x0e
#define GSM48_PDISC_TEST 0x0f /* as per 11.10, 04.14 */
#define GSM48_PDISC_MASK 0x0f
-#define GSM48_PDISC_USSD 0x11
extern const struct value_string gsm48_pdisc_names[];
static inline const char *gsm48_pdisc_name(uint8_t val)
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 468b2a9..0bce1ed 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -775,7 +775,6 @@
{ GSM48_PDISC_LOC, "LCS" },
{ GSM48_PDISC_EXTEND, "EXTD" },
{ GSM48_PDISC_MASK, "MASK" },
- { GSM48_PDISC_USSD, "USSD" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/7845
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4eb8a6db4ff1dfd535bd0c84e7acf1908422f64
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
