[PATCH] osmo-ttcn3-hacks[master]: improve failure diagnostics in TC_vty_msisdn_isd HLR test

[Stefan Sperling]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7684

to look at the new patch set (#2).

improve failure diagnostics in TC_vty_msisdn_isd HLR test

Check for reception of an Insert Subscriber Data with outdated MSISDN.
This happened to me while working on a fix for issue OS#2785, and it
seems to be an easy mistake implementations can make. Catch this
situation in the test and log an explicit message about the problem.

Related: OS#2785
Change-Id: Ib0809617cca621cc22f29b078828057fd49f27e5
---
M hlr/HLR_Tests.ttcn
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/84/7684/2

diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 8b21626..90a00bf 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -480,6 +480,10 @@
sub.msisdn := new_msisdn;
setverdict(pass);
}
+   [] GSUP.receive(tr_GSUP_ISD_REQ(sub.imsi, sub.msisdn)) {
+   log("received ISD req with old MSISDN");
+   setverdict(fail);
+   }
[] GSUP.receive { repeat; }
[] T.timeout {
setverdict(fail, "Timeout waiting for ISD.req");

-- 
To view, visit https://gerrit.osmocom.org/7684
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0809617cca621cc22f29b078828057fd49f27e5
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-ttcn3-hacks[master]: improve failure diagnostics in TC_vty_msisdn_isd HLR test

[Stefan Sperling]

Review at  https://gerrit.osmocom.org/7684

improve failure diagnostics in TC_vty_msisdn_isd HLR test

Check for reception of an Insert Subscriber Data with outdated MSISDN.
This happened to me while working on a fix for issue OS#2785, and it
seems to be an easy mistake implementations can make. Catch this
situation in the test and log an explicit message about the problem.

Related: OS#2785
Change-Id: Ib0809617cca621cc22f29b078828057fd49f27e5
---
M hlr/HLR_Tests.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/84/7684/1

diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 8b21626..c4b3ffb 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -480,6 +480,12 @@
sub.msisdn := new_msisdn;
setverdict(pass);
}
+   [] GSUP.receive(tr_GSUP_ISD_REQ(sub.imsi, sub.msisdn)) {
+   log("received ISD req with old MSISDN");
+   GSUP.send(ts_GSUP_ISD_RES(sub.imsi));
+   sub.msisdn := new_msisdn;
+   setverdict(fail);
+   }
[] GSUP.receive { repeat; }
[] T.timeout {
setverdict(fail, "Timeout waiting for ISD.req");

-- 
To view, visit https://gerrit.osmocom.org/7684
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0809617cca621cc22f29b078828057fd49f27e5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling