[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

2024-11-25 Thread lynxis lazus 
lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email )

Change subject: L3_Templates: RAU Request: add support for MS Network Capability
..

L3_Templates: RAU Request: add support for MS Network Capability

The MS Network Capability is important to determine the UMTS auth capability
as well the R99 support.

Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
---
M library/L3_Templates.ttcn
1 file changed, 19 insertions(+), 2 deletions(-)

Approvals:
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified




diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index 52b1f72..fd68fcd 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -171,6 +171,22 @@
}
 }

+function ts_GMM_MsNetCapTLV(template (omit) MSNetworkCapabilityV 
ms_network_cap) return template (omit) MSNetworkCapabilityTLV {
+   var template (omit) MSNetworkCapabilityTLV ret;
+   if (istemplatekind(ms_network_cap, "omit")) {
+   return omit;
+   } else {
+   ret := {
+   elementIdentifier := '31'O,
+   mSNetworkCapabilityLV := {
+   lengthIndicator := 0, /* overwritten */
+   msNetworkCapabilityV := ms_network_cap
+   }
+   }
+   return ret;
+   }
+}
+
 /* send template for Mobile Identity (TMSI) */
 function ts_MI_TMSI_TLV(template (omit) OCT4 tmsi) return template (omit) 
MobileIdentityTLV {
var template (omit) MobileIdentityTLV ret;
@@ -2620,7 +2636,8 @@
  template (omit) P_TMSISignatureTV p_tmsi_sig := omit,
  template (omit) P_TMSI_TypeTV p_tmsi_type := omit,
  template (omit) MobileIdentityTLV add_p_tmsi := omit,
- template (omit) RoutingAreaIdentification2TLV add_rai 
:= omit
+ template (omit) RoutingAreaIdentification2TLV add_rai 
:= omit,
+ template (omit) MSNetworkCapabilityV ms_network_cap 
:= omit
) := {
discriminator := ''B, /* overwritten */
tiOrSkip := {
@@ -2639,7 +2656,7 @@
drxParameter := omit,
tmsiStatus := omit,
ptmsi := ts_MI_TMSI_TLV(p_tmsi),
-   mSNetworkCapability := omit,
+   mSNetworkCapability := 
ts_GMM_MsNetCapTLV(ms_network_cap),
pdpContextStatus := omit, /* TODO */
pC_LCSCapability := omit,
mBMS_ContextStatus := omit,

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
Gerrit-Change-Number: 38916
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

2024-11-25 Thread daniel 
Attention is currently required from: lynxis lazus.

daniel has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email )

Change subject: L3_Templates: RAU Request: add support for MS Network Capability
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
Gerrit-Change-Number: 38916
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Mon, 25 Nov 2024 14:43:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

2024-11-25 Thread pespin 
Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email )

Change subject: L3_Templates: RAU Request: add support for MS Network Capability
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
Gerrit-Change-Number: 38916
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Mon, 25 Nov 2024 10:00:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

2024-11-24 Thread lynxis lazus 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: L3_Templates: RAU Request: add support for MS Network Capability
..

L3_Templates: RAU Request: add support for MS Network Capability

The MS Network Capability is important to determine the UMTS auth capability
as well the R99 support.

Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
---
M library/L3_Templates.ttcn
1 file changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/16/38916/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
Gerrit-Change-Number: 38916
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

2024-11-24 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email )


Change subject: L3_Templates: RAU Request: add support for MS Network Capability
..

L3_Templates: RAU Request: add support for MS Network Capability

The MS Network Capability is important to determine the UMTS auth capability
as well the R99 support.

Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
---
M library/L3_Templates.ttcn
1 file changed, 18 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/16/38916/1

diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index be15f57..fd68fcd 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -171,6 +171,22 @@
}
 }

+function ts_GMM_MsNetCapTLV(template (omit) MSNetworkCapabilityV 
ms_network_cap) return template (omit) MSNetworkCapabilityTLV {
+   var template (omit) MSNetworkCapabilityTLV ret;
+   if (istemplatekind(ms_network_cap, "omit")) {
+   return omit;
+   } else {
+   ret := {
+   elementIdentifier := '31'O,
+   mSNetworkCapabilityLV := {
+   lengthIndicator := 0, /* overwritten */
+   msNetworkCapabilityV := ms_network_cap
+   }
+   }
+   return ret;
+   }
+}
+
 /* send template for Mobile Identity (TMSI) */
 function ts_MI_TMSI_TLV(template (omit) OCT4 tmsi) return template (omit) 
MobileIdentityTLV {
var template (omit) MobileIdentityTLV ret;
@@ -2621,6 +2637,7 @@
  template (omit) P_TMSI_TypeTV p_tmsi_type := omit,
  template (omit) MobileIdentityTLV add_p_tmsi := omit,
  template (omit) RoutingAreaIdentification2TLV add_rai 
:= omit,
+ template (omit) MSNetworkCapabilityV ms_network_cap 
:= omit
) := {
discriminator := ''B, /* overwritten */
tiOrSkip := {
@@ -2639,7 +2656,7 @@
drxParameter := omit,
tmsiStatus := omit,
ptmsi := ts_MI_TMSI_TLV(p_tmsi),
-   mSNetworkCapability := omit,
+   mSNetworkCapability := 
ts_GMM_MsNetCapTLV(ms_network_cap),
pdpContextStatus := omit, /* TODO */
pC_LCSCapability := omit,
mBMS_ContextStatus := omit,

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb
Gerrit-Change-Number: 38916
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus