[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
..
PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
After removing a NS-VC via SNS-DEL, the NS-VC shouldn't receive
any further NS PDUs.
Related: OS#6611
Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
---
M pcu/PCU_Tests_SNS.ttcn
1 file changed, 26 insertions(+), 4 deletions(-)
Approvals:
lynxis lazus: Looks good to me, approved
daniel: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn
index 07f147c..3e7f81c 100644
--- a/pcu/PCU_Tests_SNS.ttcn
+++ b/pcu/PCU_Tests_SNS.ttcn
@@ -328,13 +328,35 @@
}
/* Test deleting IP endpoints at runtime */
+function f_TC_sns_del(integer idx := 0, integer idx_del := 1, float tout :=
20.0) runs on RAW_Test_CT {
+ g_handle_rx_alive := true;
+ f_outgoing_sns_del(idx_del := idx_del, w_sig := 0, w_user := 1, idx :=
idx);
+ g_handle_rx_alive := false;
+
+ /* A small grace period to prevent race conditions */
+ timer Tgrace := 1.0;
+ Tgrace.start;
+ alt {
+ [] NSCP[idx_del].receive(t_NS_ALIVE) {}
+ [] Tgrace.timeout {}
+ }
+
+ /* Fail on any NS PDUs */
+ timer T := tout;
+ T.start;
+ alt {
+ [] ax_rx_fail_on_any_ns(idx_del) {}
+ [] T.timeout {
+ setverdict(pass);
+ }
+ }
+}
+
testcase TC_sns_del() runs on RAW_Test_CT {
f_sns_bringup_1c1u();
- g_handle_rx_alive := true;
- f_outgoing_sns_del(idx_del := 1, w_sig := 0, w_user := 1, idx := 0);
- /* FIXME: ensure we don't receive anything on just-deleted NS-VC
anymore */
- setverdict(pass);
+ f_TC_sns_del();
+
f_clean_ns_codec();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 3: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/3ee67b7a_7c4e36a2?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > > "we've never done it this way, never change a running system" […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 06 Jan 2025 18:29:45 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 06 Jan 2025 18:29:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 18 Dec 2024 15:22:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Thu, 05 Dec 2024 13:22:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/11786ae6_0064f7ed?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > "we've never done it this way, never change a running system" No, I already explained the reasons why we do it this way so far (TC_control, identifying tests, run test through .cfg file). If you want to change the way we do it, please test and provide that your new way of doing things doesn't also include those problems I was mentioning. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Thu, 05 Dec 2024 13:21:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits After removing a NS-VC via SNS-DEL, the NS-VC shouldn't receive any further NS PDUs. Related: OS#6611 Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/39011/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: pespin
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/e4afa3e3_8866abf8?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 @pes...@sysmocom.de this is our test code. If there are unknown and unforseen side effect, we should know it. > I'm sorry but I don't think it's good to start using parameters in testcase > with no real good reason or improvement. This may actually cause more > unforeseen problems than good things. This sounds to me "we've never done it this way, never change a running system", which I don't see as valid argument. > Well, then the point is: if parameters are not changed, why passing > parameters instead of declaring them as variables... For me it makes the code more clearer/readable, defining essential variables as test case parameters and "promote" these variable to testcase parameters. Further it would have make it easier to split it into a testcase and a function. I'm not arguing here where to use testcase parameter in control() or not. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Thu, 05 Dec 2024 13:17:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/af3277b0_ba30b14c?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > I'm sorry but I don't think it's good to start using parameters in testcase > with no real good reason [...] It's good to know that one can pass arguments to testcases; ETSI ES 201 873-1 V4.16.1 confirms this is possible in section 26.1. But I agree with @pes...@sysmocom.de here. It needs to be researched further how the resulting junit xml file would look like. And in this specific case, you're not calling `TC_sns_del` with different parameters in the `control` section, so unless you're planning to do so I don't see a reason for having those params. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 20:17:41 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/ff085846_997d13d4?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > So if you have in TC_ctrl: […] I didn't propose to use the parameters somewhere. They are there for readability. If someone would need as function, it would be easy to convert. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 04 Dec 2024 17:16:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/6ead1b70_cf1f108e?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > I didn't propose to use the parameters somewhere. They are there for > readability. […] Well, then the point is: if parameters are not changed, why passing parameters instead of declaring them as variables... I'm sorry but I don't think it's good to start using parameters in *testcase* with no real good reason or improvement. This may actually cause more unforeseen problems than good things. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 17:19:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/4389a2fc_152906a7?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > You have to recompile anyways if you want to change it. […] So if you have in TC_ctrl: execute( TC_sns_del(tout := 10.0) ); execute( TC_sns_del(tout := 25.0) ); How do they show in the junit xml file? they show with the same name? how do you differentaite them when seeing them in jenkins analytics? See all the kind of things I'm bringing up which you didn't actually accounted for? Having different names for same test with different parameters allows for that, instead of passing parameters to it that way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 17:06:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/83fefd29_d7a039da?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > You have to recompile anyways if you want to change it. […] *functionality. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 04 Dec 2024 17:05:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/3183d6c3_ef5e6276?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > But you cannot run such a test from the . […] You have to recompile anyways if you want to change it. There isn't even a coding style for ttcn3 in osmocom AFAIK. This is a style discussion. It would work the same if those are variables within the testcase. There aren't any downsides in function. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 04 Dec 2024 17:02:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/cf3ece32_c986601a?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > > But if you want to use it by another test you can set those. […] Yes, same here. I don't get your point, what is wrong here. So far I get, you would done it different. I like to have arguments to a test case, which I find useful and could be converted into a function later if necessary. The language allows such things. Further it also allows the following: ``` execute( TC_sns_add_nack() ); - execute( TC_sns_del() ); + execute( TC_sns_del(tout := 25.0) ); execute( TC_sns_chg_weight() ); ``` It feels completely bike shred here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 04 Dec 2024 16:22:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/e882b4ca_15540026?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > Yes, same here. I don't get your point, what is wrong here. […] But you cannot run such a test from the .cfg file, that's my point and the reason why we didn't use this syntax so far. Hence why we have a *function* implementing the test with params, and then we have a *testcase* calling the function with specific params inside it, so you can run from .cfg file it without recompiling. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 16:41:16 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/5da27363_86c457b9?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > But if you want to use it by another test you can set those. Not sure what you mean here. This is a test itself, not a function... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 15:55:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/06fbcfea_47a66d9a?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > The problem with this is that when you want to run a single test, eg by > putting it in PCU_Tests_SNS. […] But if you want to use it by another test you can set those. I don't see/understand you point here. It works and IMHO: make it more clear that those are test input which are more important than other variables -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 04 Dec 2024 15:02:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 2: (1 comment) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/cf48e1df_1f9fc8b7?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > For me it makes it more clear that those are test input. […] The problem with this is that when you want to run a single test, eg by putting it in PCU_Tests_SNS.ttcn, you cannot pass parameters this way. We are not doing this anywhere for such reasons, and I think we shouldn't start now unless this has been properly validated. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 14:49:34 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits After removing a NS-VC via SNS-DEL, the NS-VC shouldn't receive any further NS PDUs. Related: OS#6611 Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/39011/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 1: (2 comments) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/74fdb855_949056ef?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 > What's the point of adding testcase parameters? […] For me it makes it more clear that those are test input. I think you can even set those when starting the test. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/dae6c6d5_c00d123c?usp=email : PS1, Line 347: setverdict(fail, "Received unexpected NS-ALIVE ACK"); > As the name suggests, `ax_rx_fail_on_any_ns()` already does `setverdict(fail, > ... […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 04 Dec 2024 14:47:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 1: (2 comments) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/75231a20_18bb6e85?usp=email : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 What's the point of adding testcase parameters? I am not sure if there is a way to pass any parameters when executing a testcase... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/c969fc33_157050e4?usp=email : PS1, Line 347: setverdict(fail, "Received unexpected NS-ALIVE ACK"); As the name suggests, `ax_rx_fail_on_any_ns()` already does `setverdict(fail, ...)` internally, so this additional `setverdict()` is redundant. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 04 Dec 2024 11:07:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Tue, 03 Dec 2024 15:16:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
..
PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
After removing a NS-VC via SNS-DEL, the NS-VC shouldn't receive
any further NS PDUs.
Related: OS#6611
Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
---
M pcu/PCU_Tests_SNS.ttcn
1 file changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/11/39011/1
diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn
index 263e205..5464374 100644
--- a/pcu/PCU_Tests_SNS.ttcn
+++ b/pcu/PCU_Tests_SNS.ttcn
@@ -324,13 +324,33 @@
}
/* Test deleting IP endpoints at runtime */
-testcase TC_sns_del() runs on RAW_Test_CT {
+testcase TC_sns_del(integer idx := 0, integer idx_del := 1, float tout :=
20.0) runs on RAW_Test_CT {
f_sns_bringup_1c1u();
g_handle_rx_alive := true;
- f_outgoing_sns_del(idx_del := 1, w_sig := 0, w_user := 1, idx := 0);
- /* FIXME: ensure we don't receive anything on just-deleted NS-VC
anymore */
- setverdict(pass);
+ f_outgoing_sns_del(idx_del := idx_del, w_sig := 0, w_user := 1, idx :=
idx);
+ g_handle_rx_alive := false;
+
+ /* A small grace period to prevent race conditions */
+ timer Tgrace := 1.0;
+ Tgrace.start;
+ alt {
+ [] NSCP[idx_del].receive(t_NS_ALIVE) {}
+ [] Tgrace.timeout {}
+ }
+
+ /* Fail on any NS PDUs */
+ timer T := tout;
+ T.start;
+ alt {
+ [] ax_rx_fail_on_any_ns(idx_del) {
+ setverdict(fail, "Received unexpected NS-ALIVE ACK");
+ }
+ [] T.timeout {
+ setverdict(pass);
+ }
+ }
+
f_clean_ns_codec();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
