[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-11-10 Thread jolly 
jolly has submitted this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )

Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..

ASCI: Notify talker in the VTY that he cannot leave the call while talking

Related: OS#5364
Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
---
M src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  pespin: Looks good to me, approved




diff --git a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c 
b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
index 65e016d..3a4db3a 100644
--- a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
+++ b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
@@ -1855,6 +1855,8 @@
trans->gcc.fi->state == VGCS_GCC_ST_U2sl_GROUP_CALL_ACTIVE ||
trans->gcc.fi->state == VGCS_GCC_ST_U5_TERMINATION_REQUESTED) {
LOG_GCC(trans, LOGL_NOTICE, "Cannot leave (abort), in this 
state.\n");
+   if (trans->gcc.fi->state == VGCS_GCC_ST_U2sl_GROUP_CALL_ACTIVE)
+   vgcs_vty_notify(trans, "Cannot leave while talking\n");
return -EINVAL;
}


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 3
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: jolly 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-30 Thread pespin 
Attention is currently required from: fixeria, jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )

Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 30 Oct 2023 15:21:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-30 Thread laforge 
Attention is currently required from: fixeria, jolly, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )

Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 30 Oct 2023 15:09:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-30 Thread jolly 
Attention is currently required from: fixeria, pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )

Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..


Patch Set 1:

(1 comment)

File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34906/comment/49bcb13d_ca495d79
PS1, Line 1854: vgcs_vty_notify(trans, "Cannot leave while 
talking\n");
> shouldn't this be returning an error instead of changing state below?
It returns an error. I moved the statements (as we discussed in the chat) 
inside the if-block.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 30 Oct 2023 12:35:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-30 Thread jolly 
Attention is currently required from: fixeria, jolly.

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder


Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..

ASCI: Notify talker in the VTY that he cannot leave the call while talking

Related: OS#5364
Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
---
M src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/06/34906/2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-27 Thread pespin 
Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )

Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..


Patch Set 1:

(1 comment)

File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34906/comment/7968503b_8b8c86b6
PS1, Line 1854: vgcs_vty_notify(trans, "Cannot leave while 
talking\n");
shouldn't this be returning an error instead of changing state below?



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 27 Oct 2023 13:18:07 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-27 Thread fixeria 
Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )

Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 27 Oct 2023 07:27:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...

2023-10-27 Thread jolly 
jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )


Change subject: ASCI: Notify talker in the VTY that he cannot leave the call 
while talking
..

ASCI: Notify talker in the VTY that he cannot leave the call while talking

Related: OS#5364
Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
---
M src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/06/34906/1

diff --git a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c 
b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
index 4fe0b82..1941d18 100644
--- a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
+++ b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
@@ -1850,6 +1850,8 @@
return -EINVAL;
}

+   if (trans->gcc.fi->state == VGCS_GCC_ST_U2sl_GROUP_CALL_ACTIVE)
+   vgcs_vty_notify(trans, "Cannot leave while talking\n");
if (trans->gcc.fi->state == VGCS_GCC_ST_U0p_MM_CONNECTION_PENDING ||
trans->gcc.fi->state == VGCS_GCC_ST_U1_GROUP_CALL_INITIATED ||
trans->gcc.fi->state == VGCS_GCC_ST_U2sl_GROUP_CALL_ACTIVE ||

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange