[XS] Change in osmo-sgsn[master]: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gp...

2024-11-20 Thread daniel 
Attention is currently required from: fixeria, pespin.

daniel has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email )

Change subject: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum 
gsm48_gprs_ie_mm
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 19 Nov 2024 18:37:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

[XS] Change in osmo-sgsn[master]: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gp...

2024-11-20 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email )

Change subject: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum 
gsm48_gprs_ie_mm
..

gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gprs_ie_mm

Depends: libosmocore.git a28ae056435b0de575441f7608101117d1beda0c
Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
---
M TODO-RELEASE
M src/sgsn/gprs_gmm_util.c
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved




diff --git a/TODO-RELEASE b/TODO-RELEASE
index eb1cdfd..261da7b 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -9,3 +9,4 @@
 #library   whatdescription / commit summary line
 libgtp>1.12.0   new field dir_tun_flags in struct pdp_t
 libgtp>1.12.0 gtp_set_cb_update_context_ind(), gtp_update_context_resp()
+libosmocore >1.10.0  enum gsm48_gprs_ie_mm: GSM48_IE_GMM_UE_NET_CAP, 
GSM48_IE_GMM_VD_PREF_UE_USAGE
diff --git a/src/sgsn/gprs_gmm_util.c b/src/sgsn/gprs_gmm_util.c
index 107fcef..4a59c37 100644
--- a/src/sgsn/gprs_gmm_util.c
+++ b/src/sgsn/gprs_gmm_util.c
@@ -56,6 +56,8 @@
[GSM48_IE_GMM_PS_LCS_CAPA]  = { TLV_TYPE_TLV, 0 },
[GSM48_IE_GMM_GMM_MBMS_CTX_ST]  = { TLV_TYPE_TLV, 0 },
[GSM48_IE_GMM_TIMER_T3346]  = { TLV_TYPE_TLV, 0 },
+   [GSM48_IE_GMM_UE_NET_CAP]   = { TLV_TYPE_TLV, 0 },
+   [GSM48_IE_GMM_VD_PREF_UE_USAGE] = { TLV_TYPE_TLV, 0 },
[GSM48_IE_GMM_NET_FEAT_SUPPORT] = { TLV_TYPE_SINGLE_TV, 1 },
},
 };

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin

[XS] Change in osmo-sgsn[master]: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gp...

2024-11-20 Thread pespin 
Attention is currently required from: fixeria, lynxis lazus.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email )

Change subject: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum 
gsm48_gprs_ie_mm
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 20 Nov 2024 13:03:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

[XS] Change in osmo-sgsn[master]: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gp...

2024-11-19 Thread pespin 
Attention is currently required from: fixeria, pespin.

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified-1 by Jenkins Builder


Change subject: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum 
gsm48_gprs_ie_mm
..

gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gprs_ie_mm

Depends: libosmocore.git a28ae056435b0de575441f7608101117d1beda0c
Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
---
M TODO-RELEASE
M src/sgsn/gprs_gmm_util.c
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/30/38830/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin

[XS] Change in osmo-sgsn[master]: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gp...

2024-11-19 Thread fixeria 
Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email )

Change subject: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum 
gsm48_gprs_ie_mm
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 19 Nov 2024 18:14:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

[XS] Change in osmo-sgsn[master]: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gp...

2024-11-19 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email )


Change subject: gsm48_gmm_ie_tlvdef: Add newer definitions from current enum 
gsm48_gprs_ie_mm
..

gsm48_gmm_ie_tlvdef: Add newer definitions from current enum gsm48_gprs_ie_mm

Depends: libosmocore.git a28ae056435b0de575441f7608101117d1beda0c
Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
---
M TODO-RELEASE
M src/sgsn/gprs_gmm_util.c
2 files changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/30/38830/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index eb1cdfd..55ba1ea 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -9,3 +9,4 @@
 #library   whatdescription / commit summary line
 libgtp>1.12.0   new field dir_tun_flags in struct pdp_t
 libgtp>1.12.0 gtp_set_cb_update_context_ind(), gtp_update_context_resp()
+libosmocore >1.10.0  enum gsm48_gprs_ie_mm: GSM48_IE_GMM_UE_NET_CAP, 
GSM48_IE_GMM_VD_PREF_UE_USAGE
\ No newline at end of file
diff --git a/src/sgsn/gprs_gmm_util.c b/src/sgsn/gprs_gmm_util.c
index 107fcef..4a59c37 100644
--- a/src/sgsn/gprs_gmm_util.c
+++ b/src/sgsn/gprs_gmm_util.c
@@ -56,6 +56,8 @@
[GSM48_IE_GMM_PS_LCS_CAPA]  = { TLV_TYPE_TLV, 0 },
[GSM48_IE_GMM_GMM_MBMS_CTX_ST]  = { TLV_TYPE_TLV, 0 },
[GSM48_IE_GMM_TIMER_T3346]  = { TLV_TYPE_TLV, 0 },
+   [GSM48_IE_GMM_UE_NET_CAP]   = { TLV_TYPE_TLV, 0 },
+   [GSM48_IE_GMM_VD_PREF_UE_USAGE] = { TLV_TYPE_TLV, 0 },
[GSM48_IE_GMM_NET_FEAT_SUPPORT] = { TLV_TYPE_SINGLE_TV, 1 },
},
 };

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I38dc87bcaa23a5c4ec36ae4ab082b150dad93840
Gerrit-Change-Number: 38830
Gerrit-PatchSet: 1
Gerrit-Owner: pespin