Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-09 Thread fixeria 
fixeria has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15709 )

Change subject: L1SAP: clarify debug messages in rach_pass_filter()
..

L1SAP: clarify debug messages in rach_pass_filter()

RACH stands for Random Access CHannel, while in rach_pass_filter()
we're dealing with Access Bursts, that may be received on other
logical channels too (e.g. PTCCH, PDTCH or any other).

Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
---
M src/common/l1sap.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index ac1c99d..54953b0 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1258,7 +1258,7 @@

/* Check for RACH exceeding BER threshold (ghost RACH) */
if (rach_ind->ber10k > bts->max_ber10k_rach) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access 
Burst: "
"BER10k(%u) > BER10k_MAX(%u)\n",
rach_ind->ber10k, bts->max_ber10k_rach);
return false;
@@ -1270,7 +1270,7 @@
 * according to maximal allowed Timing Advance value.
 */
if (toa256 < RACH_MIN_TOA256 || toa256 > bts->max_ta * 256) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access 
Burst: "
"ToA(%d) exceeds the allowed range (%d..%d)\n",
toa256, RACH_MIN_TOA256, bts->max_ta * 256);
return false;
@@ -1278,7 +1278,7 @@

/* Link quality defined by C/I (Carrier-to-Interference ratio) */
if (rach_ind->lqual_cb < bts->min_qual_rach) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access 
Burst: "
"link quality (%d) below the minimum (%d)\n",
rach_ind->lqual_cb, bts->min_qual_rach);
return false;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
Gerrit-Change-Number: 15709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15709 )

Change subject: L1SAP: clarify debug messages in rach_pass_filter()
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15709/1/src/common/l1sap.c
File src/common/l1sap.c:

https://gerrit.osmocom.org/#/c/15709/1/src/common/l1sap.c@1261
PS1, Line 1261: LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring 
an Access Burst: "
Wondering if it's also possible to print the channel then too.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
Gerrit-Change-Number: 15709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 10:58:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15709 )

Change subject: L1SAP: clarify debug messages in rach_pass_filter()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
Gerrit-Change-Number: 15709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 10:58:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-08 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15709 )

Change subject: L1SAP: clarify debug messages in rach_pass_filter()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
Gerrit-Change-Number: 15709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 08 Oct 2019 20:26:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-08 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15709


Change subject: L1SAP: clarify debug messages in rach_pass_filter()
..

L1SAP: clarify debug messages in rach_pass_filter()

RACH stands for Random Access CHannel, while in rach_pass_filter()
we're dealing with Access Bursts, that may be received on other
logical channels too (e.g. PTCCH, PDTCH or any other).

Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
---
M src/common/l1sap.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/15709/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index ac1c99d..54953b0 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1258,7 +1258,7 @@

/* Check for RACH exceeding BER threshold (ghost RACH) */
if (rach_ind->ber10k > bts->max_ber10k_rach) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access 
Burst: "
"BER10k(%u) > BER10k_MAX(%u)\n",
rach_ind->ber10k, bts->max_ber10k_rach);
return false;
@@ -1270,7 +1270,7 @@
 * according to maximal allowed Timing Advance value.
 */
if (toa256 < RACH_MIN_TOA256 || toa256 > bts->max_ta * 256) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access 
Burst: "
"ToA(%d) exceeds the allowed range (%d..%d)\n",
toa256, RACH_MIN_TOA256, bts->max_ta * 256);
return false;
@@ -1278,7 +1278,7 @@

/* Link quality defined by C/I (Carrier-to-Interference ratio) */
if (rach_ind->lqual_cb < bts->min_qual_rach) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access 
Burst: "
"link quality (%d) below the minimum (%d)\n",
rach_ind->lqual_cb, bts->min_qual_rach);
return false;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e5ca9930ab491a6916c972865154d54530cbf51
Gerrit-Change-Number: 15709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange