Change in ...osmo-sgsn[master]: sgsn_pdp_ctx_terminate: check llme before accessing

2019-09-11 Thread lynxis lazus 
lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15467 )

Change subject: sgsn_pdp_ctx_terminate: check llme before accessing
..

sgsn_pdp_ctx_terminate: check llme before accessing

Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
---
M src/sgsn/gprs_sgsn.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c
index 189f7bb..465a5fa 100644
--- a/src/sgsn/gprs_sgsn.c
+++ b/src/sgsn/gprs_sgsn.c
@@ -459,7 +459,8 @@

if (pdp->mm->ran_type == MM_CTX_T_GERAN_Gb) {
/* Force the deactivation of the SNDCP layer */
-   sndcp_sm_deactivate_ind(>mm->gb.llme->lle[pdp->sapi], 
pdp->nsapi);
+   if (pdp->mm->gb.llme)
+   
sndcp_sm_deactivate_ind(>mm->gb.llme->lle[pdp->sapi], pdp->nsapi);
}

memset(_data, 0, sizeof(sig_data));

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15467
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
Gerrit-Change-Number: 15467
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-sgsn[master]: sgsn_pdp_ctx_terminate: check llme before accessing

2019-09-11 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15467 )

Change subject: sgsn_pdp_ctx_terminate: check llme before accessing
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15467
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
Gerrit-Change-Number: 15467
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 11 Sep 2019 06:19:58 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn_pdp_ctx_terminate: check llme before accessing

2019-09-10 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15467 )

Change subject: sgsn_pdp_ctx_terminate: check llme before accessing
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15467
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
Gerrit-Change-Number: 15467
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 10 Sep 2019 14:23:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn_pdp_ctx_terminate: check llme before accessing

2019-09-10 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15467


Change subject: sgsn_pdp_ctx_terminate: check llme before accessing
..

sgsn_pdp_ctx_terminate: check llme before accessing

Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
---
M src/sgsn/gprs_sgsn.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/67/15467/1

diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c
index 189f7bb..465a5fa 100644
--- a/src/sgsn/gprs_sgsn.c
+++ b/src/sgsn/gprs_sgsn.c
@@ -459,7 +459,8 @@

if (pdp->mm->ran_type == MM_CTX_T_GERAN_Gb) {
/* Force the deactivation of the SNDCP layer */
-   sndcp_sm_deactivate_ind(>mm->gb.llme->lle[pdp->sapi], 
pdp->nsapi);
+   if (pdp->mm->gb.llme)
+   
sndcp_sm_deactivate_ind(>mm->gb.llme->lle[pdp->sapi], pdp->nsapi);
}

memset(_data, 0, sizeof(sig_data));

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15467
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
Gerrit-Change-Number: 15467
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange