Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..

ttcn3-bts-test: Log fake_trx output to file

Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Verified



diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 1cd06e7..fe448f5 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -17,6 +17,8 @@

 mkdir $VOL_BASE_DIR/unix

+mkdir $VOL_BASE_DIR/fake_trx
+
 echo Starting container with BSC
 docker run --rm \
--network $NET_NAME --ip 172.18.9.11 \
@@ -37,9 +39,10 @@
 echo Starting container with fake_trx
 docker run --rm \
--network $NET_NAME --ip 172.18.9.21 \
+   -v $VOL_BASE_DIR/fake_trx:/data \
--name ${BUILD_TAG}-fake_trx -d \
$REPO_USER/osmocom-bb-host-master \
-   /tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py -R 
172.18.9.20 -r 172.18.9.22
+   bash -c "/tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py -R 
172.18.9.20 -r 172.18.9.22 >/data/fake_trx.log 2>&1"

 echo Starting container with trxcon
 docker run --rm \

--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 


Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-25 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:05:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-23 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 10:41:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-23 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1:

> Just wondering, why do we need that?

You could extend that to why do we need logging in general in any software 
component ;)

I used it to see log from fake_trx to understand how it behaved and was useful 
to add some prints during development of the FAKE_RSSI command. This way I 
don't need to do that next time, or if fake_trx starts failing for whatever 
reason we can check quickly why it fails.


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 10:29:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-23 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1:

Just wondering, why do we need that?


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 09:14:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-22 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11431


Change subject: ttcn3-bts-test: Log fake_trx output to file
..

ttcn3-bts-test: Log fake_trx output to file

Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/31/11431/1

diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 1cd06e7..fe448f5 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -17,6 +17,8 @@

 mkdir $VOL_BASE_DIR/unix

+mkdir $VOL_BASE_DIR/fake_trx
+
 echo Starting container with BSC
 docker run --rm \
--network $NET_NAME --ip 172.18.9.11 \
@@ -37,9 +39,10 @@
 echo Starting container with fake_trx
 docker run --rm \
--network $NET_NAME --ip 172.18.9.21 \
+   -v $VOL_BASE_DIR/fake_trx:/data \
--name ${BUILD_TAG}-fake_trx -d \
$REPO_USER/osmocom-bb-host-master \
-   /tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py -R 
172.18.9.20 -r 172.18.9.22
+   bash -c "/tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py -R 
172.18.9.20 -r 172.18.9.22 >/data/fake_trx.log 2>&1"

 echo Starting container with trxcon
 docker run --rm \

--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol