Change in gr-gsm[master]: trx/radio_if.py: reset UHD device time at startup
Piotr Krysik has submitted this change and it was merged. (
https://gerrit.osmocom.org/10418 )
Change subject: trx/radio_if.py: reset UHD device time at startup
..
trx/radio_if.py: reset UHD device time at startup
Some UHD devices, such as UmTRX, require one to manually reset the
hardware clock, otherwise the burst transmission doesn't work.
Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315
---
M python/trx/radio_if.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Piotr Krysik: Looks good to me, approved; Verified
diff --git a/python/trx/radio_if.py b/python/trx/radio_if.py
index 355312b..119b237 100644
--- a/python/trx/radio_if.py
+++ b/python/trx/radio_if.py
@@ -257,6 +257,12 @@
(self.dict_toggle_sign, 'dict_out'),
(self.msg_to_tag_sink, 'msg'))
+
+ # Some UHD devices (such as UmTRX) do start the clock
+ # not from 0, so it's required to reset it manually.
+ # Resetting UHD source will also affect the sink.
+ self.phy_src.set_time_now(uhd.time_spec(0.0))
+
def shutdown(self):
print("[i] Shutdown Radio interface")
self.stop()
--
To view, visit https://gerrit.osmocom.org/10418
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315
Gerrit-Change-Number: 10418
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Piotr Krysik
Change in gr-gsm[master]: trx/radio_if.py: reset UHD device time at startup
Piotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/10418 ) Change subject: trx/radio_if.py: reset UHD device time at startup .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315 Gerrit-Change-Number: 10418 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Piotr Krysik Gerrit-Comment-Date: Fri, 10 Aug 2018 09:41:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in gr-gsm[master]: trx/radio_if.py: reset UHD device time at startup
Hello Piotr Krysik, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10418 to look at the new patch set (#2). Change subject: trx/radio_if.py: reset UHD device time at startup .. trx/radio_if.py: reset UHD device time at startup Some UHD devices, such as UmTRX, require one to manually reset the hardware clock, otherwise the burst transmission doesn't work. Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315 --- M python/trx/radio_if.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/18/10418/2 -- To view, visit https://gerrit.osmocom.org/10418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315 Gerrit-Change-Number: 10418 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Piotr Krysik
Change in gr-gsm[master]: trx/radio_if.py: reset UHD device time at startup
Piotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/10418 ) Change subject: trx/radio_if.py: reset UHD device time at startup .. Patch Set 1: Verified+1 Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/10418/1/python/trx/radio_if.py File python/trx/radio_if.py: https://gerrit.osmocom.org/#/c/10418/1/python/trx/radio_if.py@264 PS1, Line 264: self.phy_sink.set_time_now(uhd.time_spec(0.0)) set_time_now needs to be done only once, either for source or sink (I'm having fun with gerrit review window ;) ) -- To view, visit https://gerrit.osmocom.org/10418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315 Gerrit-Change-Number: 10418 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Piotr Krysik Gerrit-Comment-Date: Fri, 10 Aug 2018 09:27:17 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in gr-gsm[master]: trx/radio_if.py: reset UHD device time at startup
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/10418
Change subject: trx/radio_if.py: reset UHD device time at startup
..
trx/radio_if.py: reset UHD device time at startup
Some UHD devices, such as UmTRX, require one to manually reset the
hardware clock, otherwise the burst transmission doesn't work.
Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315
---
M python/trx/radio_if.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/18/10418/1
diff --git a/python/trx/radio_if.py b/python/trx/radio_if.py
index 355312b..83bfffe 100644
--- a/python/trx/radio_if.py
+++ b/python/trx/radio_if.py
@@ -257,6 +257,12 @@
(self.dict_toggle_sign, 'dict_out'),
(self.msg_to_tag_sink, 'msg'))
+
+ # Some UHD devices, such as UmTRX, require one
+ # to manually reset the hardware clock
+ self.phy_src.set_time_now(uhd.time_spec(0.0))
+ self.phy_sink.set_time_now(uhd.time_spec(0.0))
+
def shutdown(self):
print("[i] Shutdown Radio interface")
self.stop()
--
To view, visit https://gerrit.osmocom.org/10418
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idddc1387199bd22342ec5af25c8635e73352e315
Gerrit-Change-Number: 10418
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
