Change in libosmo-sccp[master]: sua: Export IEI value_string names

2018-07-12 Thread Pau Espin Pedrol 
Pau Espin Pedrol has abandoned this change. ( https://gerrit.osmocom.org/9959 )

Change subject: sua: Export IEI value_string names
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/9959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I0b34eaa2cb4109879324dc9ba6c7dacd53b1a28f
Gerrit-Change-Number: 9959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr

Change in libosmo-sccp[master]: sua: Export IEI value_string names

2018-07-11 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9959 )

Change subject: sua: Export IEI value_string names
..


Patch Set 1: Code-Review-1

it seems the intention of the API is to have IEI name definitions based on the 
xua_msg_type, so that the IEIs can differ based on the underlying transport 
layer. Publishing sua_iei_names bypasses the apparently carefully crafted API 
to avoid exactly that. (See where sua_iei_names gets used)


--
To view, visit https://gerrit.osmocom.org/9959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b34eaa2cb4109879324dc9ba6c7dacd53b1a28f
Gerrit-Change-Number: 9959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 11 Jul 2018 13:53:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: sua: Export IEI value_string names

2018-07-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9959


Change subject: sua: Export IEI value_string names
..

sua: Export IEI value_string names

Change-Id: I0b34eaa2cb4109879324dc9ba6c7dacd53b1a28f
---
M include/osmocom/sigtran/protocol/sua.h
M src/sua.c
2 files changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/59/9959/1

diff --git a/include/osmocom/sigtran/protocol/sua.h 
b/include/osmocom/sigtran/protocol/sua.h
index 70c16ba..592ad1c 100644
--- a/include/osmocom/sigtran/protocol/sua.h
+++ b/include/osmocom/sigtran/protocol/sua.h
@@ -158,3 +158,5 @@
 #define SUA_ERR_NO_CONFGD_AS_FOR_ASP   M3UA_ERR_NO_CONFGD_AS_FOR_ASP
 #define SUA_ERR_SUBSYS_STATUS_UNKN 0x1b
 #define SUA_ERR_INVAL_LOADSH_LEVEL 0x1c
+
+extern const struct value_string sua_iei_names[];
diff --git a/src/sua.c b/src/sua.c
index 4835665..f9c6acd 100644
--- a/src/sua.c
+++ b/src/sua.c
@@ -77,7 +77,7 @@
  * Protocol Definition (string tables, mandatory IE checking)
  ***/

-static const struct value_string sua_iei_names[] = {
+const struct value_string sua_iei_names[] = {
{ SUA_IEI_ROUTE_CTX,"Routing Context" },
{ SUA_IEI_CORR_ID,  "Correlation Id" },
{ SUA_IEI_REG_RESULT,   "Registration Result" },

--
To view, visit https://gerrit.osmocom.org/9959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b34eaa2cb4109879324dc9ba6c7dacd53b1a28f
Gerrit-Change-Number: 9959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol