Change in meta-telephony[201705]: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, enable i...

2019-12-03 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/meta-telephony/+/16427 )

Change subject: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, 
enable it by default
..

libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, enable it by 
default

Building with DAHDI support can be controlled by bbappend or config file
on the BSP meta layer as described here:
https://www.yoctoproject.org/docs/current/ref-manual/ref-manual.html#var-PACKAGECONFIG

Change-Id: I0d875896bc97e973489672f004cb49fae02bdd46
---
M recipes-osmocom/libosmo-abis/libosmo-abis.inc
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  pespin: Verified
  laforge: Looks good to me, approved



diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis.inc 
b/recipes-osmocom/libosmo-abis/libosmo-abis.inc
index dcfcbf7..955ebe3 100644
--- a/recipes-osmocom/libosmo-abis/libosmo-abis.inc
+++ b/recipes-osmocom/libosmo-abis/libosmo-abis.inc
@@ -2,13 +2,17 @@
 HOMEPAGE = "https://osmocom.org/projects/libosmo-abis;
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 DEPENDS = "libosmocore ortp libtalloc"
-DEPENDS_append_geode = "dahdi-linux"

 inherit autotools pkgconfig

+PACKAGECONFIG ??= "\
+dahdi \
+"
+PACKAGECONFIG[dahdi] = "--enable-dahdi,--disable-dahdi,dahdi-linux,"
+
 PACKAGES =+ "libosmotrau libosmotrau-dev"

 FILES_libosmotrau = "${libdir}/libosmotrau${SOLIBS}"

--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/16427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I0d875896bc97e973489672f004cb49fae02bdd46
Gerrit-Change-Number: 16427
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in meta-telephony[201705]: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, enable i...

2019-12-03 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/meta-telephony/+/16427 )

Change subject: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, 
enable it by default
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/16427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I0d875896bc97e973489672f004cb49fae02bdd46
Gerrit-Change-Number: 16427
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 03 Dec 2019 13:02:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in meta-telephony[201705]: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, enable i...

2019-12-03 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/meta-telephony/+/16427 )

Change subject: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, 
enable it by default
..


Patch Set 1: Verified+1

That works together with 
https://git.sysmocom.de/poky/system-images/commit/?h=pespin/201705=6c68a99f4531c83f95a7c077b62db4af276404bd

I tested it and it's not build for sysmobts platform after applying it.


--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/16427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I0d875896bc97e973489672f004cb49fae02bdd46
Gerrit-Change-Number: 16427
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 03 Dec 2019 12:58:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in meta-telephony[201705]: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, enable i...

2019-12-03 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/meta-telephony/+/16427 )


Change subject: libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, 
enable it by default
..

libosmo-abis.inc: Use PACKAGECONFIG to handle dahdi support, enable it by 
default

Building with DAHDI support can be controlled by bbappend or config file
on the BSP meta layer as described here:
https://www.yoctoproject.org/docs/current/ref-manual/ref-manual.html#var-PACKAGECONFIG

Change-Id: I0d875896bc97e973489672f004cb49fae02bdd46
---
M recipes-osmocom/libosmo-abis/libosmo-abis.inc
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/27/16427/1

diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis.inc 
b/recipes-osmocom/libosmo-abis/libosmo-abis.inc
index dcfcbf7..955ebe3 100644
--- a/recipes-osmocom/libosmo-abis/libosmo-abis.inc
+++ b/recipes-osmocom/libosmo-abis/libosmo-abis.inc
@@ -2,13 +2,17 @@
 HOMEPAGE = "https://osmocom.org/projects/libosmo-abis;
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 DEPENDS = "libosmocore ortp libtalloc"
-DEPENDS_append_geode = "dahdi-linux"

 inherit autotools pkgconfig

+PACKAGECONFIG ??= "\
+dahdi \
+"
+PACKAGECONFIG[dahdi] = "--enable-dahdi,--disable-dahdi,dahdi-linux,"
+
 PACKAGES =+ "libosmotrau libosmotrau-dev"

 FILES_libosmotrau = "${libdir}/libosmotrau${SOLIBS}"

--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/16427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I0d875896bc97e973489672f004cb49fae02bdd46
Gerrit-Change-Number: 16427
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange