Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-22 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 22 May 2018 09:57:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-22 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
connections attempts due to a unit_id mismatch between the BSC
and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 6365938..6f854d8 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1128,6 +1128,7 @@
BSC_CTR_PAGING_ATTEMPTED,
BSC_CTR_PAGING_DETACHED,
BSC_CTR_PAGING_RESPONDED,
+   BSC_CTR_UNKNOWN_UNIT_ID,
 };

 static const struct rate_ctr_desc bsc_ctr_description[] = {
@@ -1140,6 +1141,8 @@
[BSC_CTR_PAGING_ATTEMPTED] ={"paging:attempted", "Paging 
attempts for a subscriber."},
[BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging 
request send failures because no responsible BTS was found."},
[BSC_CTR_PAGING_RESPONDED] ={"paging:responded", "Paging 
attempts with successful response."},
+
+   [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", 
"Connection attempts from unknown IPA CCM Unit ID."},
 };


diff --git a/src/libbsc/bts_ipaccess_nanobts.c 
b/src/libbsc/bts_ipaccess_nanobts.c
index d5b3b21..823fd66 100644
--- a/src/libbsc/bts_ipaccess_nanobts.c
+++ b/src/libbsc/bts_ipaccess_nanobts.c
@@ -468,6 +468,7 @@
LOGP(DLINP, LOGL_ERROR, "Unable to find BTS configuration for "
" %u/%u/%u, disconnecting\n", dev->site_id,
dev->bts_id, dev->trx_id);
+   
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_UNKNOWN_UNIT_ID]);
return NULL;
}
DEBUGP(DLINP, "Identified BTS %u/%u/%u\n",

--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-22 Thread Stefan Sperling 
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9218

to look at the new patch set (#4).

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
connections attempts due to a unit_id mismatch between the BSC
and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/9218/4
--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-22 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3:

> One might think of implementing this somewhere generic in a
 > library, but I think we still have three IPA. implementations
 > around. In terms of naming, some reference to abis would be good,
 > as other interfaces (A, CTRL, ...) May also use IPA

Having reviewed the protocol layering between BTS and BSC, I agree that "abis" 
is a better prefix for the description of this counter.


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 22 May 2018 08:15:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3: Code-Review+1

One might think of implementing this somewhere generic in a library, but I 
think we still have three IPA. implementations around. In terms of naming, some 
reference to abis would be good, as other interfaces (A, CTRL, ...) May also 
use IPA


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Sat, 19 May 2018 08:05:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Sat, 19 May 2018 08:03:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3:

> > (1 comment)
 >
 > What does "IPA CCM" stand for?

We have no idea. We have never seen any specs for that protocol

 > The counter names are scoped to a topic (e.g. "handover:").
 > What would be a suitable topic to use instead of "oml:"? Would
 > "ipa:" be OK, "ipa:unknown_unit_id" ?

Ack


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Sat, 19 May 2018 08:02:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-18 Thread Stefan Sperling 
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9218

to look at the new patch set (#3).

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
connections attempts due to a unit_id mismatch between the BSC
and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/9218/3
--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-18 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 2:

The next patch set contains a counter description based you on your suggestion: 
"Connection attempts from unknown IPA CCM Unit ID."
I am not sure if this is a very good description for our intended purpose.

The purpose, as I understand, is to allow users who see this counter to take a 
mental leap from this counter to the unit_id directive in bsc/bts configuration 
files. I believe the description as it is now won't meet this goal in practice 
because it contains acronyms which make it hard for the user to categorize the 
message if the user does not know their correct expansion, and it does not 
contain the word "BTS".


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 18 May 2018 12:01:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-18 Thread Stefan Sperling 
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9218

to look at the new patch set (#2).

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
OML connections attempts due to a unit_id mismatch between the
BSC and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/9218/2
--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-18 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 1:

> (1 comment)

What does "IPA CCM" stand for?

The counter names are scoped to a topic (e.g. "handover:").
What would be a suitable topic to use instead of "oml:"? Would "ipa:" be OK, 
"ipa:unknown_unit_id" ?


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 18 May 2018 11:51:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-17 Thread Harald Welte 
Harald Welte has removed a vote on this change.

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Removed Code-Review+2 by Neels Hofmeyr 
--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-17 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/9218/1/src/libbsc/bts_ipaccess_nanobts.c
File src/libbsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/#/c/9218/1/src/libbsc/bts_ipaccess_nanobts.c@471
PS1, Line 471:  
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_BTS_UNKNOWN_UNIT_ID]);
this code is inserted *before* you know it's an OML or a RSL connection. The 
dispatch between OML/RSL is further down below in the switch statement.  So 
technically, you don't know it's an OML connection.  I guess the best way is to 
rename the counter and description (and possibly commit log message) to simply 
say "Connections with unknown IPA CCM Unit ID" without referring to OML or RSL 
explicitly.



--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 17 May 2018 20:13:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 1: Code-Review+2

maybe we should also count the successful BTS connections to add perspective to 
this counter


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 17 May 2018 15:38:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-17 Thread Stefan Sperling 
Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/9218


Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
OML connections attempts due to a unit_id mismatch between the
BSC and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/9218/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 6365938..aacb2d5 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1128,6 +1128,7 @@
BSC_CTR_PAGING_ATTEMPTED,
BSC_CTR_PAGING_DETACHED,
BSC_CTR_PAGING_RESPONDED,
+   BSC_CTR_BTS_UNKNOWN_UNIT_ID,
 };

 static const struct rate_ctr_desc bsc_ctr_description[] = {
@@ -1140,6 +1141,8 @@
[BSC_CTR_PAGING_ATTEMPTED] ={"paging:attempted", "Paging 
attempts for a subscriber."},
[BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging 
request send failures because no responsible BTS was found."},
[BSC_CTR_PAGING_RESPONDED] ={"paging:responded", "Paging 
attempts with successful response."},
+
+   [BSC_CTR_BTS_UNKNOWN_UNIT_ID] = {"oml:bts_unknown_unit_id", 
"OML connection attempts from BTS with unknown unit ID."},
 };


diff --git a/src/libbsc/bts_ipaccess_nanobts.c 
b/src/libbsc/bts_ipaccess_nanobts.c
index d5b3b21..b4d213a 100644
--- a/src/libbsc/bts_ipaccess_nanobts.c
+++ b/src/libbsc/bts_ipaccess_nanobts.c
@@ -468,6 +468,7 @@
LOGP(DLINP, LOGL_ERROR, "Unable to find BTS configuration for "
" %u/%u/%u, disconnecting\n", dev->site_id,
dev->bts_id, dev->trx_id);
+   
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_BTS_UNKNOWN_UNIT_ID]);
return NULL;
}
DEBUGP(DLINP, "Identified BTS %u/%u/%u\n",

--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling