Change in osmo-ci[master]: build-old-tags: remove LD_LIBRARY_PATH
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15762 ) Change subject: build-old-tags: remove LD_LIBRARY_PATH .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 Gerrit-Change-Number: 15762 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 11 Oct 2019 11:03:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: build-old-tags: remove LD_LIBRARY_PATH
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15762 ) Change subject: build-old-tags: remove LD_LIBRARY_PATH .. build-old-tags: remove LD_LIBRARY_PATH Do not set LD_LIBRARY_PATH during builds, as this causes testsuites to use the wrong libraries. This bug appeared with libosmocore, it gets built for master first, and then an old version like 1.2.0. When using LD_LIBRARY_PATH, the tests during the 1.2.0 build are executed against the libosmo*.so from master, which causes a few tests to fail. Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved osmith: Verified diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index c5e9685..58a0009 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -152,7 +152,6 @@ if ! PATH="$PWD:$PATH"\ PKG_CONFIG_PATH="$TEMP/inst_master/lib/pkgconfig:$TEMP/inst_legacy/lib/pkgconfig:$PKG_CONFIG_PATH" \ - LD_LIBRARY_PATH="$TEMP/inst_master/lib:$TEMP/inst_legacy/lib:$LD_LIBRARY_PATH" \ MAKE="make" \ PARALLEL_MAKE="$PARALLEL_MAKE" \ CHECK="$check" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 Gerrit-Change-Number: 15762 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in osmo-ci[master]: build-old-tags: remove LD_LIBRARY_PATH
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15762 ) Change subject: build-old-tags: remove LD_LIBRARY_PATH .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 Gerrit-Change-Number: 15762 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 11 Oct 2019 10:47:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: build-old-tags: remove LD_LIBRARY_PATH
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15762 ) Change subject: build-old-tags: remove LD_LIBRARY_PATH .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 Gerrit-Change-Number: 15762 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 11 Oct 2019 10:47:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: build-old-tags: remove LD_LIBRARY_PATH
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15762 ) Change subject: build-old-tags: remove LD_LIBRARY_PATH .. Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 Gerrit-Change-Number: 15762 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 11 Oct 2019 09:55:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ci[master]: build-old-tags: remove LD_LIBRARY_PATH
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15762 Change subject: build-old-tags: remove LD_LIBRARY_PATH .. build-old-tags: remove LD_LIBRARY_PATH Do not set LD_LIBRARY_PATH during builds, as this causes testsuites to use the wrong libraries. This bug appeared with libosmocore, it gets built for master first, and then an old version like 1.2.0. When using LD_LIBRARY_PATH, the tests during the 1.2.0 build are executed against the libosmo*.so from master, which causes a few tests to fail. Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/62/15762/1 diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index c5e9685..58a0009 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -152,7 +152,6 @@ if ! PATH="$PWD:$PATH"\ PKG_CONFIG_PATH="$TEMP/inst_master/lib/pkgconfig:$TEMP/inst_legacy/lib/pkgconfig:$PKG_CONFIG_PATH" \ - LD_LIBRARY_PATH="$TEMP/inst_master/lib:$TEMP/inst_legacy/lib:$LD_LIBRARY_PATH" \ MAKE="make" \ PARALLEL_MAKE="$PARALLEL_MAKE" \ CHECK="$check" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0bfb57e418b91c298337b9426448fbcfd7bf32e6 Gerrit-Change-Number: 15762 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
