Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-31 Thread osmith 
osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..

gen_makefile.py: detect changes in cpp files

Properly rebuild when cpp files (e.g. from osmo-trx) have been changed.

Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
---
M gen_makefile.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  osmith: Verified
  Harald Welte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved



diff --git a/gen_makefile.py b/gen_makefile.py
index c2b6128..1ae29f5 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -168,7 +168,7 @@
 ### {proj} ###

 {proj}_configure_files := $(shell find {src_proj} -name "Makefile.am" -or 
-name "*.in" )
-{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" )
+{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" -or 
-name "*.cpp" )

 .make.{proj}.clone:
@echo "\n\n\n= $@\n"

--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-31 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:14:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-31 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:11:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-30 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 1: Code-Review+1

I don't have +2 here.


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 30 Oct 2018 12:34:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:27:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-23 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11434


Change subject: gen_makefile.py: detect changes in cpp files
..

gen_makefile.py: detect changes in cpp files

Properly rebuild when cpp files (e.g. from osmo-trx) have been changed.

Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
---
M gen_makefile.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/34/11434/1

diff --git a/gen_makefile.py b/gen_makefile.py
index c2b6128..1ae29f5 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -168,7 +168,7 @@
 ### {proj} ###

 {proj}_configure_files := $(shell find {src_proj} -name "Makefile.am" -or 
-name "*.in" )
-{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" )
+{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" -or 
-name "*.cpp" )

 .make.{proj}.clone:
@echo "\n\n\n= $@\n"

--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith