Change in osmo-mgw[master]: osmux: Avoid processing further frames if conn not found
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11383 ) Change subject: osmux: Avoid processing further frames if conn not found .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09190140ba917dfada4b0952230b68e0f5f6d43d Gerrit-Change-Number: 11383 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Tue, 16 Oct 2018 20:45:00 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-mgw[master]: osmux: Avoid processing further frames if conn not found
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11383 )
Change subject: osmux: Avoid processing further frames if conn not found
..
osmux: Avoid processing further frames if conn not found
Other frames can come from known connections, so let's keep processing
each of them.
Change-Id: I09190140ba917dfada4b0952230b68e0f5f6d43d
---
M src/libosmo-mgcp/mgcp_osmux.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c
index ca446ff..a2c138d 100644
--- a/src/libosmo-mgcp/mgcp_osmux.c
+++ b/src/libosmo-mgcp/mgcp_osmux.c
@@ -394,7 +394,7 @@
/* FIXME: Get rid of CONN_ID_XXX! */
conn_bts = mgcp_conn_get_rtp(endp, CONN_ID_BTS);
if (!conn_bts)
- goto out;
+ continue;
if (!endp) {
LOGP(DLMGCP, LOGL_ERROR,
@@ -478,7 +478,7 @@
/* FIXME: Get rid of CONN_ID_XXX! */
conn_net = mgcp_conn_get_rtp(endp, CONN_ID_NET);
if (!conn_net)
- goto out;
+ continue;
if (!endp) {
LOGP(DLMGCP, LOGL_ERROR,
--
To view, visit https://gerrit.osmocom.org/11383
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09190140ba917dfada4b0952230b68e0f5f6d43d
Gerrit-Change-Number: 11383
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-mgw[master]: osmux: Avoid processing further frames if conn not found
Pau Espin Pedrol has uploaded this change for review. (
https://gerrit.osmocom.org/11383
Change subject: osmux: Avoid processing further frames if conn not found
..
osmux: Avoid processing further frames if conn not found
Other frames can come from known connections, so let's keep processing
each of them.
Change-Id: I09190140ba917dfada4b0952230b68e0f5f6d43d
---
M src/libosmo-mgcp/mgcp_osmux.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/83/11383/1
diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c
index ca446ff..a2c138d 100644
--- a/src/libosmo-mgcp/mgcp_osmux.c
+++ b/src/libosmo-mgcp/mgcp_osmux.c
@@ -394,7 +394,7 @@
/* FIXME: Get rid of CONN_ID_XXX! */
conn_bts = mgcp_conn_get_rtp(endp, CONN_ID_BTS);
if (!conn_bts)
- goto out;
+ continue;
if (!endp) {
LOGP(DLMGCP, LOGL_ERROR,
@@ -478,7 +478,7 @@
/* FIXME: Get rid of CONN_ID_XXX! */
conn_net = mgcp_conn_get_rtp(endp, CONN_ID_NET);
if (!conn_net)
- goto out;
+ continue;
if (!endp) {
LOGP(DLMGCP, LOGL_ERROR,
--
To view, visit https://gerrit.osmocom.org/11383
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09190140ba917dfada4b0952230b68e0f5f6d43d
Gerrit-Change-Number: 11383
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol
