subject:"Change in osmo\-msc\[master\]\: vty\: add command to show all known BSC"

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-13 Thread Max

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11711 )

Change subject: vty: add command to show all known BSC
..

vty: add command to show all known BSC

Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
---
M src/libmsc/msc_vty.c
1 file changed, 17 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index a16cec8..840559a 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -31,6 +31,8 @@
 #include 
 #include 

+#include 
+
 #include 
 #include 
 #include 
@@ -47,6 +49,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -467,6 +470,19 @@
return CMD_SUCCESS;
 }

+DEFUN(show_bsc, show_bsc_cmd,
+   "show bsc", SHOW_STR "BSC\n")
+{
+   struct bsc_context *bsc_ctx;
+   struct osmo_ss7_instance *ss7 = 
osmo_ss7_instance_find(gsmnet->a.cs7_instance);
+
+   llist_for_each_entry(bsc_ctx, >a.bscs, list) {
+   vty_out(vty, "BSC %s%s", osmo_sccp_addr_name(ss7, 
_ctx->bsc_addr), VTY_NEWLINE);
+   }
+
+   return CMD_SUCCESS;
+}
+
 static void vty_conn_hdr(struct vty *vty)
 {
vty_out(vty, "--ConnId Subscriber RAN --LAC Use --Tokens C 
A5 State%s",
@@ -1446,6 +1462,7 @@

install_element_ve(_subscr_cmd);
install_element_ve(_subscr_cache_cmd);
+   install_element_ve(_bsc_cmd);
install_element_ve(_msc_conn_cmd);
install_element_ve(_msc_transaction_cmd);


-- 
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11711 )

Change subject: vty: add command to show all known BSC
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Tue, 13 Nov 2018 15:58:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-13 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/11711 )

Change subject: vty: add command to show all known BSC
..


Patch Set 1:

Somewhat related is gerrit 11746 which saves CI which we could print as well 
when available.


--
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Tue, 13 Nov 2018 10:27:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-11 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/11711 )

Change subject: vty: add command to show all known BSC
..


Patch Set 1:

Good points, I've made https://osmocom.org/issues/3687 to track this.


--
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Sun, 11 Nov 2018 21:51:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-09 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11711 )

Change subject: vty: add command to show all known BSC
..


Patch Set 1: Code-Review+1

the next logical step would be to show more information but just the SCCP 
address.  This would include e.g.
* the location areas that we associate with this BSC
* the state of the BSC (e.g. reset fsm)
* the number of active SCCP connections from this BSC
* whatever else we have in terms of state that may be useful to expose to the 
user

Compare this e.g. with "show bts" in the BSC.


--
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 10 Nov 2018 06:51:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-09 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11711


Change subject: vty: add command to show all known BSC
..

vty: add command to show all known BSC

Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
---
M src/libmsc/msc_vty.c
1 file changed, 17 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/11711/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index a16cec8..840559a 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -31,6 +31,8 @@
 #include 
 #include 

+#include 
+
 #include 
 #include 
 #include 
@@ -47,6 +49,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -467,6 +470,19 @@
return CMD_SUCCESS;
 }

+DEFUN(show_bsc, show_bsc_cmd,
+   "show bsc", SHOW_STR "BSC\n")
+{
+   struct bsc_context *bsc_ctx;
+   struct osmo_ss7_instance *ss7 = 
osmo_ss7_instance_find(gsmnet->a.cs7_instance);
+
+   llist_for_each_entry(bsc_ctx, >a.bscs, list) {
+   vty_out(vty, "BSC %s%s", osmo_sccp_addr_name(ss7, 
_ctx->bsc_addr), VTY_NEWLINE);
+   }
+
+   return CMD_SUCCESS;
+}
+
 static void vty_conn_hdr(struct vty *vty)
 {
vty_out(vty, "--ConnId Subscriber RAN --LAC Use --Tokens C 
A5 State%s",
@@ -1446,6 +1462,7 @@

install_element_ve(_subscr_cmd);
install_element_ve(_subscr_cache_cmd);
+   install_element_ve(_bsc_cmd);
install_element_ve(_msc_conn_cmd);
install_element_ve(_msc_transaction_cmd);


--
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-msc[master]: vty: add command to show all known BSC

Change in osmo-msc[master]: vty: add command to show all known BSC

Change in osmo-msc[master]: vty: add command to show all known BSC

Change in osmo-msc[master]: vty: add command to show all known BSC

Change in osmo-msc[master]: vty: add command to show all known BSC

Change in osmo-msc[master]: vty: add command to show all known BSC

6 matches

Site Navigation

Mail list logo

Footer information