Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

2022-10-03 Thread keith 
keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 )

Change subject: Set MNCC_F_GCR field when the gcr is present
..

Set MNCC_F_GCR field when the gcr is present

Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the
MNCC field flag MNCC_F_GCR should be set when the GCR is present,
but did not set it.

Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
---
M src/mncc.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/mncc.c b/src/mncc.c
index f302b3e..02ba2cc 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -936,10 +936,12 @@
/* Encode the Global Call Reference (if present) */
if (call->gcr_present) {
msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR");
-   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0)
+   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0) {
LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode 
GCR\n", call->id);
-   else
+   } else {
memcpy([0], msg->data, rc);
+   mncc.fields |= MNCC_F_GCR;
+   }
msgb_free(msg);
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

2022-10-03 Thread fixeria 
Attention is currently required from: keith.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 )

Change subject: Set MNCC_F_GCR field when the gcr is present
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-Comment-Date: Mon, 03 Oct 2022 15:17:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

2022-10-03 Thread pespin 
Attention is currently required from: keith.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 )

Change subject: Set MNCC_F_GCR field when the gcr is present
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-Comment-Date: Mon, 03 Oct 2022 08:42:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

2022-10-02 Thread keith 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560

to look at the new patch set (#2).

Change subject: Set MNCC_F_GCR field when the gcr is present
..

Set MNCC_F_GCR field when the gcr is present

Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the
MNCC field flag MNCC_F_GCR should be set when the GCR is present,
but did not set it.

Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
---
M src/mncc.c
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/60/29560/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

2022-10-02 Thread keith 
keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 )


Change subject: Set MNCC_F_GCR field when the gcr is present
..

Set MNCC_F_GCR field when the gcr is present

Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the
MNCC field flag MNCC_F_GCR should be set when the GCR is present,
but did not set it.

Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
---
M src/mncc.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/60/29560/1

diff --git a/src/mncc.c b/src/mncc.c
index f302b3e..ddc1ae6 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -936,10 +936,13 @@
/* Encode the Global Call Reference (if present) */
if (call->gcr_present) {
msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR");
-   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0)
+   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0) {
LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode 
GCR\n", call->id);
-   else
+   } else {
memcpy([0], msg->data, rc);
+   mncc.fields |= MNCC_F_GCR;
+   }
+
msgb_free(msg);
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange