Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/18395 )
Change subject: Transceiver: Log when sending of CLK indications begins
..
Transceiver: Log when sending of CLK indications begins
When the logging category TRXCLK is set to info osmo-trx prints a
logline that informs about the sending of clock indications. In practice
this those log lines are often used to identify that osmo-trx and
osmo-bts are running properly, so it would be helpful, even in
productive use, if there would be an information in the log that the
sending of clock indications has begun. However, the regular printing of
the clock indication log line would soon flood the log. So, lets have an
addional log line that logs only once when the transceiver starts and
quickly informs at loglevel NOTICE that clock indications are now sent.
Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Related: OS#2577
---
M Transceiver52M/Transceiver.cpp
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index d9bda1d..1b9c5d4 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -1053,6 +1053,8 @@
return false;
if (mForceClockInterface || mTransmitDeadlineClock > mLastClockUpdateTime +
GSM::Time(216,0)) {
+if (mForceClockInterface)
+ LOGC(DTRXCLK, NOTICE) << "Sending CLOCK indications";
mForceClockInterface = false;
return writeClockInterface();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Gerrit-Change-Number: 18395
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18395 ) Change subject: Transceiver: Log when sending of CLK indications begins .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 May 2020 08:00:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18395 ) Change subject: Transceiver: Log when sending of CLK indications begins .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 May 2020 05:25:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 to look at the new patch set (#4). Change subject: Transceiver: Log when sending of CLK indications begins .. Transceiver: Log when sending of CLK indications begins When the logging category TRXCLK is set to info osmo-trx prints a logline that informs about the sending of clock indications. In practice this those log lines are often used to identify that osmo-trx and osmo-bts are running properly, so it would be helpful, even in productive use, if there would be an information in the log that the sending of clock indications has begun. However, the regular printing of the clock indication log line would soon flood the log. So, lets have an addional log line that logs only once when the transceiver starts and quickly informs at loglevel NOTICE that clock indications are now sent. Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Related: OS#2577 --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/18395/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18395 ) Change subject: Transceiver: Log when sending of CLK indications begins .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 26 May 2020 07:51:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18395 ) Change subject: Transceiver: Log when sending of CLK indications begins .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18395/3/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18395/3/Transceiver52M/Transceiver.cpp@a1169 PS3, Line 1169: FIXME -- This should be adaptive > I am still trying to guess the meaning of this comment, but why are you > removing it? I'd say this is already adaptative as seen in driveTxFIFO(), but indeed no relation to the commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 26 May 2020 07:16:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18395 ) Change subject: Transceiver: Log when sending of CLK indications begins .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18395/3/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18395/3/Transceiver52M/Transceiver.cpp@a1169 PS3, Line 1169: FIXME -- This should be adaptive I am still trying to guess the meaning of this comment, but why are you removing it? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 25 May 2020 18:51:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 to look at the new patch set (#3). Change subject: Transceiver: Log when sending of CLK indications begins .. Transceiver: Log when sending of CLK indications begins When the logging category TRXCLK is set to info osmo-trx prints a logline that informs about the sending of clock indications. In practice this those log lines are often used to identify that osmo-trx and osmo-bts are running properly, so it would be helpful, even in productive use, if there would be an information in the log that the sending of clock indications has begun. However, the regular printing of the clock indication log line would soon flood the log. So, lets have an addional log line that logs only once when the transceiver starts and quickly informs at loglevel NOTICE that clock indications are now sent. Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Related: OS#2577 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/18395/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18395 ) Change subject: Transceiver: Log when sending of CLK indications begins .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18395/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18395/2/Transceiver52M/Transceiver.cpp@1170 PS2, Line 1170: if (!mForceClockInterface) Let's not use this variable here. Move it to line 1056 in driveReceiveRadio. And by the way, you are applying the if codition wrong here, it's the opposite (mForceClockInterface is set to true at startup to force it being sent immediatelly.) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 22 May 2020 13:01:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/18395 )
Change subject: Transceiver: Log when sending of CLK indications begins
..
Patch Set 2:
(1 comment)
(ensuring all review comments are sent)
https://gerrit.osmocom.org/c/osmo-trx/+/18395/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/18395/1/Transceiver52M/Transceiver.cpp@1057
PS1, Line 1057: if (mForceClockInterface || mTransmitDeadlineClock >
mLastClockUpdateTime + GSM::Time(216,0)) {
> I would simply add the logging here based on whether mForceClockInterface is
> true. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Gerrit-Change-Number: 18395
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Fri, 22 May 2020 12:58:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 to look at the new patch set (#2). Change subject: Transceiver: Log when sending of CLK indications begins .. Transceiver: Log when sending of CLK indications begins When the logging category TRXCLK is set to info osmo-trx prints a logline that informs about the sending of clock indications. In practice this those log lines are often used to identify that osmo-trx and osmo-bts are running properly, so it would be helpful, even in productive use, if there would be an information in the log that the sending of clock indications has begun. However, the regular printing of the clock indication log line would soon flood the log. So, lets have an addional log line that logs only once when the transceiver starts and quickly informs at loglevel NOTICE that clock indications are now sent. Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Related: OS#2577 --- M Transceiver52M/Transceiver.cpp 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/18395/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a Gerrit-Change-Number: 18395 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/18395 )
Change subject: Transceiver: Log when sending of CLK indications begins
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmo-trx/+/18395/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/18395/1/Transceiver52M/Transceiver.cpp@1057
PS1, Line 1057: if (mForceClockInterface || mTransmitDeadlineClock >
mLastClockUpdateTime + GSM::Time(216,0)) {
I would simply add the logging here based on whether mForceClockInterface is
true. No need to use a new variable.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Gerrit-Change-Number: 18395
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Fri, 22 May 2020 11:58:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Log when sending of CLK indications begins
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/18395 )
Change subject: Transceiver: Log when sending of CLK indications begins
..
Transceiver: Log when sending of CLK indications begins
When the logging category TRXCLK is set to info osmo-trx prints a
logline that informs about the sending of clock indications. In practice
this those log lines are often used to identify that osmo-trx and
osmo-bts are running properly, so it would be helpful, even in
productive use, if there would be an information in the log that the
sending of clock indications has begun. However, the regular printing of
the clock indication log line would soon flood the log. So, lets have an
addional log line that logs only once when the transceiver starts and
quickly informs at loglevel NOTICE that clock indications are now sent.
Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Related: OS#2577
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/18395/1
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index d9bda1d..1af3e15 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -278,6 +278,8 @@
{
ScopedLock lock(mLock);
+ mClkIndSent = false;
+
if (mOn) {
LOG(ERR) << "Transceiver already running";
return true;
@@ -1166,7 +1168,11 @@
{
int msgLen;
char command[50];
- // FIXME -- This should be adaptive.
+
+ if (!mClkIndSent)
+LOGC(DTRXCLK, NOTICE) << "Sending CLOCK indications";
+ mClkIndSent = true;
+
sprintf(command,"IND CLOCK %llu",(unsigned long long)
(mTransmitDeadlineClock.FN()+2));
LOGC(DTRXCLK, INFO) << "sending " << command;
diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h
index 6e0d157..99d5b6c 100644
--- a/Transceiver52M/Transceiver.h
+++ b/Transceiver52M/Transceiver.h
@@ -273,6 +273,10 @@
void reset();
void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi);
+
+ /* Needed for logging only */
+ bool mClkIndSent;
+
};
void *RxUpperLoopAdapter(TrxChanThParams *params);
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Gerrit-Change-Number: 18395
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
