Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. doc: apply an rssi-offset of 28 by default. Set an rssi offset of 28 in the example configs to make sure that the power control loop gets RSSI values that match at least half way the reality when the 1800 Mhz band is used. For other bands the value will be different (See also related osmocom ticket) Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Related: OS#4468 --- M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index b851211..2905ed7 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -13,6 +13,9 @@ bind-ip 127.0.0.1 remote-ip 127.0.0.1 egprs disable + ! 28 dB offset below is valid only for the B2xx in 1800 MHz band, see + ! https://osmocom.org/issues/4468 for more details + rssi-offset 28.00 tx-sps 4 rx-sps 4 clock-ref external -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Apr 2020 15:26:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Apr 2020 13:25:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
laforge has uploaded a new patch set (#4) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. doc: apply an rssi-offset of 28 by default. Set an rssi offset of 28 in the example configs to make sure that the power control loop gets RSSI values that match at least half way the reality when the 1800 Mhz band is used. For other bands the value will be different (See also related osmocom ticket) Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Related: OS#4468 --- M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/96/17596/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 3: (1 comment) (ensure all comments get sent) https://gerrit.osmocom.org/c/osmo-trx/+/17596/3/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg File doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg: https://gerrit.osmocom.org/c/osmo-trx/+/17596/3/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg@16 PS3, Line 16: rssi-offset 28.00 > lol where all those zeros come from? The value is a float, we could probably do something about the format string, but I don't think the zeros hurt. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Apr 2020 10:00:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/17596/3/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg File doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg: https://gerrit.osmocom.org/c/osmo-trx/+/17596/3/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg@16 PS3, Line 16: rssi-offset 28.00 lol where all those zeros come from? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Apr 2020 12:33:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Apr 2020 10:35:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
Hello fixeria, laforge, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 to look at the new patch set (#3). Change subject: doc: apply an rssi-offset of 28 by default. .. doc: apply an rssi-offset of 28 by default. Set an rssi offset of 28 in the example configs to make sure that the power control loop gets RSSI values that match at least half way the reality when the 1800 Mhz band is used. For other bands the value will be different (See also related osmocom ticket) Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Related: OS#4468 --- M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/96/17596/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 2: Code-Review+1 we might want to add a comment to the file referring to the URL of the osmocom issue documenting the measurement process, and also stating that this value is only valid for the 1800 MHz band? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 27 Mar 2020 09:24:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 27 Mar 2020 09:23:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 25 Mar 2020 07:34:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: apply an rssi-offset of 28 by default.
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/17596 ) Change subject: doc: apply an rssi-offset of 28 by default. .. doc: apply an rssi-offset of 28 by default. Set an rssi offset of 28 in the example configs to make sure that the power control loop gets RSSI values that match at least half way the reality. Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 --- M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/96/17596/1 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index e47d183..3ba701b 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -13,6 +13,7 @@ bind-ip 127.0.0.1 remote-ip 127.0.0.1 egprs disable + rssi-offset 28.00 tx-sps 4 rx-sps 4 clock-ref external -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I62725fe454f54e2c7cb7550dadb1e6fc94337d78 Gerrit-Change-Number: 17596 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
