Change in osmo-trx[master]: lms: Reduce Rx gain from 47 to 34 dB
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9617 ) Change subject: lms: Reduce Rx gain from 47 to 34 dB .. lms: Reduce Rx gain from 47 to 34 dB Initially, Rx gain was hardcoded to be 47. This was too high for our setup and we were constantly getting "clipping detected" messages. Reducing Rx gain to 34 solved the issue. However, it looks like gains should be controlled through configuration files. Change-Id: I30580f18c4ad630c09f725b1d24c125fc3119809 --- M Transceiver52M/device/lms/LMSDevice.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index ad6f67b..c531a7f 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -319,7 +319,7 @@ return 0.0; } - dB = 47.0; + dB = 34.0; if (dB > maxRxGain()) dB = maxRxGain(); -- To view, visit https://gerrit.osmocom.org/9617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I30580f18c4ad630c09f725b1d24c125fc3119809 Gerrit-Change-Number: 9617 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
Change in osmo-trx[master]: lms: Reduce Rx gain from 47 to 34 dB
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9617 ) Change subject: lms: Reduce Rx gain from 47 to 34 dB .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30580f18c4ad630c09f725b1d24c125fc3119809 Gerrit-Change-Number: 9617 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 13 Jun 2018 21:45:26 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-trx[master]: lms: Reduce Rx gain from 47 to 34 dB
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9617 Change subject: lms: Reduce Rx gain from 47 to 34 dB .. lms: Reduce Rx gain from 47 to 34 dB Initially, Rx gain was hardcoded to be 47. This was too high for our setup and we were constantly getting "clipping detected" messages. Reducing Rx gain to 34 solved the issue. However, it looks like gains should be controlled through configuration files. Change-Id: I30580f18c4ad630c09f725b1d24c125fc3119809 --- M Transceiver52M/device/lms/LMSDevice.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/17/9617/1 diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index ad6f67b..c531a7f 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -319,7 +319,7 @@ return 0.0; } - dB = 47.0; + dB = 34.0; if (dB > maxRxGain()) dB = maxRxGain(); -- To view, visit https://gerrit.osmocom.org/9617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I30580f18c4ad630c09f725b1d24c125fc3119809 Gerrit-Change-Number: 9617 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte
