Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-15 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 )

Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print 
received PDU
..

MSC/SMS-over-GSUP: cosmetic: use a single log() call to print received PDU

Change-Id: I862766ac87715d5ad141405f343f0563fd75150f
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 5a23916..13cb8f4 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2208,8 +2208,7 @@
f_mo_sms_submit(spars);
alt {
[] GSUP.receive(mo_forwardSM) -> value gsup_msg_rx {
-   log("RX MO-forwardSM-Req");
-   log(gsup_msg_rx);
+   log("RX MO-forwardSM-Req: ", gsup_msg_rx);
setverdict(pass);
}
[] GSUP.receive {
@@ -2265,8 +2264,7 @@
f_mo_smma(spars);
alt {
[] GSUP.receive(mo_ReadyForSM) -> value gsup_msg_rx {
-   log("RX MO-ReadyForSM-Req");
-   log(gsup_msg_rx);
+   log("RX MO-ReadyForSM-Req: ", gsup_msg_rx);
setverdict(pass);
}
[] GSUP.receive {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I862766ac87715d5ad141405f343f0563fd75150f
Gerrit-Change-Number: 16881
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-15 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 )

Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print 
received PDU
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I862766ac87715d5ad141405f343f0563fd75150f
Gerrit-Change-Number: 16881
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 15 Jan 2020 16:07:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-15 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 )

Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print 
received PDU
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I862766ac87715d5ad141405f343f0563fd75150f
Gerrit-Change-Number: 16881
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 15 Jan 2020 12:42:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-14 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 )


Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print 
received PDU
..

MSC/SMS-over-GSUP: cosmetic: use a single log() call to print received PDU

Change-Id: I862766ac87715d5ad141405f343f0563fd75150f
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/81/16881/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 642eeb4..2859067 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2162,8 +2162,7 @@
f_mo_sms_submit(spars);
alt {
[] GSUP.receive(mo_forwardSM) -> value gsup_msg_rx {
-   log("RX MO-forwardSM-Req");
-   log(gsup_msg_rx);
+   log("RX MO-forwardSM-Req: ", gsup_msg_rx);
setverdict(pass);
}
[] GSUP.receive {
@@ -2219,8 +2218,7 @@
f_mo_smma(spars);
alt {
[] GSUP.receive(mo_ReadyForSM) -> value gsup_msg_rx {
-   log("RX MO-ReadyForSM-Req");
-   log(gsup_msg_rx);
+   log("RX MO-ReadyForSM-Req: ", gsup_msg_rx);
setverdict(pass);
}
[] GSUP.receive {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I862766ac87715d5ad141405f343f0563fd75150f
Gerrit-Change-Number: 16881
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange