Change in osmo-ttcn3-hacks[master]: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this l...

2018-06-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9557 )

Change subject: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to 
this library
..

Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this library

f_vty_transceive_match will be used by future SGSN tests.

Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
---
M hlr/HLR_Tests.ttcn
M library/Osmocom_VTY_Functions.ttcn
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 90a00bf..b4cf195 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -172,14 +172,6 @@
f_ipa_ctrl_start(mp_hlr_ip, mp_hlr_ctrl_port);
 }

-function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
-   var charstring ret := f_vty_transceive_ret(pt, cmd);
-   if (not match(ret, exp_ret)) {
-   setverdict(fail, "Non-matching VTY response: ", ret);
-   self.stop;
-   }
-}
-
 private template (value) charstring t_subscr_prefix(hexstring imsi) :=
"subscriber imsi " & hex2str(imsi) & " ";

diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index 2b74694..f118865 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -128,5 +128,13 @@
f_vty_config2(pt, {config_node}, cmd);
 }

+function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
+   var charstring ret := f_vty_transceive_ret(pt, cmd);
+   if (not match(ret, exp_ret)) {
+   setverdict(fail, "Non-matching VTY response: ", ret);
+   self.stop;
+   }
+}
+

 }

--
To view, visit https://gerrit.osmocom.org/9557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
Gerrit-Change-Number: 9557
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


Change in osmo-ttcn3-hacks[master]: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this l...

2018-06-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9557 )

Change subject: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to 
this library
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
Gerrit-Change-Number: 9557
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 13 Jun 2018 10:24:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-ttcn3-hacks[master]: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this l...

2018-06-12 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9557


Change subject: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to 
this library
..

Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this library

f_vty_transceive_match will be used by future SGSN tests.

Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
---
M hlr/HLR_Tests.ttcn
M library/Osmocom_VTY_Functions.ttcn
2 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/57/9557/1

diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 90a00bf..b4cf195 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -172,14 +172,6 @@
f_ipa_ctrl_start(mp_hlr_ip, mp_hlr_ctrl_port);
 }

-function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
-   var charstring ret := f_vty_transceive_ret(pt, cmd);
-   if (not match(ret, exp_ret)) {
-   setverdict(fail, "Non-matching VTY response: ", ret);
-   self.stop;
-   }
-}
-
 private template (value) charstring t_subscr_prefix(hexstring imsi) :=
"subscriber imsi " & hex2str(imsi) & " ";

diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index 2b74694..f118865 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -128,5 +128,13 @@
f_vty_config2(pt, {config_node}, cmd);
 }

+function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
+   var charstring ret := f_vty_transceive_ret(pt, cmd);
+   if (not match(ret, exp_ret)) {
+   setverdict(fail, "Non-matching VTY response: ", ret);
+   self.stop;
+   }
+}
+

 }

--
To view, visit https://gerrit.osmocom.org/9557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
Gerrit-Change-Number: 9557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus