Change in osmo-ttcn3-hacks[master]: pcu: Rename PCU*RAW* content to PCU
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 ) Change subject: pcu: Rename PCU*RAW* content to PCU .. Patch Set 3: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed Gerrit-Change-Number: 17975 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 30 Apr 2020 11:12:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Rename PCU*RAW* content to PCU
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 ) Change subject: pcu: Rename PCU*RAW* content to PCU .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed Gerrit-Change-Number: 17975 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 29 Apr 2020 16:19:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Rename PCU*RAW* content to PCU
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 ) Change subject: pcu: Rename PCU*RAW* content to PCU .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn File pcu/PCUIF_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn@51 PS1, Line 51: RAW_ > Shouldn't we get rid of this prefix / suffix / postfix in all symbols? Yes, but that would make the commit a lot more complex, since there's lots of those. I can do that in a next commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed Gerrit-Change-Number: 17975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 29 Apr 2020 14:05:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Rename PCU*RAW* content to PCU
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 ) Change subject: pcu: Rename PCU*RAW* content to PCU .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn File pcu/PCUIF_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn@51 PS1, Line 51: RAW_ Shouldn't we get rid of this prefix / suffix / postfix in all symbols? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed Gerrit-Change-Number: 17975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 29 Apr 2020 14:02:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
