Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: print colored verdict

2018-06-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9675 )

Change subject: ttcn3-tcpdump-stop.sh: print colored verdict
..

ttcn3-tcpdump-stop.sh: print colored verdict

Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
---
M ttcn3-tcpdump-stop.sh
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh
index a085bf7..9404841 100755
--- a/ttcn3-tcpdump-stop.sh
+++ b/ttcn3-tcpdump-stop.sh
@@ -2,6 +2,14 @@

 PIDFILE=/tmp/tcpdump.pid
 TESTCASE=$1
+VERDICT="$2"
+
+if [ x"$VERDICT" = x"pass" ]; then
+   echo "\033[1;32m== $TESTCASE $VERDICT ==\033[0m"
+else
+   echo "\033[1;31m-- $TESTCASE $VERDICT --\033[0m"
+fi
+echo

 if [ "z$TTCN3_PCAP_PATH" = "z" ]; then
TTCN3_PCAP_PATH=/tmp

--
To view, visit https://gerrit.osmocom.org/9675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
Gerrit-Change-Number: 9675
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 


Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: print colored verdict

2018-06-20 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9675 )

Change subject: ttcn3-tcpdump-stop.sh: print colored verdict
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
Gerrit-Change-Number: 9675
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:33:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: print colored verdict

2018-06-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9675 )

Change subject: ttcn3-tcpdump-stop.sh: print colored verdict
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
Gerrit-Change-Number: 9675
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 18 Jun 2018 22:02:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: print colored verdict

2018-06-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9675 )

Change subject: ttcn3-tcpdump-stop.sh: print colored verdict
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
Gerrit-Change-Number: 9675
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 18 Jun 2018 10:08:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: print colored verdict

2018-06-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/9675


Change subject: ttcn3-tcpdump-stop.sh: print colored verdict
..

ttcn3-tcpdump-stop.sh: print colored verdict

Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
---
M ttcn3-tcpdump-stop.sh
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/75/9675/1

diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh
index a085bf7..9404841 100755
--- a/ttcn3-tcpdump-stop.sh
+++ b/ttcn3-tcpdump-stop.sh
@@ -2,6 +2,14 @@

 PIDFILE=/tmp/tcpdump.pid
 TESTCASE=$1
+VERDICT="$2"
+
+if [ x"$VERDICT" = x"pass" ]; then
+   echo "\033[1;32m== $TESTCASE $VERDICT ==\033[0m"
+else
+   echo "\033[1;31m-- $TESTCASE $VERDICT --\033[0m"
+fi
+echo

 if [ "z$TTCN3_PCAP_PATH" = "z" ]; then
TTCN3_PCAP_PATH=/tmp

--
To view, visit https://gerrit.osmocom.org/9675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
Gerrit-Change-Number: 9675
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr