Change in osmocom-bb[master]: Minor Typo Changes
Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/9210 ) Change subject: Minor Typo Changes .. Abandoned -- To view, visit https://gerrit.osmocom.org/9210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I69126638d81d98ce8236cae543515c8dc743f404 Gerrit-Change-Number: 9210 Gerrit-PatchSet: 1 Gerrit-Owner: Nikos Balkanas Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol
Change in osmocom-bb[master]: Minor Typo Changes
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9210 ) Change subject: Minor Typo Changes .. Patch Set 1: Code-Review-2 this is not a typo. The libosmocore here is a "git subtree" of libosmocore.git in order to use a specific fixed old version whcih we know will work inside the firmware. We don't make modifications to this subtree here. See http://osmocom.org/issues/2378 for how this should be solved in general: By ensuring the "embedded" build of libosmocore works inside the osmocomBB firmware, followed by removing this subtree from osmocom-bb.git. -- To view, visit https://gerrit.osmocom.org/9210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69126638d81d98ce8236cae543515c8dc743f404 Gerrit-Change-Number: 9210 Gerrit-PatchSet: 1 Gerrit-Owner: Nikos BalkanasGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 17 May 2018 12:08:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: Minor Typo Changes
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9210 ) Change subject: Minor Typo Changes .. Patch Set 1: Code-Review-1 Please, describe the context in which the change is done (ie. the file/section modified) and provide more accurate description. Something like this would make more sense here: "configure.ac: Update mailing list info to point to baseband-devel" -- To view, visit https://gerrit.osmocom.org/9210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69126638d81d98ce8236cae543515c8dc743f404 Gerrit-Change-Number: 9210 Gerrit-PatchSet: 1 Gerrit-Owner: Nikos BalkanasGerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 17 May 2018 09:08:48 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: Minor Typo Changes
Nikos Balkanas has uploaded this change for review. ( https://gerrit.osmocom.org/9210 Change subject: Minor Typo Changes .. Minor Typo Changes Change-Id: I69126638d81d98ce8236cae543515c8dc743f404 --- M src/shared/libosmocore/configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/10/9210/1 diff --git a/src/shared/libosmocore/configure.ac b/src/shared/libosmocore/configure.ac index 24ddd0c..0ceb8e6 100644 --- a/src/shared/libosmocore/configure.ac +++ b/src/shared/libosmocore/configure.ac @@ -1,6 +1,6 @@ AC_INIT([libosmocore], m4_esyscmd([./git-version-gen .tarball-version]), - [open...@lists.osmocom.org]) + [baseband-de...@lists.osmocom.org]) AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.6]) AC_CONFIG_TESTDIR(tests) -- To view, visit https://gerrit.osmocom.org/9210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I69126638d81d98ce8236cae543515c8dc743f404 Gerrit-Change-Number: 9210 Gerrit-PatchSet: 1 Gerrit-Owner: Nikos Balkanas