Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy 
Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..

trx_toolkit/{ctrl,data}_if.py: add init log message

Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
---
M src/target/trx_toolkit/ctrl_if.py
M src/target/trx_toolkit/ctrl_if_trx.py
M src/target/trx_toolkit/data_if.py
3 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  Max: I would prefer this is not merged as is



diff --git a/src/target/trx_toolkit/ctrl_if.py 
b/src/target/trx_toolkit/ctrl_if.py
index 45bfa2b..a1c19f0 100644
--- a/src/target/trx_toolkit/ctrl_if.py
+++ b/src/target/trx_toolkit/ctrl_if.py
@@ -27,6 +27,10 @@
 from udp_link import UDPLink

 class CTRLInterface(UDPLink):
+   def __init__(self, *udp_link_args):
+   UDPLink.__init__(self, *udp_link_args)
+   log.debug("Init CTRL interface (%s)" % self.desc_link())
+
def handle_rx(self):
# Read data from socket
data, remote = self.sock.recvfrom(128)
diff --git a/src/target/trx_toolkit/ctrl_if_trx.py 
b/src/target/trx_toolkit/ctrl_if_trx.py
index 0d4935d..26a844f 100644
--- a/src/target/trx_toolkit/ctrl_if_trx.py
+++ b/src/target/trx_toolkit/ctrl_if_trx.py
@@ -46,7 +46,6 @@

def __init__(self, trx, *udp_link_args):
CTRLInterface.__init__(self, *udp_link_args)
-   log.info("Init CTRL interface (%s)" % self.desc_link())

# Link with Transceiver instance we belong to
self.trx = trx
diff --git a/src/target/trx_toolkit/data_if.py 
b/src/target/trx_toolkit/data_if.py
index a773c04..b1ba1e5 100644
--- a/src/target/trx_toolkit/data_if.py
+++ b/src/target/trx_toolkit/data_if.py
@@ -28,6 +28,10 @@
 from data_msg import *

 class DATAInterface(UDPLink):
+   def __init__(self, *udp_link_args):
+   UDPLink.__init__(self, *udp_link_args)
+   log.debug("Init DATA interface (%s)" % self.desc_link())
+
def recv_raw_data(self):
data, _ = self.sock.recvfrom(512)
return data

--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..


Patch Set 3: Code-Review+2

As (I hope) all warnings were addressed in 
I67b1e850094cf8e279777c45c7544886be42a009, I am merging this patch.


--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 14 Jan 2019 23:51:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..


Patch Set 3:

> Patch Set 2: Code-Review-1

Please see I67b1e850094cf8e279777c45c7544886be42a009.


--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 14 Jan 2019 21:00:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..


Patch Set 3:

> it might avoid confusion if we don't call it CTRL in Osmocom... if
 > not in the code, then maybe at least in logging? TRXCTRL? TRXCTL?

TBH, I don't see any confusion with libosmoctrl's CTRL interface (which could 
be also named in more concrete way, e.g. OCTRL) as TRX toolkit is not using 
this library and will never do.

But I understand that some users, who are just starting to use this framework, 
may confuse this control interface with libosmoctrl's one.

So, ok, let's stick to TRXC / TRXD at least in logging.
I'll do this in a separate change.


--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 14 Jan 2019 20:27:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy 
Hello Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12547

to look at the new patch set (#3).

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..

trx_toolkit/{ctrl,data}_if.py: add init log message

Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
---
M src/target/trx_toolkit/ctrl_if.py
M src/target/trx_toolkit/ctrl_if_trx.py
M src/target/trx_toolkit/data_if.py
3 files changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/47/12547/3
--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12547/2/src/target/trx_toolkit/ctrl_if.py
File src/target/trx_toolkit/ctrl_if.py:

https://gerrit.osmocom.org/#/c/12547/2/src/target/trx_toolkit/ctrl_if.py@32
PS2, Line 32:   log.debug("Init CTRL interface (%s)" % self.desc_link())
Same in here.



--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Mon, 14 Jan 2019 18:44:33 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..


Patch Set 2:

> it might avoid confusion if we don't call it CTRL in Osmocom... if not in the 
> code, then maybe at least in logging? TRXCTRL? TRXCTL?

It's called TRXCTRL in OsmoTRX (see 1595ddaa5fc1dcc4e04168e43fc82e3c71fdb3fd) 
so I think it's better to do the same in here.


--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Max 
Gerrit-Comment-Date: Mon, 14 Jan 2019 18:43:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..


Patch Set 2: Code-Review+1

it might avoid confusion if we don't call it CTRL in Osmocom... if not in the 
code, then maybe at least in logging? TRXCTRL? TRXCTL?


--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 14 Jan 2019 12:54:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-13 Thread Vadim Yanitskiy 
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12547


Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..

trx_toolkit/{ctrl,data}_if.py: add init log message

Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
---
M src/target/trx_toolkit/ctrl_if.py
M src/target/trx_toolkit/ctrl_if_trx.py
M src/target/trx_toolkit/data_if.py
3 files changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/47/12547/1

diff --git a/src/target/trx_toolkit/ctrl_if.py 
b/src/target/trx_toolkit/ctrl_if.py
index 45bfa2b..a1c19f0 100644
--- a/src/target/trx_toolkit/ctrl_if.py
+++ b/src/target/trx_toolkit/ctrl_if.py
@@ -27,6 +27,10 @@
 from udp_link import UDPLink

 class CTRLInterface(UDPLink):
+   def __init__(self, *udp_link_args):
+   UDPLink.__init__(self, *udp_link_args)
+   log.debug("Init CTRL interface (%s)" % self.desc_link())
+
def handle_rx(self):
# Read data from socket
data, remote = self.sock.recvfrom(128)
diff --git a/src/target/trx_toolkit/ctrl_if_trx.py 
b/src/target/trx_toolkit/ctrl_if_trx.py
index 0d4935d..26a844f 100644
--- a/src/target/trx_toolkit/ctrl_if_trx.py
+++ b/src/target/trx_toolkit/ctrl_if_trx.py
@@ -46,7 +46,6 @@

def __init__(self, trx, *udp_link_args):
CTRLInterface.__init__(self, *udp_link_args)
-   log.info("Init CTRL interface (%s)" % self.desc_link())

# Link with Transceiver instance we belong to
self.trx = trx
diff --git a/src/target/trx_toolkit/data_if.py 
b/src/target/trx_toolkit/data_if.py
index a773c04..b1ba1e5 100644
--- a/src/target/trx_toolkit/data_if.py
+++ b/src/target/trx_toolkit/data_if.py
@@ -28,6 +28,10 @@
 from data_msg import *

 class DATAInterface(UDPLink):
+   def __init__(self, *udp_link_args):
+   UDPLink.__init__(self, *udp_link_args)
+   log.debug("Init DATA interface (%s)" % self.desc_link())
+
def recv_raw_data(self):
data, _ = self.sock.recvfrom(512)
return data

--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy