[MERGED] libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: add osmo_fsm_inst_update_id_f() .. add osmo_fsm_inst_update_id_f() In the osmo-msc, I would like to set the subscr conn FSM identifier by a string

libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76743a7642f2449fd33350691ac8ebbf4400371d Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-08 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7629 to look at the new patch set (#2). add osmo_fsm_inst_update_id_f() In the osmo-msc, I would like to set the subscr conn FSM identifier by a string format, to include the type of

libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-04 Thread Harald Welte
Patch Set 1: Fine with me, but should have unit test coverage, including check for no memleak? -- To view, visit https://gerrit.osmocom.org/7629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76743a7642f2449fd33350691ac8ebbf4400371d

libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-04 Thread Neels Hofmeyr
Patch Set 1: I'm not sure if this is just code bloat or worth the API real estate. What do you guys think? -- To view, visit https://gerrit.osmocom.org/7629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] libosmocore[master]: add osmo_fsm_inst_update_id_f()

2018-04-04 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7629 add osmo_fsm_inst_update_id_f() In the osmo-msc, I would like to set the subscr conn FSM identifier by a string format, to include the type of Complete Layer 3 that is taking place. I could each time talloc a string and free it again. This API is more