Harald Welte has submitted this change and it was merged.
Change subject: gsm0480: handle UnstructuredSS Request with DSC != 0x0F
..
gsm0480: handle UnstructuredSS Request with DSC != 0x0F
According to GSM 04.08, 4.4.2 "ASN.1
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
Gerrit-PatchSet: 9
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
Gerrit-PatchSet: 9
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3376
to look at the new patch set (#9).
gsm0480: handle UnstructuredSS Request with DSC != 0x0F
According to GSM 04.08, 4.4.2 "ASN.1 data types":
the
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
Gerrit-PatchSet: 8
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3376
to look at the new patch set (#8).
gsm0480: handle UnstructuredSS Request with DSC != 0x0F
According to GSM 04.08, 4.4.2 "ASN.1 data types":
the
Patch Set 7: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3376/7/src/gsm/gsm0480.c
File src/gsm/gsm0480.c:
Line 478: num_chars = uss_req_data[6];
> do we actually verify that we have at least 6 bytes of data available in us
Sorry, I must be blind. We verify 8 bytes
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/3376/7/src/gsm/gsm0480.c
File src/gsm/gsm0480.c:
Line 478: num_chars = uss_req_data[6];
do we actually verify that we have at least 6 bytes of data available in
uss_rea_data[] buffer? What if the sender sent a
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3376
to look at the new patch set (#7).
gsm0480: handle UnstructuredSS Request with DSC != 0x0F
According to GSM 04.08, 4.4.2 "ASN.1 data types":
the
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3376
to look at the new patch set (#6).
gsm0480: handle UnstructuredSS request with DSC != 0x0F
Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
---
M
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3376
to look at the new patch set (#5).
gsm0480: handle UnstructuredSS request with DSC != 0x0F
Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
---
M
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
gsm0480: handle UnstructuredSS request with DSC != 0x0F
Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
---
M src/gsm/gsm0480.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/3376/2
diff --git a/src/gsm/gsm0480.c
Review at https://gerrit.osmocom.org/3376
gsm0480: handle UnstructuredSS request with DSC != 0x0F
Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
---
M src/gsm/gsm0480.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
15 matches
Mail list logo