[MERGED] libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0480: handle UnstructuredSS Request with DSC != 0x0F .. gsm0480: handle UnstructuredSS Request with DSC != 0x0F According to GSM 04.08, 4.4.2 "ASN.1

libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-17 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 Gerrit-PatchSet: 9 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-14 Thread Alexander Chemeris
Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 Gerrit-PatchSet: 9 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-14 Thread Vadim Yanitskiy
Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#9). gsm0480: handle UnstructuredSS Request with DSC != 0x0F According to GSM 04.08, 4.4.2 "ASN.1 data types": the

libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-14 Thread Alexander Chemeris
Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 Gerrit-PatchSet: 8 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-14 Thread Vadim Yanitskiy
Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#8). gsm0480: handle UnstructuredSS Request with DSC != 0x0F According to GSM 04.08, 4.4.2 "ASN.1 data types": the

libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-12 Thread Harald Welte
Patch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/3376/7/src/gsm/gsm0480.c File src/gsm/gsm0480.c: Line 478: num_chars = uss_req_data[6]; > do we actually verify that we have at least 6 bytes of data available in us Sorry, I must be blind. We verify 8 bytes

libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-12 Thread Harald Welte
Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/3376/7/src/gsm/gsm0480.c File src/gsm/gsm0480.c: Line 478: num_chars = uss_req_data[6]; do we actually verify that we have at least 6 bytes of data available in uss_rea_data[] buffer? What if the sender sent a

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS Request with DSC != 0x0F

2018-01-11 Thread Vadim Yanitskiy
Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#7). gsm0480: handle UnstructuredSS Request with DSC != 0x0F According to GSM 04.08, 4.4.2 "ASN.1 data types": the

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2018-01-10 Thread Vadim Yanitskiy
Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#6). gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2018-01-10 Thread Vadim Yanitskiy
Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#5). gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M

libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2017-08-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2017-07-30 Thread Alexander Chemeris
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2017-07-29 Thread Vadim Yanitskiy
gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M src/gsm/gsm0480.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/3376/2 diff --git a/src/gsm/gsm0480.c

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3376 gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M src/gsm/gsm0480.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore