[MERGED] openbsc[master]: handover_logic: set correct link to bts for subscriber_conne...
Harald Welte has submitted this change and it was merged. Change subject: handover_logic: set correct link to bts for subscriber_connection in case of moving this connection to another bts .. handover_logic: set correct link to bts for subscriber_connection in case of moving this connection to another bts In case of successful completion of handover gsm_subscriber_connection could be moved from one bts to another, so connection link to bts should be replaced by link to bts, which owns new_lchan. This bug was detected, because conn->bts->nr is used in call control log messages and wrong number of bts was observed in these messages after handover. Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9 --- M openbsc/src/libbsc/handover_logic.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/openbsc/src/libbsc/handover_logic.c b/openbsc/src/libbsc/handover_logic.c index 4dd913b..795a2ee 100644 --- a/openbsc/src/libbsc/handover_logic.c +++ b/openbsc/src/libbsc/handover_logic.c @@ -281,6 +281,7 @@ new_lchan->conn->ho_lchan = NULL; new_lchan->conn->lchan = new_lchan; + new_lchan->conn->bts = new_lchan->ts->trx->bts; ho->old_lchan->conn = NULL; lchan_release(ho->old_lchan, 0, RSL_REL_LOCAL_END); -- To view, visit https://gerrit.osmocom.org/3466 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Ivan Kluchnikov Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
openbsc[master]: handover_logic: set correct link to bts for subscriber_conne...
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3466 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Ivan Kluchnikov Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] openbsc[master]: handover_logic: set correct link to bts for subscriber_conne...
Review at https://gerrit.osmocom.org/3466 handover_logic: set correct link to bts for subscriber_connection in case of moving this connection to another bts In case of successful completion of handover gsm_subscriber_connection could be moved from one bts to another, so connection link to bts should be replaced by link to bts, which owns new_lchan. This bug was detected, because conn->bts->nr is used in call control log messages and wrong number of bts was observed in these messages after handover. Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9 --- M openbsc/src/libbsc/handover_logic.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/66/3466/1 diff --git a/openbsc/src/libbsc/handover_logic.c b/openbsc/src/libbsc/handover_logic.c index 4dd913b..795a2ee 100644 --- a/openbsc/src/libbsc/handover_logic.c +++ b/openbsc/src/libbsc/handover_logic.c @@ -281,6 +281,7 @@ new_lchan->conn->ho_lchan = NULL; new_lchan->conn->lchan = new_lchan; + new_lchan->conn->bts = new_lchan->ts->trx->bts; ho->old_lchan->conn = NULL; lchan_release(ho->old_lchan, 0, RSL_REL_LOCAL_END); -- To view, visit https://gerrit.osmocom.org/3466 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Ivan Kluchnikov
