[MERGED] osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1
..


bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
---
M src/libbsc/bsc_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_vty.c b/src/libbsc/bsc_vty.c
index 9dc754e..6daeb98 100644
--- a/src/libbsc/bsc_vty.c
+++ b/src/libbsc/bsc_vty.c
@@ -1411,9 +1411,9 @@
 void (*dump_cb)(struct vty *, struct gsm_lchan *))
 {
struct gsm_network *net = gsmnet_from_vty(vty);
-   struct gsm_bts *bts;
-   struct gsm_bts_trx *trx;
-   struct gsm_bts_trx_ts *ts;
+   struct gsm_bts *bts = NULL;
+   struct gsm_bts_trx *trx = NULL;
+   struct gsm_bts_trx_ts *ts = NULL;
struct gsm_lchan *lchan;
int bts_nr, trx_nr, ts_nr, lchan_nr;
 

-- 
To view, visit https://gerrit.osmocom.org/7509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

[Neels Hofmeyr]

Patch Set 1: Code-Review+2

yea I meant in the commit log but ok

-- 
To view, visit https://gerrit.osmocom.org/7509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

[Pau Espin Pedrol]

Patch Set 1:

/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_vty.c: In function 
‘lchan_summary’:
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_vty.c:1464:9: error: ‘ts’ 
may be used uninitialized in this function [-Werror=maybe-uninitialized]
   lchan = >lchan[lchan_nr];
   ~~^~
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_vty.c:1452:6: error: 
‘trx’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   ts = >ts[ts_nr];
   ~~~^
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_vty.c:1440:7: error: 
‘bts’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   trx = gsm_bts_trx_num(bts, trx_nr);
   ^~

-- 
To view, visit https://gerrit.osmocom.org/7509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

[Neels Hofmeyr]

Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/7509/1//COMMIT_MSG
Commit Message:

Line 8: 
would be nice to include the error message from gcc, so we can have an opinion 
on how you dealt with it


-- 
To view, visit https://gerrit.osmocom.org/7509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

[PATCH] osmo-bsc[master]: bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7509

bsc_vty: Fix uninitialized var false positive on gcc 7.3.1

Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
---
M src/libbsc/bsc_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/7509/1

diff --git a/src/libbsc/bsc_vty.c b/src/libbsc/bsc_vty.c
index 9dc754e..6daeb98 100644
--- a/src/libbsc/bsc_vty.c
+++ b/src/libbsc/bsc_vty.c
@@ -1411,9 +1411,9 @@
 void (*dump_cb)(struct vty *, struct gsm_lchan *))
 {
struct gsm_network *net = gsmnet_from_vty(vty);
-   struct gsm_bts *bts;
-   struct gsm_bts_trx *trx;
-   struct gsm_bts_trx_ts *ts;
+   struct gsm_bts *bts = NULL;
+   struct gsm_bts_trx *trx = NULL;
+   struct gsm_bts_trx_ts *ts = NULL;
struct gsm_lchan *lchan;
int bts_nr, trx_nr, ts_nr, lchan_nr;
 

-- 
To view, visit https://gerrit.osmocom.org/7509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2b315d76081f7ef5f2faf07c502f20196ba6a09
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol