[MERGED] osmo-bsc[master]: gsm_network: drop unused trans_list
Neels Hofmeyr has submitted this change and it was merged. Change subject: gsm_network: drop unused trans_list .. gsm_network: drop unused trans_list Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 --- M include/osmocom/bsc/gsm_data.h M src/libbsc/net_init.c 2 files changed, 0 insertions(+), 7 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index a0f2114..1d12f3d 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1144,12 +1144,6 @@ struct rate_ctr_group *bsc_ctrs; - /* -* TODO: Move the trans_list into the subscriber connection and -* create a pending list for MT transactions. These exist before -* we have a subscriber connection. -*/ - struct llist_head trans_list; struct bsc_api *bsc_api; unsigned int num_bts; diff --git a/src/libbsc/net_init.c b/src/libbsc/net_init.c index 4fa59ed..c5c7c5e 100644 --- a/src/libbsc/net_init.c +++ b/src/libbsc/net_init.c @@ -55,7 +55,6 @@ /* Use 30 min periodic update interval as sane default */ net->t3212 = 5; - INIT_LLIST_HEAD(&net->trans_list); INIT_LLIST_HEAD(&net->subscr_conns); net->bsc_subscribers = talloc_zero(net, struct llist_head); -- To view, visit https://gerrit.osmocom.org/6439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr
[PATCH] osmo-bsc[master]: gsm_network: drop unused trans_list
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6439 to look at the new patch set (#4). gsm_network: drop unused trans_list Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 --- M include/osmocom/bsc/gsm_data.h M src/libbsc/net_init.c 2 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/6439/4 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index a0f2114..1d12f3d 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1144,12 +1144,6 @@ struct rate_ctr_group *bsc_ctrs; - /* -* TODO: Move the trans_list into the subscriber connection and -* create a pending list for MT transactions. These exist before -* we have a subscriber connection. -*/ - struct llist_head trans_list; struct bsc_api *bsc_api; unsigned int num_bts; diff --git a/src/libbsc/net_init.c b/src/libbsc/net_init.c index 4fa59ed..c5c7c5e 100644 --- a/src/libbsc/net_init.c +++ b/src/libbsc/net_init.c @@ -55,7 +55,6 @@ /* Use 30 min periodic update interval as sane default */ net->t3212 = 5; - INIT_LLIST_HEAD(&net->trans_list); INIT_LLIST_HEAD(&net->subscr_conns); net->bsc_subscribers = talloc_zero(net, struct llist_head); -- To view, visit https://gerrit.osmocom.org/6439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
osmo-bsc[master]: gsm_network: drop unused trans_list
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] osmo-bsc[master]: gsm_network: drop unused trans_list
Review at https://gerrit.osmocom.org/6439 gsm_network: drop unused trans_list Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 --- M include/osmocom/bsc/gsm_data.h M src/libbsc/net_init.c 2 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/6439/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index a0f2114..1d12f3d 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1144,12 +1144,6 @@ struct rate_ctr_group *bsc_ctrs; - /* -* TODO: Move the trans_list into the subscriber connection and -* create a pending list for MT transactions. These exist before -* we have a subscriber connection. -*/ - struct llist_head trans_list; struct bsc_api *bsc_api; unsigned int num_bts; diff --git a/src/libbsc/net_init.c b/src/libbsc/net_init.c index 4fa59ed..c5c7c5e 100644 --- a/src/libbsc/net_init.c +++ b/src/libbsc/net_init.c @@ -55,7 +55,6 @@ /* Use 30 min periodic update interval as sane default */ net->t3212 = 5; - INIT_LLIST_HEAD(&net->trans_list); INIT_LLIST_HEAD(&net->subscr_conns); net->bsc_subscribers = talloc_zero(net, struct llist_head); -- To view, visit https://gerrit.osmocom.org/6439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr
