Harald Welte has submitted this change and it was merged.
Change subject: Cosmetic fixes for power ramping code.
..
Cosmetic fixes for power ramping code.
Fix typos in 2 comments.
Change-Id: I214bcc8b78446bfea450fe445fa9391898
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6287
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I214bcc8b78446bfea450fe445fa9391898638905
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6287/1/src/common/tx_power.c
File src/common/tx_power.c:
Line 153: return (tpp->p_total_tgt_mdBm > tpp->p_total_cur_mdBm);
> sorry, I really prefer the more verbose version, I think it is what we do i
Sure, if you prefer that, I don'
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6287
to look at the new patch set (#2).
Cosmetic fixes for power ramping code.
Fix typos in 2 comments.
Change-Id: I214bcc8b78446bfea450fe445fa9391898638905
---
M src/commo
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6287/1/src/common/tx_power.c
File src/common/tx_power.c:
Line 153: return (tpp->p_total_tgt_mdBm > tpp->p_total_cur_mdBm);
sorry, I really prefer the more verbose version, I think it is what we do in
Osmocom in other places, too.
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6287
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I214bcc8b78446bfea450fe445fa9391898638905
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/6287
Cosmetic fixes for power ramping code.
Reduce a logic expression to less lines of code:
'if (foo) return 1; else return 0;' is equivalent to just 'return (foo);'
Fix typos in 2 comments.
Change-Id: I214bcc8b78446bfea450fe445fa9391898638905
---
M src/c
