osmo-bts[master]: osmo-bts-trx: init nbits to know value

[Vadim Yanitskiy]

Patch Set 1:

Hey, I am not sure that this exactly the fix of described problem.

There should be the reason, why '_sched_dl_burst' returns bits
without setting the nbits...

-- 
To view, visit https://gerrit.osmocom.org/6321
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

[MERGED] osmo-bts[master]: osmo-bts-trx: init nbits to know value

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo-bts-trx: init nbits to know value
..


osmo-bts-trx: init nbits to know value

It seems like some of the functions invoked by _sched_dl_burst()
do not sent nbits properly. This leads to a number of errors on
startup:

trx_if.c:593 Tx burst length 65535 invalid

It happens in conjunction with:

Transceiver.cpp:382:pushRadioVector: dumping STALE burst in TRX->USRP interface

Let's fix this by initializing nbits to 0 to make sure those bursts
are properly ignored.

Change-Id: Iaf85826861163c185925de528c8347ab22779e30
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 0f3272e..f53e482 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1300,7 +1300,7 @@
uint8_t tn;
const ubit_t *bits;
uint8_t gain;
-   uint16_t nbits;
+   uint16_t nbits = 0;
 
/* send time indication */
l1if_mph_time_ind(bts, fn);

-- 
To view, visit https://gerrit.osmocom.org/6321
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-bts[master]: osmo-bts-trx: init nbits to know value

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6321
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-bts[master]: osmo-bts-trx: init nbits to know value

[Max]

Review at  https://gerrit.osmocom.org/6321

osmo-bts-trx: init nbits to know value

It seems like some of the functions invoked by _sched_dl_burst()
do not sent nbits properly. This leads to a number of errors on
startup:

trx_if.c:593 Tx burst length 65535 invalid

It happens in conjunction with:

Transceiver.cpp:382:pushRadioVector: dumping STALE burst in TRX->USRP interface

Let's fix this by initializing nbits to 0 to make sure those bursts
are properly ignored.

Change-Id: Iaf85826861163c185925de528c8347ab22779e30
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/21/6321/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 0f3272e..f53e482 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1300,7 +1300,7 @@
uint8_t tn;
const ubit_t *bits;
uint8_t gain;
-   uint16_t nbits;
+   uint16_t nbits = 0;
 
/* send time indication */
l1if_mph_time_ind(bts, fn);

-- 
To view, visit https://gerrit.osmocom.org/6321
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max