osmo-bts[master]: scheduler.c: Print message when burst substitution happens
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6870 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79eab37c80647c9ab64f399fa4676d97af3e9ad Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[MERGED] osmo-bts[master]: scheduler.c: Print message when burst substitution happens
Harald Welte has submitted this change and it was merged. Change subject: scheduler.c: Print message when burst substitution happens .. scheduler.c: Print message when burst substitution happens Whenever we receive discontinuous frame numbers from the TRX socket, osmo-bts-trx is substituting zero-filled bursts for those frame numbers which we missed. Don't just do this silently, but actually log about it, as it is an error. Note: This [currently] happens when using a virtual air interface with trxcon as opposed to a real SDR receiver with osmo-trx. Change-Id: If79eab37c80647c9ab64f399fa4676d97af3e9ad --- M src/common/scheduler.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 4e48160..e6e7eaf 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1725,8 +1725,11 @@ func(l1t, tn, fn, chan, bid, bits, nbits, rssi, toa); } else if (chan != TRXC_RACH && !l1cs->ho_rach_detect) { sbit_t spare[GSM_BURST_LEN]; - memset(spare, 0, GSM_BURST_LEN); + /* We missed a couple of frame numbers (system overload?) and are now +* substituting some zero-filled bursts for those bursts we missed */ + LOGPFN(DL1P, LOGL_ERROR, fn, "Substituting all-zero burst (current_fn=%u, " + "elapsed=%u\n", current_fn, elapsed); func(l1t, tn, fn, chan, bid, spare, GSM_BURST_LEN, -128, 0); } -- To view, visit https://gerrit.osmocom.org/6870 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If79eab37c80647c9ab64f399fa4676d97af3e9ad Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
[PATCH] osmo-bts[master]: scheduler.c: Print message when burst substitution happens
Review at https://gerrit.osmocom.org/6870 scheduler.c: Print message when burst substitution happens Whenever we receive discontinuous frame numbers from the TRX socket, osmo-bts-trx is substituting zero-filled bursts for those frame numbers which we missed. Don't just do this silently, but actually log about it, as it is an error. Note: This [currently] happens when using a virtual air interface with trxcon as opposed to a real SDR receiver with osmo-trx. Change-Id: If79eab37c80647c9ab64f399fa4676d97af3e9ad --- M src/common/scheduler.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/6870/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 4e48160..e6e7eaf 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1725,8 +1725,11 @@ func(l1t, tn, fn, chan, bid, bits, nbits, rssi, toa); } else if (chan != TRXC_RACH && !l1cs->ho_rach_detect) { sbit_t spare[GSM_BURST_LEN]; - memset(spare, 0, GSM_BURST_LEN); + /* We missed a couple of frame numbers (system overload?) and are now +* substituting some zero-filled bursts for those bursts we missed */ + LOGPFN(DL1P, LOGL_ERROR, fn, "Substituting all-zero burst (current_fn=%u, " + "elapsed=%u\n", current_fn, elapsed); func(l1t, tn, fn, chan, bid, spare, GSM_BURST_LEN, -128, 0); } -- To view, visit https://gerrit.osmocom.org/6870 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If79eab37c80647c9ab64f399fa4676d97af3e9ad Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte